All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Pekon Gupta <pekon@ti.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	ijc+devicetree@hellion.org.uk, linux-omap@vger.kernel.org,
	arnd@arndb.de, Pawel.Moll@arm.com, dedekind1@gmail.com,
	tony@atomide.com, avinashphilipk@gmail.com,
	swarren@wwwdotorg.org, jp.francois@cynove.com, balbi@ti.com,
	robherring2@gmail.com, bcousson@baylibre.com, olof@lixom.net,
	linux-mtd@lists.infradead.org, ivan.djelic@parrot.com,
	computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes
Date: Thu, 24 Oct 2013 10:52:59 -0300	[thread overview]
Message-ID: <20131024135258.GC9958@localhost> (raw)
In-Reply-To: <1382619026-4182-1-git-send-email-pekon@ti.com>

Hi Pekon,

Just as suggestion, I think you should reconsider your 'upstream strategy'.

On Thu, Oct 24, 2013 at 06:20:16PM +0530, Pekon Gupta wrote:
[..]
> 
> Pekon Gupta (10):
>   ARM: OMAP2+: cleaned-up DT support of various ECC schemes
>   mtd: nand: omap: combine different flavours of 1-bit hamming ecc schemes
>   mtd: nand: omap: cleanup: replace local references with generic framework names

IMHO, this patch about the dobule nand_scan_ident():
>   mtd: nand: omap: use DT specified bus-width only for scanning NAND device

is a fix unrelated to this series and can be pushed independently.
Maybe you can try to send it as a one-patch fix?

>   mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe
>   mtd: nand: omap: clean-up ecc layout for BCH ecc schemes
>   mtd: nand: omap: use drivers/mtd/nand/nand_bch.c wrapper for BCH ECC instead of lib/bch.c
>   ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt

And also this patch:
>   mtd: nand: omap: updated devm_xx for all resource allocation and free calls

doesn't seem to belong to this series.

I think tou could send those two independently and ask Brian to merge them earlier
if appropriate.

But again, this is just a suggestion.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Pekon Gupta <pekon@ti.com>
Cc: mark.rutland@arm.com, olof@lixom.net,
	computersforpeace@gmail.com, dedekind1@gmail.com,
	devicetree@vger.kernel.org, Pawel.Moll@arm.com, arnd@arndb.de,
	swarren@wwwdotorg.org, tony@atomide.com, jp.francois@cynove.com,
	ijc+devicetree@hellion.org.uk, avinashphilipk@gmail.com,
	balbi@ti.com, robherring2@gmail.com, bcousson@baylibre.com,
	linux-mtd@lists.infradead.org, ivan.djelic@parrot.com,
	linux-omap@vger.kernel.org, dwmw2@infradead.org
Subject: Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes
Date: Thu, 24 Oct 2013 10:52:59 -0300	[thread overview]
Message-ID: <20131024135258.GC9958@localhost> (raw)
In-Reply-To: <1382619026-4182-1-git-send-email-pekon@ti.com>

Hi Pekon,

Just as suggestion, I think you should reconsider your 'upstream strategy'.

On Thu, Oct 24, 2013 at 06:20:16PM +0530, Pekon Gupta wrote:
[..]
> 
> Pekon Gupta (10):
>   ARM: OMAP2+: cleaned-up DT support of various ECC schemes
>   mtd: nand: omap: combine different flavours of 1-bit hamming ecc schemes
>   mtd: nand: omap: cleanup: replace local references with generic framework names

IMHO, this patch about the dobule nand_scan_ident():
>   mtd: nand: omap: use DT specified bus-width only for scanning NAND device

is a fix unrelated to this series and can be pushed independently.
Maybe you can try to send it as a one-patch fix?

>   mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe
>   mtd: nand: omap: clean-up ecc layout for BCH ecc schemes
>   mtd: nand: omap: use drivers/mtd/nand/nand_bch.c wrapper for BCH ECC instead of lib/bch.c
>   ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt

And also this patch:
>   mtd: nand: omap: updated devm_xx for all resource allocation and free calls

doesn't seem to belong to this series.

I think tou could send those two independently and ask Brian to merge them earlier
if appropriate.

But again, this is just a suggestion.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-10-24 13:53 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 12:50 [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes Pekon Gupta
2013-10-24 12:50 ` Pekon Gupta
2013-10-24 12:50 ` [PATCH v11 01/10] ARM: OMAP2+: cleaned-up DT support of various " Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 12:50 ` [PATCH v11 02/10] mtd: nand: omap: combine different flavours of 1-bit hamming ecc schemes Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 12:50 ` [PATCH v11 03/10] mtd: nand: omap: cleanup: replace local references with generic framework names Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 12:50 ` [PATCH v11 04/10] mtd: nand: omap: use DT specified bus-width only for scanning NAND device Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 21:27   ` Ezequiel Garcia
2013-10-24 21:27     ` Ezequiel Garcia
2013-10-24 22:43     ` Brian Norris
2013-10-24 22:43       ` Brian Norris
2013-10-24 22:49       ` Ezequiel Garcia
2013-10-24 22:49         ` Ezequiel Garcia
2013-10-24 12:50 ` [PATCH v11 05/10] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 12:50 ` [PATCH v11 06/10] mtd: nand: omap: clean-up ecc layout for BCH ecc schemes Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 12:50 ` [PATCH v11 07/10] mtd: nand: omap: use drivers/mtd/nand/nand_bch.c wrapper for BCH ECC instead of lib/bch.c Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 12:50 ` [PATCH v11 08/10] ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 12:50 ` [PATCH v11 09/10] mtd: nand: omap: updated devm_xx for all resource allocation and free calls Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 12:50 ` [PATCH v11 10/10] mtd: nand: omap: remove selection of BCH ecc-scheme via KConfig Pekon Gupta
2013-10-24 12:50   ` Pekon Gupta
2013-10-24 13:52 ` Ezequiel Garcia [this message]
2013-10-24 13:52   ` [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes Ezequiel Garcia
2013-10-30  3:59   ` Brian Norris
2013-10-30  3:59     ` Brian Norris
2013-10-30  9:16     ` Ezequiel Garcia
2013-10-30  9:16       ` Ezequiel Garcia
2013-10-30 21:30     ` Gupta, Pekon
2013-10-30 21:30       ` Gupta, Pekon
2013-10-31 21:23     ` Tony Lindgren
2013-10-31 21:23       ` Tony Lindgren
2013-11-01 20:10       ` Gupta, Pekon
2013-11-01 20:10         ` Gupta, Pekon
2013-10-25 10:56 ` Ezequiel Garcia
2013-10-25 10:56   ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131024135258.GC9958@localhost \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=Pawel.Moll@arm.com \
    --cc=arnd@arndb.de \
    --cc=avinashphilipk@gmail.com \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=ivan.djelic@parrot.com \
    --cc=jp.francois@cynove.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=olof@lixom.net \
    --cc=pekon@ti.com \
    --cc=robherring2@gmail.com \
    --cc=swarren@wwwdotorg.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.