From: Stephen Boyd <sboyd@codeaurora.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/6] edac: Document Krait L1/L2 EDAC driver binding
Date: Mon, 28 Oct 2013 22:06:45 -0700 [thread overview]
Message-ID: <20131029050645.GC21983@codeaurora.org> (raw)
In-Reply-To: <20131029013454.GJ4763@kartoffel>
On 10/28, Mark Rutland wrote:
> On Tue, Oct 29, 2013 at 12:31:28AM +0000, Stephen Boyd wrote:
> > +
> > +Optional properties:
> > +- interrupt-names: Should contain the interrupt names "l1_irq" and
> > + "l2_irq"
>
> As with my comment on the parsing code, I'd prefer that if interrupt-names was
> present it defined the order of interrupts. Otherwise it's redundant and of no
> value.
>
> Otherwise, the binding looks fine to me:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
How about I just drop the interrupt-names property? It isn't
adding much and is a holdover from the vendor kernel.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] edac: Document Krait L1/L2 EDAC driver binding
Date: Mon, 28 Oct 2013 22:06:45 -0700 [thread overview]
Message-ID: <20131029050645.GC21983@codeaurora.org> (raw)
In-Reply-To: <20131029013454.GJ4763@kartoffel>
On 10/28, Mark Rutland wrote:
> On Tue, Oct 29, 2013 at 12:31:28AM +0000, Stephen Boyd wrote:
> > +
> > +Optional properties:
> > +- interrupt-names: Should contain the interrupt names "l1_irq" and
> > + "l2_irq"
>
> As with my comment on the parsing code, I'd prefer that if interrupt-names was
> present it defined the order of interrupts. Otherwise it's redundant and of no
> value.
>
> Otherwise, the binding looks fine to me:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
How about I just drop the interrupt-names property? It isn't
adding much and is a holdover from the vendor kernel.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-10-29 5:06 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 0:31 [PATCH 0/6] Krait L1/L2 EDAC driver Stephen Boyd
2013-10-29 0:31 ` Stephen Boyd
2013-10-29 0:31 ` [PATCH 1/6] edac: Don't try to cancel workqueue when it's never setup Stephen Boyd
2013-10-29 0:31 ` Stephen Boyd
2013-10-29 20:48 ` Borislav Petkov
2013-10-29 20:48 ` Borislav Petkov
2013-10-29 20:51 ` Stephen Boyd
2013-10-29 20:51 ` Stephen Boyd
2013-10-29 0:31 ` [PATCH 2/6] genirq: export percpu irq functions for module usage Stephen Boyd
2013-10-29 0:31 ` Stephen Boyd
2013-10-29 12:54 ` Thomas Gleixner
2013-10-29 12:54 ` Thomas Gleixner
2013-10-29 0:31 ` [PATCH 3/6] ARM: Add Krait L2 accessor functions Stephen Boyd
2013-10-29 0:31 ` Stephen Boyd
2013-10-29 1:19 ` Mark Rutland
2013-10-29 1:19 ` Mark Rutland
2013-10-29 1:21 ` Stephen Boyd
2013-10-29 1:21 ` Stephen Boyd
2013-10-29 1:32 ` Mark Rutland
2013-10-29 1:32 ` Mark Rutland
2013-10-29 5:05 ` Stephen Boyd
2013-10-29 5:05 ` Stephen Boyd
2013-10-29 0:31 ` [PATCH 4/6] edac: Document Krait L1/L2 EDAC driver binding Stephen Boyd
2013-10-29 0:31 ` Stephen Boyd
2013-10-29 0:31 ` Stephen Boyd
2013-10-29 1:34 ` Mark Rutland
2013-10-29 1:34 ` Mark Rutland
2013-10-29 5:06 ` Stephen Boyd [this message]
2013-10-29 5:06 ` Stephen Boyd
2013-10-30 0:34 ` Mark Rutland
2013-10-30 0:34 ` Mark Rutland
[not found] ` <1383006690-6754-5-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-10-29 8:21 ` Kumar Gala
2013-10-29 8:21 ` Kumar Gala
2013-10-29 8:21 ` Kumar Gala
2013-10-29 18:00 ` Stephen Boyd
2013-10-29 18:00 ` Stephen Boyd
2013-10-29 20:22 ` Olof Johansson
2013-10-29 20:22 ` Olof Johansson
2013-10-30 0:07 ` Stephen Boyd
2013-10-30 0:07 ` Stephen Boyd
2013-10-30 0:38 ` Mark Rutland
2013-10-30 0:38 ` Mark Rutland
2013-10-30 7:19 ` Kumar Gala
2013-10-30 7:19 ` Kumar Gala
2013-10-29 0:31 ` [PATCH 5/6] edac: Add support for Krait CPU cache error detection Stephen Boyd
2013-10-29 0:31 ` Stephen Boyd
2013-10-29 1:28 ` Mark Rutland
2013-10-29 1:28 ` Mark Rutland
2013-10-29 0:31 ` [PATCH 6/6] ARM: dts: msm: Add Krait edac node Stephen Boyd
2013-10-29 0:31 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029050645.GC21983@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.