All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/sysfs: Do not drop device reference twice
Date: Wed, 30 Oct 2013 11:06:41 -0700	[thread overview]
Message-ID: <20131030180640.GA13183@bwidawsk.net> (raw)
In-Reply-To: <1383130745-32165-1-git-send-email-treding@nvidia.com>

On Wed, Oct 30, 2013 at 11:59:05AM +0100, Thierry Reding wrote:
> device_unregister() already drops its reference to the struct device, so
> explicitly calling put_device() before device_unregister() can cause the
> device to have been freed before it can be unregistered.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Thanks for fixing this. It was driving me nuts.
Tested-by: Ben Widawsky <ben@bwidawsk.net>

[snip]
-- 
Ben Widawsky, Intel Open Source Technology Center

WARNING: multiple messages have this Message-ID (diff)
From: Ben Widawsky <ben@bwidawsk.net>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/sysfs: Do not drop device reference twice
Date: Wed, 30 Oct 2013 11:06:41 -0700	[thread overview]
Message-ID: <20131030180640.GA13183@bwidawsk.net> (raw)
In-Reply-To: <1383130745-32165-1-git-send-email-treding@nvidia.com>

On Wed, Oct 30, 2013 at 11:59:05AM +0100, Thierry Reding wrote:
> device_unregister() already drops its reference to the struct device, so
> explicitly calling put_device() before device_unregister() can cause the
> device to have been freed before it can be unregistered.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Thanks for fixing this. It was driving me nuts.
Tested-by: Ben Widawsky <ben@bwidawsk.net>

[snip]
-- 
Ben Widawsky, Intel Open Source Technology Center

  parent reply	other threads:[~2013-10-30 18:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 10:59 [PATCH] drm/sysfs: Do not drop device reference twice Thierry Reding
2013-10-30 16:05 ` Paulo Zanoni
2013-10-30 16:05   ` Paulo Zanoni
2013-10-30 21:18   ` Thierry Reding
2013-10-30 21:18     ` Thierry Reding
2013-10-30 18:06 ` Ben Widawsky [this message]
2013-10-30 18:06   ` Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131030180640.GA13183@bwidawsk.net \
    --to=ben@bwidawsk.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.