From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Tim Kryger <tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Christian Daudt <bcm-xK7y4jjYLqYh9ZMKESR00Q@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode
Date: Fri, 1 Nov 2013 14:08:35 +0100 [thread overview]
Message-ID: <20131101130835.GC6734@katana> (raw)
In-Reply-To: <1381960909-1735-3-git-send-email-tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote:
> Add support for I2C high-speed mode (3.4 MHz).
>
> Signed-off-by: Tim Kryger <tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Reviewed-by: Matt Porter <matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Reviewed-by: Markus Mayer <markus.mayer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Mostly good as well:
> +enum hs_bus_speed_index {
> + BCM_SPD_3P4MHZ = 0,
> +};
I just realized that you should update both patches to add the supported
bus speeds to the binding documentation.
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode
Date: Fri, 1 Nov 2013 14:08:35 +0100 [thread overview]
Message-ID: <20131101130835.GC6734@katana> (raw)
In-Reply-To: <1381960909-1735-3-git-send-email-tim.kryger@linaro.org>
On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote:
> Add support for I2C high-speed mode (3.4 MHz).
>
> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
Mostly good as well:
> +enum hs_bus_speed_index {
> + BCM_SPD_3P4MHZ = 0,
> +};
I just realized that you should update both patches to add the supported
bus speeds to the binding documentation.
Thanks,
Wolfram
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131101/4fa35ef6/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Tim Kryger <tim.kryger@linaro.org>
Cc: Christian Daudt <bcm@fixthebug.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode
Date: Fri, 1 Nov 2013 14:08:35 +0100 [thread overview]
Message-ID: <20131101130835.GC6734@katana> (raw)
In-Reply-To: <1381960909-1735-3-git-send-email-tim.kryger@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote:
> Add support for I2C high-speed mode (3.4 MHz).
>
> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
Mostly good as well:
> +enum hs_bus_speed_index {
> + BCM_SPD_3P4MHZ = 0,
> +};
I just realized that you should update both patches to add the supported
bus speeds to the binding documentation.
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-01 13:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 22:01 [RESEND PATCH 0/4] Add-Broadcom-Kona-I2C-Support Tim Kryger
2013-10-16 22:01 ` Tim Kryger
2013-10-16 22:01 ` [RESEND PATCH 1/4] i2c: i2c-bcm-kona: Introduce Broadcom I2C Driver Tim Kryger
2013-10-16 22:01 ` Tim Kryger
2013-11-01 12:49 ` Wolfram Sang
2013-11-01 12:49 ` Wolfram Sang
2013-11-02 0:32 ` Tim Kryger
2013-11-02 0:32 ` Tim Kryger
2013-11-02 0:32 ` Tim Kryger
2013-10-16 22:01 ` [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode Tim Kryger
2013-10-16 22:01 ` Tim Kryger
[not found] ` <1381960909-1735-3-git-send-email-tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-11-01 13:08 ` Wolfram Sang [this message]
2013-11-01 13:08 ` Wolfram Sang
2013-11-01 13:08 ` Wolfram Sang
2013-11-07 19:57 ` Tim Kryger
2013-11-07 19:57 ` Tim Kryger
2013-11-07 20:13 ` Wolfram Sang
2013-11-07 20:13 ` Wolfram Sang
2013-11-07 20:16 ` Tim Kryger
2013-11-07 20:16 ` Tim Kryger
2013-10-16 22:01 ` [RESEND PATCH 3/4] ARM: dts: bcm281xx: Add i2c busses Tim Kryger
2013-10-16 22:01 ` Tim Kryger
2013-10-17 4:32 ` Christian Daudt
2013-10-17 4:32 ` Christian Daudt
2013-10-17 12:14 ` Matt Porter
2013-10-17 12:14 ` Matt Porter
[not found] ` <1381960909-1735-1-git-send-email-tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-10-16 22:01 ` [RESEND PATCH 4/4] ARM: dts: bcm28155-ap: Enable all the " Tim Kryger
2013-10-16 22:01 ` Tim Kryger
2013-10-16 22:01 ` Tim Kryger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101130835.GC6734@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=bcm-xK7y4jjYLqYh9ZMKESR00Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.