From: Wolfram Sang <wsa@the-dreams.de>
To: Tim Kryger <tim.kryger@linaro.org>
Cc: Christian Daudt <bcm@fixthebug.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
Device Tree List <devicetree@vger.kernel.org>,
linux-doc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-i2c@vger.kernel.org,
ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode
Date: Thu, 7 Nov 2013 21:13:32 +0100 [thread overview]
Message-ID: <20131107201332.GA7119@katana> (raw)
In-Reply-To: <CAAYSxhrrkSvOJpYPz7txVsot1you3fFzkXJ6fqaS4OgRM0Z2gA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
> While the bus speed property is really a configuration parameter (and
> not a true description of of the hardware) it seems improper to put
> driver specific details into the binding document.
OK. Then please change the error message for unsupported bus speeds to
contain the supported ones. I don't think it is good practice to force
users to look into the sourcecode to find this information.
Regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode
Date: Thu, 7 Nov 2013 21:13:32 +0100 [thread overview]
Message-ID: <20131107201332.GA7119@katana> (raw)
In-Reply-To: <CAAYSxhrrkSvOJpYPz7txVsot1you3fFzkXJ6fqaS4OgRM0Z2gA@mail.gmail.com>
> While the bus speed property is really a configuration parameter (and
> not a true description of of the hardware) it seems improper to put
> driver specific details into the binding document.
OK. Then please change the error message for unsupported bus speeds to
contain the supported ones. I don't think it is good practice to force
users to look into the sourcecode to find this information.
Regards,
Wolfram
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131107/276be82b/attachment.sig>
next prev parent reply other threads:[~2013-11-07 20:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 22:01 [RESEND PATCH 0/4] Add-Broadcom-Kona-I2C-Support Tim Kryger
2013-10-16 22:01 ` Tim Kryger
2013-10-16 22:01 ` [RESEND PATCH 1/4] i2c: i2c-bcm-kona: Introduce Broadcom I2C Driver Tim Kryger
2013-10-16 22:01 ` Tim Kryger
2013-11-01 12:49 ` Wolfram Sang
2013-11-01 12:49 ` Wolfram Sang
2013-11-02 0:32 ` Tim Kryger
2013-11-02 0:32 ` Tim Kryger
2013-11-02 0:32 ` Tim Kryger
2013-10-16 22:01 ` [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode Tim Kryger
2013-10-16 22:01 ` Tim Kryger
[not found] ` <1381960909-1735-3-git-send-email-tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-11-01 13:08 ` Wolfram Sang
2013-11-01 13:08 ` Wolfram Sang
2013-11-01 13:08 ` Wolfram Sang
2013-11-07 19:57 ` Tim Kryger
2013-11-07 19:57 ` Tim Kryger
2013-11-07 20:13 ` Wolfram Sang [this message]
2013-11-07 20:13 ` Wolfram Sang
2013-11-07 20:16 ` Tim Kryger
2013-11-07 20:16 ` Tim Kryger
2013-10-16 22:01 ` [RESEND PATCH 3/4] ARM: dts: bcm281xx: Add i2c busses Tim Kryger
2013-10-16 22:01 ` Tim Kryger
2013-10-17 4:32 ` Christian Daudt
2013-10-17 4:32 ` Christian Daudt
2013-10-17 12:14 ` Matt Porter
2013-10-17 12:14 ` Matt Porter
[not found] ` <1381960909-1735-1-git-send-email-tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-10-16 22:01 ` [RESEND PATCH 4/4] ARM: dts: bcm28155-ap: Enable all the " Tim Kryger
2013-10-16 22:01 ` Tim Kryger
2013-10-16 22:01 ` Tim Kryger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107201332.GA7119@katana \
--to=wsa@the-dreams.de \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.