From: Dan Carpenter <dan.carpenter@oracle.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [ALSA] sb16 - info leak in snd_sb_csp_ioctl()
Date: Thu, 7 Nov 2013 12:09:47 +0300 [thread overview]
Message-ID: <20131107090947.GS26669@mwanda> (raw)
In-Reply-To: <s5hli10vbqv.wl%tiwai@suse.de>
On Thu, Nov 07, 2013 at 09:48:08AM +0100, Takashi Iwai wrote:
> At Thu, 7 Nov 2013 11:09:54 +0300,
> Dan Carpenter wrote:
> >
> > There is a 2 byte hole after "info.func_nr" so we could leak unitialized
> > stack information to userspace.
> >
> > Fixes: 1da177e4c3f4 ('Linux-2.6.12-rc2')
>
> Does this help at all? It means that the bug has been there even
> before moving to git. I think it's better to be removed for avoid
> confusion.
I think if you are back porting it then you know it goes back all the
way. That seems useful.
The Fixes tag is still new so it's not totally clear what the rules are.
I don't have strong feelings about this either way.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [ALSA] sb16 - info leak in snd_sb_csp_ioctl()
Date: Thu, 07 Nov 2013 09:09:47 +0000 [thread overview]
Message-ID: <20131107090947.GS26669@mwanda> (raw)
In-Reply-To: <s5hli10vbqv.wl%tiwai@suse.de>
On Thu, Nov 07, 2013 at 09:48:08AM +0100, Takashi Iwai wrote:
> At Thu, 7 Nov 2013 11:09:54 +0300,
> Dan Carpenter wrote:
> >
> > There is a 2 byte hole after "info.func_nr" so we could leak unitialized
> > stack information to userspace.
> >
> > Fixes: 1da177e4c3f4 ('Linux-2.6.12-rc2')
>
> Does this help at all? It means that the bug has been there even
> before moving to git. I think it's better to be removed for avoid
> confusion.
I think if you are back porting it then you know it goes back all the
way. That seems useful.
The Fixes tag is still new so it's not totally clear what the rules are.
I don't have strong feelings about this either way.
regards,
dan carpenter
next prev parent reply other threads:[~2013-11-07 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 8:09 [patch] [ALSA] sb16 - info leak in snd_sb_csp_ioctl() Dan Carpenter
2013-11-07 8:09 ` Dan Carpenter
2013-11-07 8:48 ` Takashi Iwai
2013-11-07 8:48 ` Takashi Iwai
2013-11-07 9:09 ` Dan Carpenter [this message]
2013-11-07 9:09 ` Dan Carpenter
2013-11-07 9:17 ` Takashi Iwai
2013-11-07 9:17 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107090947.GS26669@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.