All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [ALSA] sb16 - info leak in snd_sb_csp_ioctl()
Date: Thu, 07 Nov 2013 09:48:08 +0100	[thread overview]
Message-ID: <s5hli10vbqv.wl%tiwai@suse.de> (raw)
In-Reply-To: <20131107080954.GS21844@elgon.mountain>

At Thu, 7 Nov 2013 11:09:54 +0300,
Dan Carpenter wrote:
> 
> There is a 2 byte hole after "info.func_nr" so we could leak unitialized
> stack information to userspace.
> 
> Fixes: 1da177e4c3f4 ('Linux-2.6.12-rc2')

Does this help at all?  It means that the bug has been there even
before moving to git.  I think it's better to be removed for avoid
confusion.


thanks,

Takashi

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/sound/isa/sb/sb16_csp.c b/sound/isa/sb/sb16_csp.c
> index c1aa21e..48da227 100644
> --- a/sound/isa/sb/sb16_csp.c
> +++ b/sound/isa/sb/sb16_csp.c
> @@ -208,6 +208,7 @@ static int snd_sb_csp_ioctl(struct snd_hwdep * hw, struct file *file, unsigned i
>  	switch (cmd) {
>  		/* get information */
>  	case SNDRV_SB_CSP_IOCTL_INFO:
> +		memset(&info, 0, sizeof(info));
>  		*info.codec_name = *p->codec_name;
>  		info.func_nr = p->func_nr;
>  		info.acc_format = p->acc_format;
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [ALSA] sb16 - info leak in snd_sb_csp_ioctl()
Date: Thu, 07 Nov 2013 08:48:08 +0000	[thread overview]
Message-ID: <s5hli10vbqv.wl%tiwai@suse.de> (raw)
In-Reply-To: <20131107080954.GS21844@elgon.mountain>

At Thu, 7 Nov 2013 11:09:54 +0300,
Dan Carpenter wrote:
> 
> There is a 2 byte hole after "info.func_nr" so we could leak unitialized
> stack information to userspace.
> 
> Fixes: 1da177e4c3f4 ('Linux-2.6.12-rc2')

Does this help at all?  It means that the bug has been there even
before moving to git.  I think it's better to be removed for avoid
confusion.


thanks,

Takashi

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/sound/isa/sb/sb16_csp.c b/sound/isa/sb/sb16_csp.c
> index c1aa21e..48da227 100644
> --- a/sound/isa/sb/sb16_csp.c
> +++ b/sound/isa/sb/sb16_csp.c
> @@ -208,6 +208,7 @@ static int snd_sb_csp_ioctl(struct snd_hwdep * hw, struct file *file, unsigned i
>  	switch (cmd) {
>  		/* get information */
>  	case SNDRV_SB_CSP_IOCTL_INFO:
> +		memset(&info, 0, sizeof(info));
>  		*info.codec_name = *p->codec_name;
>  		info.func_nr = p->func_nr;
>  		info.acc_format = p->acc_format;
> 

  reply	other threads:[~2013-11-07  8:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07  8:09 [patch] [ALSA] sb16 - info leak in snd_sb_csp_ioctl() Dan Carpenter
2013-11-07  8:09 ` Dan Carpenter
2013-11-07  8:48 ` Takashi Iwai [this message]
2013-11-07  8:48   ` Takashi Iwai
2013-11-07  9:09   ` Dan Carpenter
2013-11-07  9:09     ` Dan Carpenter
2013-11-07  9:17     ` Takashi Iwai
2013-11-07  9:17       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hli10vbqv.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.