From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [Xen-devel] [PATCH 1/2] swiotlb-xen: add missing xen_dma_map_page call
Date: Tue, 12 Nov 2013 09:45:00 -0500 [thread overview]
Message-ID: <20131112144500.GB9435@phenom.dumpdata.com> (raw)
In-Reply-To: <1384265520-6833-1-git-send-email-stefano.stabellini@eu.citrix.com>
On Tue, Nov 12, 2013 at 02:11:59PM +0000, Stefano Stabellini wrote:
> swiotlb-xen is missing a xen_dma_map_page call in
> xen_swiotlb_map_sg_attrs, in the slow path.
s/slow/bounce buffer/ I believe?
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
> drivers/xen/swiotlb-xen.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index a224bc7..1eac073 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -555,6 +555,11 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl,
> sg_dma_len(sgl) = 0;
> return 0;
> }
> + xen_dma_map_page(hwdev, pfn_to_page(map >> PAGE_SHIFT),
> + map & ~PAGE_MASK,
> + sg->length,
> + dir,
> + attrs);
> sg->dma_address = xen_phys_to_bus(map);
> } else {
> /* we are not interested in the dma_addr returned by
> --
> 1.7.2.5
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel at lists.xen.org
> http://lists.xen.org/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, konrad@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Xen-devel] [PATCH 1/2] swiotlb-xen: add missing xen_dma_map_page call
Date: Tue, 12 Nov 2013 09:45:00 -0500 [thread overview]
Message-ID: <20131112144500.GB9435@phenom.dumpdata.com> (raw)
In-Reply-To: <1384265520-6833-1-git-send-email-stefano.stabellini@eu.citrix.com>
On Tue, Nov 12, 2013 at 02:11:59PM +0000, Stefano Stabellini wrote:
> swiotlb-xen is missing a xen_dma_map_page call in
> xen_swiotlb_map_sg_attrs, in the slow path.
s/slow/bounce buffer/ I believe?
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
> drivers/xen/swiotlb-xen.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index a224bc7..1eac073 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -555,6 +555,11 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl,
> sg_dma_len(sgl) = 0;
> return 0;
> }
> + xen_dma_map_page(hwdev, pfn_to_page(map >> PAGE_SHIFT),
> + map & ~PAGE_MASK,
> + sg->length,
> + dir,
> + attrs);
> sg->dma_address = xen_phys_to_bus(map);
> } else {
> /* we are not interested in the dma_addr returned by
> --
> 1.7.2.5
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: konrad@kernel.org, xen-devel@lists.xensource.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Xen-devel] [PATCH 1/2] swiotlb-xen: add missing xen_dma_map_page call
Date: Tue, 12 Nov 2013 09:45:00 -0500 [thread overview]
Message-ID: <20131112144500.GB9435@phenom.dumpdata.com> (raw)
In-Reply-To: <1384265520-6833-1-git-send-email-stefano.stabellini@eu.citrix.com>
On Tue, Nov 12, 2013 at 02:11:59PM +0000, Stefano Stabellini wrote:
> swiotlb-xen is missing a xen_dma_map_page call in
> xen_swiotlb_map_sg_attrs, in the slow path.
s/slow/bounce buffer/ I believe?
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
> drivers/xen/swiotlb-xen.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index a224bc7..1eac073 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -555,6 +555,11 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl,
> sg_dma_len(sgl) = 0;
> return 0;
> }
> + xen_dma_map_page(hwdev, pfn_to_page(map >> PAGE_SHIFT),
> + map & ~PAGE_MASK,
> + sg->length,
> + dir,
> + attrs);
> sg->dma_address = xen_phys_to_bus(map);
> } else {
> /* we are not interested in the dma_addr returned by
> --
> 1.7.2.5
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-11-12 14:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 14:11 [PATCH 0/2] swiotlb-xen fixes Stefano Stabellini
2013-11-12 14:11 ` Stefano Stabellini
2013-11-12 14:11 ` Stefano Stabellini
2013-11-12 14:11 ` [PATCH 1/2] swiotlb-xen: add missing xen_dma_map_page call Stefano Stabellini
2013-11-12 14:11 ` Stefano Stabellini
2013-11-12 14:11 ` Stefano Stabellini
2013-11-12 14:45 ` Konrad Rzeszutek Wilk [this message]
2013-11-12 14:45 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-11-12 14:45 ` Konrad Rzeszutek Wilk
2013-11-12 17:03 ` Stefano Stabellini
2013-11-12 17:03 ` Stefano Stabellini
2013-11-12 17:03 ` Stefano Stabellini
2013-11-12 14:12 ` [PATCH 2/2] swiotlb-xen: xen_swiotlb_map_page: do not error out if dma_capable fails Stefano Stabellini
2013-11-12 14:12 ` Stefano Stabellini
2013-11-12 14:12 ` Stefano Stabellini
2013-11-12 14:48 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-11-12 14:48 ` Konrad Rzeszutek Wilk
2013-11-12 14:48 ` Konrad Rzeszutek Wilk
2013-11-12 15:05 ` Russell King - ARM Linux
2013-11-12 15:05 ` Russell King - ARM Linux
2013-11-12 17:27 ` Stefano Stabellini
2013-11-12 17:27 ` Stefano Stabellini
2013-11-12 17:27 ` Stefano Stabellini
2013-11-12 20:22 ` Rob Herring
2013-11-12 20:22 ` Rob Herring
2013-11-13 11:35 ` Stefano Stabellini
2013-11-13 11:35 ` Stefano Stabellini
2013-11-13 11:35 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112144500.GB9435@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.