From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 7/7] ARM: shmobile: armadillo-reference: Use low level IRQ for ST1231
Date: Thu, 21 Nov 2013 05:02:07 +0000 [thread overview]
Message-ID: <20131121050207.GW31130@verge.net.au> (raw)
In-Reply-To: <1384865989-12875-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Tue, Nov 19, 2013 at 01:59:49PM +0100, Laurent Pinchart wrote:
> The device is configured to generate an active-low interrupt signal that
> needs to be acknowledged by the host. Configure the IRQ to trigger on
> low level.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Changes since v1:
>
> - Fixed typo (IRQ_TYPE_LOW_LEVEL -> IRQ_TYPE_LEVEL_LOW)
Thanks, I will queue this up.
Assuming all goes will I plan to push this and other updates
today or tomorrow.
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index aef425f..7b80f19 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -95,7 +95,7 @@
> compatible = "sitronix,st1232";
> reg = <0x55>;
> interrupt-parent = <&irqpin1>;
> - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */
> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> pinctrl-0 = <&st1232_pins>;
> pinctrl-names = "default";
> gpios = <&pfc 166 GPIO_ACTIVE_LOW>;
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] ARM: shmobile: armadillo-reference: Use low level IRQ for ST1231
Date: Thu, 21 Nov 2013 14:02:07 +0900 [thread overview]
Message-ID: <20131121050207.GW31130@verge.net.au> (raw)
In-Reply-To: <1384865989-12875-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Tue, Nov 19, 2013 at 01:59:49PM +0100, Laurent Pinchart wrote:
> The device is configured to generate an active-low interrupt signal that
> needs to be acknowledged by the host. Configure the IRQ to trigger on
> low level.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Changes since v1:
>
> - Fixed typo (IRQ_TYPE_LOW_LEVEL -> IRQ_TYPE_LEVEL_LOW)
Thanks, I will queue this up.
Assuming all goes will I plan to push this and other updates
today or tomorrow.
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index aef425f..7b80f19 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -95,7 +95,7 @@
> compatible = "sitronix,st1232";
> reg = <0x55>;
> interrupt-parent = <&irqpin1>;
> - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */
> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> pinctrl-0 = <&st1232_pins>;
> pinctrl-names = "default";
> gpios = <&pfc 166 GPIO_ACTIVE_LOW>;
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v2 7/7] ARM: shmobile: armadillo-reference: Use low level IRQ for ST1231
Date: Thu, 21 Nov 2013 14:02:07 +0900 [thread overview]
Message-ID: <20131121050207.GW31130@verge.net.au> (raw)
In-Reply-To: <1384865989-12875-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Tue, Nov 19, 2013 at 01:59:49PM +0100, Laurent Pinchart wrote:
> The device is configured to generate an active-low interrupt signal that
> needs to be acknowledged by the host. Configure the IRQ to trigger on
> low level.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Changes since v1:
>
> - Fixed typo (IRQ_TYPE_LOW_LEVEL -> IRQ_TYPE_LEVEL_LOW)
Thanks, I will queue this up.
Assuming all goes will I plan to push this and other updates
today or tomorrow.
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index aef425f..7b80f19 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -95,7 +95,7 @@
> compatible = "sitronix,st1232";
> reg = <0x55>;
> interrupt-parent = <&irqpin1>;
> - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */
> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> pinctrl-0 = <&st1232_pins>;
> pinctrl-names = "default";
> gpios = <&pfc 166 GPIO_ACTIVE_LOW>;
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-11-21 5:02 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 12:23 [PATCH 0/7] ARM: shmobile: Use interrupt macros in DT files Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` [PATCH 1/7] ARM: shmobile: Use #include in device tree sources Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` [PATCH 2/7] ARM: shmobile: Use interrupt macros in SoC DT files Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-19 1:38 ` Simon Horman
2013-11-19 1:38 ` Simon Horman
2013-11-19 1:38 ` Simon Horman
2013-11-19 1:50 ` Laurent Pinchart
2013-11-19 1:50 ` Laurent Pinchart
2013-11-19 1:50 ` Laurent Pinchart
2013-11-19 2:36 ` Simon Horman
2013-11-19 2:36 ` Simon Horman
2013-11-19 2:36 ` Simon Horman
2013-11-19 2:18 ` [PATCH v2 " Laurent Pinchart
2013-11-19 2:18 ` Laurent Pinchart
2013-11-19 2:18 ` Laurent Pinchart
2013-11-19 2:40 ` Simon Horman
2013-11-19 2:40 ` Simon Horman
2013-11-19 2:40 ` Simon Horman
2013-11-09 12:23 ` [PATCH 3/7] ARM: shmobile: Use interrupt macros in board " Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` [PATCH 4/7] ARM: shmobile: marzen-reference: Use falling edge IRQ for LAN9221 Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` [PATCH 5/7] ARM: shmobile: bockw-reference: " Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` [PATCH 6/7] ARM: shmobile: kzm9g-reference: " Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` [PATCH 7/7] ARM: shmobile: armadillo-reference: Use low level IRQ for ST1231 Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-09 12:23 ` Laurent Pinchart
2013-11-19 1:42 ` Simon Horman
2013-11-19 1:42 ` Simon Horman
2013-11-19 1:42 ` Simon Horman
2013-11-19 2:56 ` Simon Horman
2013-11-19 2:56 ` Simon Horman
2013-11-19 2:56 ` Simon Horman
2013-11-19 12:52 ` Laurent Pinchart
2013-11-19 12:52 ` Laurent Pinchart
2013-11-19 12:52 ` Laurent Pinchart
2013-11-19 12:59 ` [PATCH v2 " Laurent Pinchart
2013-11-19 12:59 ` Laurent Pinchart
2013-11-19 12:59 ` Laurent Pinchart
2013-11-21 5:02 ` Simon Horman [this message]
2013-11-21 5:02 ` Simon Horman
2013-11-21 5:02 ` Simon Horman
2013-11-18 8:42 ` [PATCH 0/7] ARM: shmobile: Use interrupt macros in DT files Simon Horman
2013-11-18 8:42 ` Simon Horman
2013-11-18 8:42 ` Simon Horman
2013-11-18 11:18 ` Laurent Pinchart
2013-11-18 11:18 ` Laurent Pinchart
2013-11-18 11:18 ` Laurent Pinchart
2013-11-19 1:35 ` Simon Horman
2013-11-19 1:35 ` Simon Horman
2013-11-19 1:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121050207.GW31130@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.