From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: f2fs: introduce f2fs_issue_discard() to clean up
Date: Wed, 27 Nov 2013 11:31:17 +0300 [thread overview]
Message-ID: <20131127083117.GT5443@mwanda> (raw)
In-Reply-To: <1385520381.2417.17.camel@kjgkr>
On Wed, Nov 27, 2013 at 11:46:21AM +0900, Jaegeuk Kim wrote:
> Hi Dan,
>
> Thank you for the report.
>
> How about this?
> Thanks,
You've just disguised the bug instead of fixing it. Later versions of
this static checker will complain about the new code as well. We're
unlikely to support 18TB with f2fs so let's just leave the code as is
with the original warning.
regards,
dan carpenter
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
next prev parent reply other threads:[~2013-11-27 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 14:53 f2fs: introduce f2fs_issue_discard() to clean up Dan Carpenter
2013-11-27 2:46 ` Jaegeuk Kim
2013-11-27 8:31 ` Dan Carpenter [this message]
2013-11-27 9:04 ` Jaegeuk Kim
2013-11-27 10:41 ` Dan Carpenter
2013-11-28 4:04 ` Jaegeuk Kim
2013-11-28 8:08 ` Dan Carpenter
2013-11-28 9:24 ` Jaegeuk Kim
2013-11-28 9:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127083117.GT5443@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jaegeuk.kim@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.