Re: f2fs: introduce f2fs_issue_discard() to clean up

[Dan Carpenter <dan.carpenter@oracle.com>]

On Thu, Nov 28, 2013 at 06:24:41PM +0900, Jaegeuk Kim wrote:
> 2013-11-28 (목), 11:08 +0300, Dan Carpenter:
> > On Thu, Nov 28, 2013 at 01:04:47PM +0900, Jaegeuk Kim wrote:
> > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> > > index b7ad1ec..5fa54c1 100644
> > > --- a/fs/f2fs/gc.c
> > > +++ b/fs/f2fs/gc.c
> > > @@ -664,8 +664,6 @@ static void do_garbage_collect(struct f2fs_sb_info
> > > *sbi, unsigned int segno,
> > >  
> > >  	/* read segment summary of victim */
> > >  	sum_page = get_sum_page(sbi, segno);
> > > -	if (IS_ERR(sum_page))
> > > -		return;
> > 
> > Didn't you want to check for NULL here?
> 
> It was needless, since get_sum_page() returns always valid page.

Oh yeah.  I wasn't looking carefully.

regards,
dan carpenter

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel