Re: f2fs: introduce f2fs_issue_discard() to clean up

[Dan Carpenter <dan.carpenter@oracle.com>]

On Wed, Nov 27, 2013 at 06:04:57PM +0900, Jaegeuk Kim wrote:
> Hi,
> 
> 2013-11-27 (수), 11:31 +0300, Dan Carpenter:
> > On Wed, Nov 27, 2013 at 11:46:21AM +0900, Jaegeuk Kim wrote:
> > > Hi Dan,
> > > 
> > > Thank you for the report.
> > > 
> > > How about this?
> > > Thanks,
> > 
> > You've just disguised the bug instead of fixing it.  Later versions of
> > this static checker will complain about the new code as well.  We're
> > unlikely to support 18TB with f2fs so let's just leave the code as is
> > with the original warning.
> 
> Oops. I was out of mind at that time.
> It should be done casting from block_t to sector_t explicitly, since it
> can be a problem after the volume size becomes over 2TB, 2^(32-3) * 4KB.
> Let me fix the potential problem as follows.
> Thanks,

Perfect.  There were some other related warnings as well:

fs/f2fs/segment.c:910 submit_write_page() warn: should 'blk_addr << ((sbi)->log_blocksize - 9)' be a 64 bit type?
fs/f2fs/checkpoint.c:429 get_valid_checkpoint() warn: should '1 << ()' be a 64 bit type?
fs/f2fs/data.c:408 f2fs_readpage() warn: should 'blk_addr << ((sbi)->log_blocksize - 9)' be a 64 bit type?
fs/f2fs/data.c:457 submit_read_page() warn: should 'blk_addr << ((sbi)->log_blocksize - 9)' be a 64 bit type?
fs/f2fs/data.c:525 get_data_block_ro() warn: should 'i << blkbits' be a 64 bit type?

And a couple other unrelated errors.  :)

fs/f2fs/gc.c:667 do_garbage_collect() warn: 'sum_page' isn't an ERR_PTR
fs/f2fs/f2fs.h:795 f2fs_put_page() warn: 'page' isn't an ERR_PTR

regards,
dan carpenter

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel