From: Lee Jones <lee.jones@linaro.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, linus.walleij@linaro.org,
broonie@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation
Date: Tue, 3 Dec 2013 10:03:34 +0000 [thread overview]
Message-ID: <20131203100334.GI11828@lee--X1> (raw)
In-Reply-To: <529D9CD1.3020208@metafoo.de>
On Tue, 03 Dec 2013, Lars-Peter Clausen wrote:
> On 12/03/2013 09:36 AM, Lee Jones wrote:
> >On Mon, 02 Dec 2013, Lars-Peter Clausen wrote:
> >
> >>On 12/02/2013 07:00 PM, Lee Jones wrote:
> >>>If booting with full DT support (i.e. DMA too, the last piece of the
> >>>puzzle), then we don't need to use the compatible request channel call
> >>>back. We also require slightly different flags to inform the core that
> >>>we are booting with DT.
> >>
> >>I don't think you need differentiate between DT and non-DT here.
> >>If the SND_DMAENGINE_PCM_FLAG_COMPAT is set and the
> >>SND_DMAENGINE_PCM_FLAG_NO_DT is not set it will first try to request the
> >>channels from the DT if that fails it will fallback to the compat path. So
> >>all this patch needs to do is remove the SND_DMAENGINE_PCM_FLAG_NO_DT, that
> >>should be it.
> >
> >I have no way of testing that, as we are currently 80% through
> >shutting down platform data altogether. In fact, I think there is only
> >ASoC to be converted. Most of this stuff is going to be ripped out
> >within the next couple of weeks in any case. It will happen as soon as
> >I can find an hour or two to work on it.
> >
> >For that reason I didn't want to disturb the current semantics. I've
> >already found that a bunch of he generic (oh, you can just use the
> >central) functions (for that) don't actually work for us for one
> >reason or another.
>
> All SND_DMAENGINE_PCM_FLAG_NO_DT does is to skip trying to request
> the channel from the dt. If of_node is NULL this step will be
> skipped anyway. So only setting SND_DMAENGINE_PCM_FLAG_NO_DT if we
> already know that the node is NULL is redundant.
I'll just have to trust you on this and resubmit with the other patch.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation
Date: Tue, 3 Dec 2013 10:03:34 +0000 [thread overview]
Message-ID: <20131203100334.GI11828@lee--X1> (raw)
In-Reply-To: <529D9CD1.3020208@metafoo.de>
On Tue, 03 Dec 2013, Lars-Peter Clausen wrote:
> On 12/03/2013 09:36 AM, Lee Jones wrote:
> >On Mon, 02 Dec 2013, Lars-Peter Clausen wrote:
> >
> >>On 12/02/2013 07:00 PM, Lee Jones wrote:
> >>>If booting with full DT support (i.e. DMA too, the last piece of the
> >>>puzzle), then we don't need to use the compatible request channel call
> >>>back. We also require slightly different flags to inform the core that
> >>>we are booting with DT.
> >>
> >>I don't think you need differentiate between DT and non-DT here.
> >>If the SND_DMAENGINE_PCM_FLAG_COMPAT is set and the
> >>SND_DMAENGINE_PCM_FLAG_NO_DT is not set it will first try to request the
> >>channels from the DT if that fails it will fallback to the compat path. So
> >>all this patch needs to do is remove the SND_DMAENGINE_PCM_FLAG_NO_DT, that
> >>should be it.
> >
> >I have no way of testing that, as we are currently 80% through
> >shutting down platform data altogether. In fact, I think there is only
> >ASoC to be converted. Most of this stuff is going to be ripped out
> >within the next couple of weeks in any case. It will happen as soon as
> >I can find an hour or two to work on it.
> >
> >For that reason I didn't want to disturb the current semantics. I've
> >already found that a bunch of he generic (oh, you can just use the
> >central) functions (for that) don't actually work for us for one
> >reason or another.
>
> All SND_DMAENGINE_PCM_FLAG_NO_DT does is to skip trying to request
> the channel from the dt. If of_node is NULL this step will be
> skipped anyway. So only setting SND_DMAENGINE_PCM_FLAG_NO_DT if we
> already know that the node is NULL is redundant.
I'll just have to trust you on this and resubmit with the other patch.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
broonie@kernel.org, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation
Date: Tue, 3 Dec 2013 10:03:34 +0000 [thread overview]
Message-ID: <20131203100334.GI11828@lee--X1> (raw)
In-Reply-To: <529D9CD1.3020208@metafoo.de>
On Tue, 03 Dec 2013, Lars-Peter Clausen wrote:
> On 12/03/2013 09:36 AM, Lee Jones wrote:
> >On Mon, 02 Dec 2013, Lars-Peter Clausen wrote:
> >
> >>On 12/02/2013 07:00 PM, Lee Jones wrote:
> >>>If booting with full DT support (i.e. DMA too, the last piece of the
> >>>puzzle), then we don't need to use the compatible request channel call
> >>>back. We also require slightly different flags to inform the core that
> >>>we are booting with DT.
> >>
> >>I don't think you need differentiate between DT and non-DT here.
> >>If the SND_DMAENGINE_PCM_FLAG_COMPAT is set and the
> >>SND_DMAENGINE_PCM_FLAG_NO_DT is not set it will first try to request the
> >>channels from the DT if that fails it will fallback to the compat path. So
> >>all this patch needs to do is remove the SND_DMAENGINE_PCM_FLAG_NO_DT, that
> >>should be it.
> >
> >I have no way of testing that, as we are currently 80% through
> >shutting down platform data altogether. In fact, I think there is only
> >ASoC to be converted. Most of this stuff is going to be ripped out
> >within the next couple of weeks in any case. It will happen as soon as
> >I can find an hour or two to work on it.
> >
> >For that reason I didn't want to disturb the current semantics. I've
> >already found that a bunch of he generic (oh, you can just use the
> >central) functions (for that) don't actually work for us for one
> >reason or another.
>
> All SND_DMAENGINE_PCM_FLAG_NO_DT does is to skip trying to request
> the channel from the dt. If of_node is NULL this step will be
> skipped anyway. So only setting SND_DMAENGINE_PCM_FLAG_NO_DT if we
> already know that the node is NULL is redundant.
I'll just have to trust you on this and resubmit with the other patch.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-12-03 10:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 18:00 [PATCH 1/3] ASoC: ux500_pcm: Stop pretending that we support varying address widths Lee Jones
2013-12-02 18:00 ` Lee Jones
2013-12-02 18:00 ` [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Lee Jones
2013-12-02 18:00 ` Lee Jones
2013-12-02 18:13 ` [alsa-devel] " Lars-Peter Clausen
2013-12-02 18:13 ` Lars-Peter Clausen
2013-12-03 8:36 ` Lee Jones
2013-12-03 8:36 ` Lee Jones
2013-12-03 8:56 ` Lars-Peter Clausen
2013-12-03 8:56 ` [alsa-devel] " Lars-Peter Clausen
2013-12-03 8:56 ` Lars-Peter Clausen
2013-12-03 10:03 ` Lee Jones [this message]
2013-12-03 10:03 ` Lee Jones
2013-12-03 10:03 ` Lee Jones
2013-12-02 18:00 ` [PATCH 3/3] ASoC: ux500: Dynamically fill DAI driver data on probe Lee Jones
2013-12-02 18:00 ` Lee Jones
2013-12-02 18:10 ` [alsa-devel] " Lars-Peter Clausen
2013-12-02 18:10 ` Lars-Peter Clausen
2013-12-03 8:40 ` Lee Jones
2013-12-03 8:40 ` Lee Jones
2013-12-03 8:57 ` Lars-Peter Clausen
2013-12-03 8:57 ` [alsa-devel] " Lars-Peter Clausen
2013-12-03 8:57 ` Lars-Peter Clausen
2013-12-03 9:59 ` Lee Jones
2013-12-03 9:59 ` [alsa-devel] " Lee Jones
2013-12-03 9:59 ` Lee Jones
2013-12-02 18:34 ` [alsa-devel] [PATCH 1/3] ASoC: ux500_pcm: Stop pretending that we support varying address widths Lars-Peter Clausen
2013-12-02 18:34 ` Lars-Peter Clausen
2013-12-03 8:31 ` Lee Jones
2013-12-03 8:31 ` Lee Jones
2013-12-02 19:09 ` Mark Brown
2013-12-02 19:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203100334.GI11828@lee--X1 \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.