All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control
Date: Wed, 4 Dec 2013 09:07:03 -0800	[thread overview]
Message-ID: <20131204170703.GA14859@kroah.com> (raw)
In-Reply-To: <CANsc=4UHEG5cmg9SD3r3rsuJnM9zqq2WiTQdUwrYFr_kkbsVvg@mail.gmail.com>

On Wed, Dec 04, 2013 at 11:52:34AM -0500, Adrien Verg? wrote:
> Hi all,
> 
> First, please excuse me for these misformatted patches that my email
> client messed up. Next time I will use git send-email. The 3 patches
> can be found on
> http://git.dorsal.polymtl.ca/~averge?p=linux.git;a=shortlog;h=refs/heads/etm_with_addr_and_pid
> 
> Greg: you're right, sysfs is a questionable place for tracing/debug
> code. Debugfs or /dev entries would be the right place.

Why would /dev be correct?

What's wrong with the existing tracing infrastructure that you need to
create a new one?

> Though, the only support for ETM in Linux is there, and currently very
> limited because tracing options such as address and pid are not
> configurable. The code I propose would make it usable, until someone
> with time (and more experience than me ;)) moves it out from sysfs.

Your pid implementation is broken, see my other email about that :(

And again, what's wrong with the existing tracing functionalty that is
processor agnostic?  Why can't we just delete this driver today and use
the existing trace code?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Adrien Vergé" <adrienverge@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Russell King <linux@arm.linux.org.uk>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	Will Deacon <will.deacon@arm.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control
Date: Wed, 4 Dec 2013 09:07:03 -0800	[thread overview]
Message-ID: <20131204170703.GA14859@kroah.com> (raw)
In-Reply-To: <CANsc=4UHEG5cmg9SD3r3rsuJnM9zqq2WiTQdUwrYFr_kkbsVvg@mail.gmail.com>

On Wed, Dec 04, 2013 at 11:52:34AM -0500, Adrien Vergé wrote:
> Hi all,
> 
> First, please excuse me for these misformatted patches that my email
> client messed up. Next time I will use git send-email. The 3 patches
> can be found on
> http://git.dorsal.polymtl.ca/~averge?p=linux.git;a=shortlog;h=refs/heads/etm_with_addr_and_pid
> 
> Greg: you're right, sysfs is a questionable place for tracing/debug
> code. Debugfs or /dev entries would be the right place.

Why would /dev be correct?

What's wrong with the existing tracing infrastructure that you need to
create a new one?

> Though, the only support for ETM in Linux is there, and currently very
> limited because tracing options such as address and pid are not
> configurable. The code I propose would make it usable, until someone
> with time (and more experience than me ;)) moves it out from sysfs.

Your pid implementation is broken, see my other email about that :(

And again, what's wrong with the existing tracing functionalty that is
processor agnostic?  Why can't we just delete this driver today and use
the existing trace code?

thanks,

greg k-h

  reply	other threads:[~2013-12-04 17:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04  4:39 [PATCH 0/3] ARM Coresight: Enhance ETM tracing control Adrien Vergé
2013-12-04  4:39 ` Adrien Vergé
2013-12-04  7:04 ` Greg Kroah-Hartman
2013-12-04  7:04   ` Greg Kroah-Hartman
2013-12-04 16:52   ` Adrien Vergé
2013-12-04 16:52     ` Adrien Vergé
2013-12-04 17:07     ` Greg Kroah-Hartman [this message]
2013-12-04 17:07       ` Greg Kroah-Hartman
2013-12-04 21:12       ` Adrien Vergé
2013-12-04 21:12         ` Adrien Vergé
2013-12-04 23:02         ` Greg Kroah-Hartman
2013-12-04 23:02           ` Greg Kroah-Hartman
2013-12-05  3:49           ` Adrien Vergé
2013-12-05  3:49             ` Adrien Vergé
2013-12-05  4:01             ` Greg Kroah-Hartman
2013-12-05  4:01               ` Greg Kroah-Hartman
2013-12-05 20:12               ` Christopher Covington
2013-12-05 20:12                 ` Christopher Covington
2013-12-05 20:16                 ` Greg Kroah-Hartman
2013-12-05 20:16                   ` Greg Kroah-Hartman
2013-12-05 22:45                   ` Christopher Covington
2013-12-05 22:45                     ` Christopher Covington
2013-12-05 23:26                     ` Greg Kroah-Hartman
2013-12-05 23:26                       ` Greg Kroah-Hartman
2013-12-05 23:54                     ` Adrien Vergé
2013-12-05 23:54                       ` Adrien Vergé
2013-12-06  0:06                       ` Greg Kroah-Hartman
2013-12-06  0:06                         ` Greg Kroah-Hartman
2013-12-06  0:23                         ` Russell King - ARM Linux
2013-12-06  0:23                           ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131204170703.GA14859@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.