From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, Seungwon Jeon <tgih.jun@samsung.com>,
linux-mmc@vger.kernel.org, Jaehoon Chung <jh80.chung@samsung.com>,
Kumar Gala <galak@codeaurora.org>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Chris Ball <cjb@laptop.org>, Dinh Nguyen <dinguyen@altera.com>
Subject: Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform
Date: Fri, 6 Dec 2013 02:39:14 +0100 [thread overview]
Message-ID: <201312060239.14832.arnd@arndb.de> (raw)
In-Reply-To: <1383889128-12540-3-git-send-email-zhangfei.gao@linaro.org>
On Friday 08 November 2013, Zhangfei Gao wrote:
> Add dw_mmc-k3.c for k3v2, support sd/emmc
>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Tested-by: Zhigang Wang <brooke.wangzhigang@huawei.com>
We are currently having the exact same discussion problem on the altera
version of dw_mmc: It seems that all this driver does in addition to the
common code is to have a custom way to set up the card clocks.
In both cases, there is a custom piece of IP logic providing this clock
(here it is in the "hisilicon,pctrl" node). IMHO that should be a proper
clock driver so you can use the existing call to clk_set_rate to set
it up and not need a special platform driver at all.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform
Date: Fri, 6 Dec 2013 02:39:14 +0100 [thread overview]
Message-ID: <201312060239.14832.arnd@arndb.de> (raw)
In-Reply-To: <1383889128-12540-3-git-send-email-zhangfei.gao@linaro.org>
On Friday 08 November 2013, Zhangfei Gao wrote:
> Add dw_mmc-k3.c for k3v2, support sd/emmc
>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Tested-by: Zhigang Wang <brooke.wangzhigang@huawei.com>
We are currently having the exact same discussion problem on the altera
version of dw_mmc: It seems that all this driver does in addition to the
common code is to have a custom way to set up the card clocks.
In both cases, there is a custom piece of IP logic providing this clock
(here it is in the "hisilicon,pctrl" node). IMHO that should be a proper
clock driver so you can use the existing call to clk_set_rate to set
it up and not need a special platform driver at all.
Arnd
next prev parent reply other threads:[~2013-12-06 1:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 5:38 [PATCH v3 0/2] mmc: dw_mmc: add dw_mmc-k3 Zhangfei Gao
2013-11-08 5:38 ` Zhangfei Gao
2013-11-08 5:38 ` [PATCH 1/2] mmc: dw_mmc: add dw_mci_of_get_cd_gpio to handle cd pin Zhangfei Gao
2013-11-08 5:38 ` Zhangfei Gao
2013-12-02 8:05 ` Zhangfei Gao
2013-12-02 8:05 ` Zhangfei Gao
2013-12-03 6:00 ` Jaehoon Chung
2013-12-03 6:00 ` Jaehoon Chung
2013-11-08 5:38 ` [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform Zhangfei Gao
2013-11-08 5:38 ` Zhangfei Gao
2013-12-05 14:00 ` Seungwon Jeon
2013-12-05 14:00 ` Seungwon Jeon
2013-12-11 5:47 ` Zhangfei Gao
2013-12-11 5:47 ` Zhangfei Gao
2013-12-05 14:29 ` Rob Herring
2013-12-05 14:29 ` Rob Herring
2013-12-11 5:55 ` Zhangfei Gao
2013-12-11 5:55 ` Zhangfei Gao
2013-12-06 1:39 ` Arnd Bergmann [this message]
2013-12-06 1:39 ` Arnd Bergmann
2013-12-11 3:31 ` Zhangfei Gao
2013-12-11 3:31 ` Zhangfei Gao
2013-12-11 3:45 ` Arnd Bergmann
2013-12-11 3:45 ` Arnd Bergmann
2013-12-11 18:48 ` Dinh Nguyen
2013-12-11 18:48 ` Dinh Nguyen
2013-12-11 23:40 ` Heiko Stübner
2013-12-11 23:40 ` Heiko Stübner
-- strict thread matches above, loose matches on Subject: below --
2013-10-21 7:13 [v2 PATCH 0/2] mmc: dw_mmc: add dw_mmc-k3 Zhangfei Gao
[not found] ` <1382339639-16764-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-10-21 7:13 ` [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform Zhangfei Gao
2013-10-21 7:13 ` Zhangfei Gao
2013-10-23 13:03 ` Zhangfei Gao
2013-10-23 13:03 ` Zhangfei Gao
2013-10-27 2:28 ` Chris Ball
2013-10-27 2:28 ` Chris Ball
2013-10-28 6:29 ` Kumar Gala
2013-10-28 6:29 ` Kumar Gala
2013-10-29 7:02 ` zhangfei gao
2013-10-29 7:02 ` zhangfei gao
2013-11-01 6:24 ` Seungwon Jeon
2013-11-01 6:24 ` Seungwon Jeon
2013-11-01 7:13 ` zhangfei gao
2013-11-01 7:13 ` zhangfei gao
2013-11-01 8:21 ` Seungwon Jeon
2013-11-01 8:21 ` Seungwon Jeon
2013-11-01 19:31 ` zhangfei gao
2013-11-01 19:31 ` zhangfei gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312060239.14832.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=galak@codeaurora.org \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.