From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Rafael Aquini <aquini@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Christoph Lameter <cl@linux.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Vlastimil Babka <vbabka@suse.cz>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [PATCH v2 4/7] mm/migrate: remove putback_lru_pages, fix comment on putback_movable_pages
Date: Tue, 10 Dec 2013 17:51:47 +0900 [thread overview]
Message-ID: <20131210085147.GD24992@lge.com> (raw)
In-Reply-To: <52a67d8c.6966420a.7a42.555fSMTPIN_ADDED_BROKEN@mx.google.com>
> >@@ -1704,6 +1688,12 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
> > nr_remaining = migrate_pages(&migratepages, alloc_misplaced_dst_page,
> > node, MIGRATE_ASYNC, MR_NUMA_MISPLACED);
> > if (nr_remaining) {
> >+ if (!list_empty(&migratepages)) {
> >+ list_del(&page->lru);
> >+ dec_zone_page_state(page, NR_ISOLATED_ANON +
> >+ page_is_file_cache(page));
> >+ putback_lru_page(page);
> >+ }
> > putback_lru_pages(&migratepages);
>
> You should remove this line. Otherwise,
Yes, you are right. I will send next version. T_T
>
> Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Rafael Aquini <aquini@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Christoph Lameter <cl@linux.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Vlastimil Babka <vbabka@suse.cz>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [PATCH v2 4/7] mm/migrate: remove putback_lru_pages, fix comment on putback_movable_pages
Date: Tue, 10 Dec 2013 17:51:47 +0900 [thread overview]
Message-ID: <20131210085147.GD24992@lge.com> (raw)
In-Reply-To: <52a67d8c.6966420a.7a42.555fSMTPIN_ADDED_BROKEN@mx.google.com>
> >@@ -1704,6 +1688,12 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
> > nr_remaining = migrate_pages(&migratepages, alloc_misplaced_dst_page,
> > node, MIGRATE_ASYNC, MR_NUMA_MISPLACED);
> > if (nr_remaining) {
> >+ if (!list_empty(&migratepages)) {
> >+ list_del(&page->lru);
> >+ dec_zone_page_state(page, NR_ISOLATED_ANON +
> >+ page_is_file_cache(page));
> >+ putback_lru_page(page);
> >+ }
> > putback_lru_pages(&migratepages);
>
> You should remove this line. Otherwise,
Yes, you are right. I will send next version. T_T
>
> Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Thanks.
next prev parent reply other threads:[~2013-12-10 8:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 9:10 [PATCH v2 0/7] correct and clean-up migration related stuff Joonsoo Kim
2013-12-09 9:10 ` Joonsoo Kim
2013-12-09 9:10 ` [PATCH v2 1/7] mm/migrate: add comment about permanent failure path Joonsoo Kim
2013-12-09 9:10 ` Joonsoo Kim
2013-12-10 1:42 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 2/7] mm/migrate: correct failure handling if !hugepage_migration_support() Joonsoo Kim
2013-12-09 9:10 ` Joonsoo Kim
2013-12-09 16:17 ` Christoph Lameter
2013-12-09 16:17 ` Christoph Lameter
2013-12-10 8:38 ` Joonsoo Kim
2013-12-10 8:38 ` Joonsoo Kim
2013-12-10 2:17 ` Wanpeng Li
2013-12-10 8:45 ` Joonsoo Kim
2013-12-10 8:45 ` Joonsoo Kim
2013-12-10 9:27 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 3/7] mm/mempolicy: correct putback method for isolate pages if failed Joonsoo Kim
2013-12-09 9:10 ` Joonsoo Kim
2013-12-09 16:41 ` Rafael Aquini
2013-12-09 16:41 ` Rafael Aquini
2013-12-10 2:22 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 4/7] mm/migrate: remove putback_lru_pages, fix comment on putback_movable_pages Joonsoo Kim
2013-12-09 9:10 ` Joonsoo Kim
2013-12-10 2:33 ` Wanpeng Li
2013-12-10 8:51 ` Joonsoo Kim [this message]
2013-12-10 8:51 ` Joonsoo Kim
2013-12-10 9:00 ` Joonsoo Kim
2013-12-10 9:00 ` Joonsoo Kim
2013-12-09 9:10 ` [PATCH v2 5/7] mm/compaction: respect ignore_skip_hint in update_pageblock_skip Joonsoo Kim
2013-12-09 9:10 ` Joonsoo Kim
2013-12-10 2:50 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 6/7] mm/migrate: remove unused function, fail_migrate_page() Joonsoo Kim
2013-12-09 9:10 ` Joonsoo Kim
2013-12-09 16:20 ` Christoph Lameter
2013-12-09 16:20 ` Christoph Lameter
2013-12-09 17:07 ` Naoya Horiguchi
2013-12-09 17:07 ` Naoya Horiguchi
2013-12-10 2:36 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 7/7] mm/migrate: remove result argument on page allocation function for migration Joonsoo Kim
2013-12-09 9:10 ` Joonsoo Kim
2013-12-09 16:40 ` Christoph Lameter
2013-12-09 16:40 ` Christoph Lameter
2013-12-10 3:22 ` Wanpeng Li
2013-12-11 8:47 ` Joonsoo Kim
2013-12-11 8:47 ` Joonsoo Kim
2013-12-11 16:00 ` Christoph Lameter
2013-12-11 16:00 ` Christoph Lameter
2013-12-12 0:07 ` Joonsoo Kim
2013-12-12 0:07 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210085147.GD24992@lge.com \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
--cc=vbabka@suse.cz \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.