Re: [PATCH v2 7/7] mm/migrate: remove result argument on page allocation function for migration

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	Rafael Aquini <aquini@redhat.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Vlastimil Babka <vbabka@suse.cz>,
	Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [PATCH v2 7/7] mm/migrate: remove result argument on page allocation function for migration
Date: Thu, 12 Dec 2013 09:07:14 +0900	[thread overview]
Message-ID: <20131212000714.GA3634@lge.com> (raw)
In-Reply-To: <00000142e263bbcd-65959fd3-eadc-4580-b55b-065c734a229e-000000@email.amazonses.com>

On Wed, Dec 11, 2013 at 04:00:56PM +0000, Christoph Lameter wrote:
> On Wed, 11 Dec 2013, Joonsoo Kim wrote:
> 
> > In do_move_pages(), if error occurs, 'goto out_pm' is executed and the
> > page status doesn't back to userspace. So we don't need to store err number.
> 
> If a page cannot be moved then the error code is containing the number of
> pages that could not be migrated. The check there is for err < 0.
> So a positive number is not an error.
> 
> migrate_pages only returns an error code if we are running out of memory.

Ah... I missed it. I will drop this patch and send v3 for whole patchset.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	Rafael Aquini <aquini@redhat.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Vlastimil Babka <vbabka@suse.cz>,
	Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [PATCH v2 7/7] mm/migrate: remove result argument on page allocation function for migration
Date: Thu, 12 Dec 2013 09:07:14 +0900	[thread overview]
Message-ID: <20131212000714.GA3634@lge.com> (raw)
In-Reply-To: <00000142e263bbcd-65959fd3-eadc-4580-b55b-065c734a229e-000000@email.amazonses.com>

On Wed, Dec 11, 2013 at 04:00:56PM +0000, Christoph Lameter wrote:
> On Wed, 11 Dec 2013, Joonsoo Kim wrote:
> 
> > In do_move_pages(), if error occurs, 'goto out_pm' is executed and the
> > page status doesn't back to userspace. So we don't need to store err number.
> 
> If a page cannot be moved then the error code is containing the number of
> pages that could not be migrated. The check there is for err < 0.
> So a positive number is not an error.
> 
> migrate_pages only returns an error code if we are running out of memory.

Ah... I missed it. I will drop this patch and send v3 for whole patchset.

Thanks.

next prev parent reply	other threads:[~2013-12-12  0:04 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  9:10 [PATCH v2 0/7] correct and clean-up migration related stuff Joonsoo Kim
2013-12-09  9:10 ` Joonsoo Kim
2013-12-09  9:10 ` [PATCH v2 1/7] mm/migrate: add comment about permanent failure path Joonsoo Kim
2013-12-09  9:10   ` Joonsoo Kim
2013-12-10  1:42   ` Wanpeng Li
2013-12-09  9:10 ` [PATCH v2 2/7] mm/migrate: correct failure handling if !hugepage_migration_support() Joonsoo Kim
2013-12-09  9:10   ` Joonsoo Kim
2013-12-09 16:17   ` Christoph Lameter
2013-12-09 16:17     ` Christoph Lameter
2013-12-10  8:38     ` Joonsoo Kim
2013-12-10  8:38       ` Joonsoo Kim
2013-12-10  2:17   ` Wanpeng Li
2013-12-10  8:45     ` Joonsoo Kim
2013-12-10  8:45       ` Joonsoo Kim
2013-12-10  9:27       ` Wanpeng Li
2013-12-09  9:10 ` [PATCH v2 3/7] mm/mempolicy: correct putback method for isolate pages if failed Joonsoo Kim
2013-12-09  9:10   ` Joonsoo Kim
2013-12-09 16:41   ` Rafael Aquini
2013-12-09 16:41     ` Rafael Aquini
2013-12-10  2:22   ` Wanpeng Li
2013-12-09  9:10 ` [PATCH v2 4/7] mm/migrate: remove putback_lru_pages, fix comment on putback_movable_pages Joonsoo Kim
2013-12-09  9:10   ` Joonsoo Kim
2013-12-10  2:33   ` Wanpeng Li
2013-12-10  8:51     ` Joonsoo Kim
2013-12-10  8:51       ` Joonsoo Kim
2013-12-10  9:00       ` Joonsoo Kim
2013-12-10  9:00         ` Joonsoo Kim
2013-12-09  9:10 ` [PATCH v2 5/7] mm/compaction: respect ignore_skip_hint in update_pageblock_skip Joonsoo Kim
2013-12-09  9:10   ` Joonsoo Kim
2013-12-10  2:50   ` Wanpeng Li
2013-12-09  9:10 ` [PATCH v2 6/7] mm/migrate: remove unused function, fail_migrate_page() Joonsoo Kim
2013-12-09  9:10   ` Joonsoo Kim
2013-12-09 16:20   ` Christoph Lameter
2013-12-09 16:20     ` Christoph Lameter
2013-12-09 17:07   ` Naoya Horiguchi
2013-12-09 17:07     ` Naoya Horiguchi
2013-12-10  2:36   ` Wanpeng Li
2013-12-09  9:10 ` [PATCH v2 7/7] mm/migrate: remove result argument on page allocation function for migration Joonsoo Kim
2013-12-09  9:10   ` Joonsoo Kim
2013-12-09 16:40   ` Christoph Lameter
2013-12-09 16:40     ` Christoph Lameter
2013-12-10  3:22     ` Wanpeng Li
2013-12-11  8:47     ` Joonsoo Kim
2013-12-11  8:47       ` Joonsoo Kim
2013-12-11 16:00       ` Christoph Lameter
2013-12-11 16:00         ` Christoph Lameter
2013-12-12  0:07         ` Joonsoo Kim [this message]
2013-12-12  0:07           ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212000714.GA3634@lge.com \
    --to=iamjoonsoo.kim@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=aquini@redhat.com \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=riel@redhat.com \
    --cc=vbabka@suse.cz \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.