All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Belisko Marek <marek.belisko@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Dr. H. Nikolaus Schaller" <hns@goldelico.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] omap: twl-common: Fix musb-hdrc device name.
Date: Fri, 13 Dec 2013 09:36:36 -0800	[thread overview]
Message-ID: <20131213173636.GG28184@atomide.com> (raw)
In-Reply-To: <52AAF5E6.1050900@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [131213 03:57]:
> On Friday 13 December 2013 04:57 PM, Belisko Marek wrote:
> > Kishon can you please comment on that? Would be possible to get your
> > patch to 3.13 (I seen some comments from Felipe).
> 
> I'm not sure as my patch modifies all the board files. There was initially some
> confusion w.r.t when the board files will be dropped. But since board files
> will still be there in 3.13, I'd recommend my patch  [1] to be taken. Anyways
> if you have tested my patch (series), pls give your Tested-by.
> 
> Tony, summary of the issue..
> After the platform devices are created using PLATFORM_DEVID_AUTO, the
> device names given in usb_bind_phy (in board file) does not match with
> the actual device name causing the USB PHY library not to return the
> PHY reference when the MUSB controller request for the PHY in the non-dt boot
> case. So removed creating platform devices using PLATFORM_DEVID_AUTO in
> omap2430.c. So had to make the corresponding changes in board files.

OK. Can you please repost with a proper commit id for what caused the
regression and summararize why it should be fixed this way. Something like:

Commit abcd1234 (usb: blah foo bar) caused blah blah blah. Fix the issue
with blah blah blah. Note that the board-*.c files will be removed soon,
but for v3.13 we still support both legacy booting and device tree based
booting and need to fix it.

Regards,

Tony
 
> [1] -> http://lists.scusting.com/index.php?t=msg&th=375579&start=0&S=Google

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap: twl-common: Fix musb-hdrc device name.
Date: Fri, 13 Dec 2013 09:36:36 -0800	[thread overview]
Message-ID: <20131213173636.GG28184@atomide.com> (raw)
In-Reply-To: <52AAF5E6.1050900@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [131213 03:57]:
> On Friday 13 December 2013 04:57 PM, Belisko Marek wrote:
> > Kishon can you please comment on that? Would be possible to get your
> > patch to 3.13 (I seen some comments from Felipe).
> 
> I'm not sure as my patch modifies all the board files. There was initially some
> confusion w.r.t when the board files will be dropped. But since board files
> will still be there in 3.13, I'd recommend my patch  [1] to be taken. Anyways
> if you have tested my patch (series), pls give your Tested-by.
> 
> Tony, summary of the issue..
> After the platform devices are created using PLATFORM_DEVID_AUTO, the
> device names given in usb_bind_phy (in board file) does not match with
> the actual device name causing the USB PHY library not to return the
> PHY reference when the MUSB controller request for the PHY in the non-dt boot
> case. So removed creating platform devices using PLATFORM_DEVID_AUTO in
> omap2430.c. So had to make the corresponding changes in board files.

OK. Can you please repost with a proper commit id for what caused the
regression and summararize why it should be fixed this way. Something like:

Commit abcd1234 (usb: blah foo bar) caused blah blah blah. Fix the issue
with blah blah blah. Note that the board-*.c files will be removed soon,
but for v3.13 we still support both legacy booting and device tree based
booting and need to fix it.

Regards,

Tony
 
> [1] -> http://lists.scusting.com/index.php?t=msg&th=375579&start=0&S=Google

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Belisko Marek <marek.belisko@gmail.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH] omap: twl-common: Fix musb-hdrc device name.
Date: Fri, 13 Dec 2013 09:36:36 -0800	[thread overview]
Message-ID: <20131213173636.GG28184@atomide.com> (raw)
In-Reply-To: <52AAF5E6.1050900@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [131213 03:57]:
> On Friday 13 December 2013 04:57 PM, Belisko Marek wrote:
> > Kishon can you please comment on that? Would be possible to get your
> > patch to 3.13 (I seen some comments from Felipe).
> 
> I'm not sure as my patch modifies all the board files. There was initially some
> confusion w.r.t when the board files will be dropped. But since board files
> will still be there in 3.13, I'd recommend my patch  [1] to be taken. Anyways
> if you have tested my patch (series), pls give your Tested-by.
> 
> Tony, summary of the issue..
> After the platform devices are created using PLATFORM_DEVID_AUTO, the
> device names given in usb_bind_phy (in board file) does not match with
> the actual device name causing the USB PHY library not to return the
> PHY reference when the MUSB controller request for the PHY in the non-dt boot
> case. So removed creating platform devices using PLATFORM_DEVID_AUTO in
> omap2430.c. So had to make the corresponding changes in board files.

OK. Can you please repost with a proper commit id for what caused the
regression and summararize why it should be fixed this way. Something like:

Commit abcd1234 (usb: blah foo bar) caused blah blah blah. Fix the issue
with blah blah blah. Note that the board-*.c files will be removed soon,
but for v3.13 we still support both legacy booting and device tree based
booting and need to fix it.

Regards,

Tony
 
> [1] -> http://lists.scusting.com/index.php?t=msg&th=375579&start=0&S=Google

  reply	other threads:[~2013-12-13 17:36 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03  8:33 [PATCH] omap: twl-common: Fix musb-hdrc device name Marek Belisko
2013-12-03  8:33 ` Marek Belisko
2013-12-03  8:58 ` Kishon Vijay Abraham I
2013-12-03  8:58   ` Kishon Vijay Abraham I
2013-12-03  8:58   ` Kishon Vijay Abraham I
2013-12-03  9:08   ` Belisko Marek
2013-12-03  9:08     ` Belisko Marek
2013-12-03  9:19     ` Kishon Vijay Abraham I
2013-12-03  9:19       ` Kishon Vijay Abraham I
2013-12-03  9:19       ` Kishon Vijay Abraham I
2013-12-03  9:20     ` Belisko Marek
2013-12-03  9:20       ` Belisko Marek
2013-12-05 18:43       ` Tony Lindgren
2013-12-05 18:43         ` Tony Lindgren
2013-12-09  7:35         ` Belisko Marek
2013-12-09  7:35           ` Belisko Marek
2013-12-09 17:50           ` Tony Lindgren
2013-12-09 17:50             ` Tony Lindgren
2013-12-13 11:27             ` Belisko Marek
2013-12-13 11:27               ` Belisko Marek
2013-12-13 11:56               ` Kishon Vijay Abraham I
2013-12-13 11:56                 ` Kishon Vijay Abraham I
2013-12-13 17:36                 ` Tony Lindgren [this message]
2013-12-13 17:36                   ` Tony Lindgren
2013-12-13 17:36                   ` Tony Lindgren
2013-12-16  8:52                   ` Kishon Vijay Abraham I
2013-12-16  8:52                     ` Kishon Vijay Abraham I
2013-12-16  8:52                     ` Kishon Vijay Abraham I
2013-12-16 15:26                     ` Kishon Vijay Abraham I
2013-12-16 15:26                       ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131213173636.GG28184@atomide.com \
    --to=tony@atomide.com \
    --cc=hns@goldelico.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marek.belisko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.