From: Kishon Vijay Abraham I <kishon@ti.com>
To: Marek Belisko <marek.belisko@open-nandra.com>,
tony@atomide.com, linux@arm.linux.org.uk
Cc: hns@goldelico.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] omap: twl-common: Fix musb-hdrc device name.
Date: Tue, 3 Dec 2013 14:28:43 +0530 [thread overview]
Message-ID: <529D9D43.6040101@ti.com> (raw)
In-Reply-To: <1386059589-4030-1-git-send-email-marek.belisko@open-nandra.com>
Hi,
On Tuesday 03 December 2013 02:03 PM, Marek Belisko wrote:
> Without this change when booting omap3 device (gta04) with board file
> leads to follwing errors:
>
> [ 1.203308] musb-hdrc musb-hdrc.0.auto: unable to find phy
> [ 1.209075] HS USB OTG: no transceiver configured
> [ 1.214019] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed with status -517
>
> and usb isn't working.
>
> This is probably regression caused by commit: 6c27f939
I think a better fix would be to have this merged..
https://lkml.org/lkml/2013/7/26/91
>
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
> arch/arm/mach-omap2/twl-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
> index b0d54da..3640ce0 100644
> --- a/arch/arm/mach-omap2/twl-common.c
> +++ b/arch/arm/mach-omap2/twl-common.c
> @@ -92,7 +92,7 @@ void __init omap_pmic_late_init(void)
>
> #if defined(CONFIG_ARCH_OMAP3)
> struct phy_consumer consumers[] = {
> - PHY_CONSUMER("musb-hdrc.0", "usb"),
> + PHY_CONSUMER("musb-hdrc.0.auto", "usb"),
the index '0' might vary for some boards leading it to again break musb.
Thanks
Kishon
WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap: twl-common: Fix musb-hdrc device name.
Date: Tue, 3 Dec 2013 14:28:43 +0530 [thread overview]
Message-ID: <529D9D43.6040101@ti.com> (raw)
In-Reply-To: <1386059589-4030-1-git-send-email-marek.belisko@open-nandra.com>
Hi,
On Tuesday 03 December 2013 02:03 PM, Marek Belisko wrote:
> Without this change when booting omap3 device (gta04) with board file
> leads to follwing errors:
>
> [ 1.203308] musb-hdrc musb-hdrc.0.auto: unable to find phy
> [ 1.209075] HS USB OTG: no transceiver configured
> [ 1.214019] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed with status -517
>
> and usb isn't working.
>
> This is probably regression caused by commit: 6c27f939
I think a better fix would be to have this merged..
https://lkml.org/lkml/2013/7/26/91
>
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
> arch/arm/mach-omap2/twl-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
> index b0d54da..3640ce0 100644
> --- a/arch/arm/mach-omap2/twl-common.c
> +++ b/arch/arm/mach-omap2/twl-common.c
> @@ -92,7 +92,7 @@ void __init omap_pmic_late_init(void)
>
> #if defined(CONFIG_ARCH_OMAP3)
> struct phy_consumer consumers[] = {
> - PHY_CONSUMER("musb-hdrc.0", "usb"),
> + PHY_CONSUMER("musb-hdrc.0.auto", "usb"),
the index '0' might vary for some boards leading it to again break musb.
Thanks
Kishon
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Marek Belisko <marek.belisko@open-nandra.com>, <tony@atomide.com>,
<linux@arm.linux.org.uk>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hns@goldelico.com>
Subject: Re: [PATCH] omap: twl-common: Fix musb-hdrc device name.
Date: Tue, 3 Dec 2013 14:28:43 +0530 [thread overview]
Message-ID: <529D9D43.6040101@ti.com> (raw)
In-Reply-To: <1386059589-4030-1-git-send-email-marek.belisko@open-nandra.com>
Hi,
On Tuesday 03 December 2013 02:03 PM, Marek Belisko wrote:
> Without this change when booting omap3 device (gta04) with board file
> leads to follwing errors:
>
> [ 1.203308] musb-hdrc musb-hdrc.0.auto: unable to find phy
> [ 1.209075] HS USB OTG: no transceiver configured
> [ 1.214019] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed with status -517
>
> and usb isn't working.
>
> This is probably regression caused by commit: 6c27f939
I think a better fix would be to have this merged..
https://lkml.org/lkml/2013/7/26/91
>
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
> arch/arm/mach-omap2/twl-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
> index b0d54da..3640ce0 100644
> --- a/arch/arm/mach-omap2/twl-common.c
> +++ b/arch/arm/mach-omap2/twl-common.c
> @@ -92,7 +92,7 @@ void __init omap_pmic_late_init(void)
>
> #if defined(CONFIG_ARCH_OMAP3)
> struct phy_consumer consumers[] = {
> - PHY_CONSUMER("musb-hdrc.0", "usb"),
> + PHY_CONSUMER("musb-hdrc.0.auto", "usb"),
the index '0' might vary for some boards leading it to again break musb.
Thanks
Kishon
next prev parent reply other threads:[~2013-12-03 8:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 8:33 [PATCH] omap: twl-common: Fix musb-hdrc device name Marek Belisko
2013-12-03 8:33 ` Marek Belisko
2013-12-03 8:58 ` Kishon Vijay Abraham I [this message]
2013-12-03 8:58 ` Kishon Vijay Abraham I
2013-12-03 8:58 ` Kishon Vijay Abraham I
2013-12-03 9:08 ` Belisko Marek
2013-12-03 9:08 ` Belisko Marek
2013-12-03 9:19 ` Kishon Vijay Abraham I
2013-12-03 9:19 ` Kishon Vijay Abraham I
2013-12-03 9:19 ` Kishon Vijay Abraham I
2013-12-03 9:20 ` Belisko Marek
2013-12-03 9:20 ` Belisko Marek
2013-12-05 18:43 ` Tony Lindgren
2013-12-05 18:43 ` Tony Lindgren
2013-12-09 7:35 ` Belisko Marek
2013-12-09 7:35 ` Belisko Marek
2013-12-09 17:50 ` Tony Lindgren
2013-12-09 17:50 ` Tony Lindgren
2013-12-13 11:27 ` Belisko Marek
2013-12-13 11:27 ` Belisko Marek
2013-12-13 11:56 ` Kishon Vijay Abraham I
2013-12-13 11:56 ` Kishon Vijay Abraham I
2013-12-13 17:36 ` Tony Lindgren
2013-12-13 17:36 ` Tony Lindgren
2013-12-13 17:36 ` Tony Lindgren
2013-12-16 8:52 ` Kishon Vijay Abraham I
2013-12-16 8:52 ` Kishon Vijay Abraham I
2013-12-16 8:52 ` Kishon Vijay Abraham I
2013-12-16 15:26 ` Kishon Vijay Abraham I
2013-12-16 15:26 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529D9D43.6040101@ti.com \
--to=kishon@ti.com \
--cc=hns@goldelico.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marek.belisko@open-nandra.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.