All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c
Date: Mon, 16 Dec 2013 06:23:38 -0800	[thread overview]
Message-ID: <20131216142338.GA24172@leaf> (raw)
In-Reply-To: <20131216112408.GA4896@rashika>

On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote:
> Mark the function virtballoon_migratepage() as static in
> virtio_balloon.c because it is not used outside this file.
> 
> This eliminates the following warning in virtio_balloon.c:
> drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/virtio/virtio_balloon.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index c444654..8c5943d 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops;
>   * This function preforms the balloon page migration task.
>   * Called through balloon_mapping->a_ops->migratepage
>   */
> -int virtballoon_migratepage(struct address_space *mapping,
> +static int virtballoon_migratepage(struct address_space *mapping,
>  		struct page *newpage, struct page *page, enum migrate_mode mode)
>  {
>  	struct balloon_dev_info *vb_dev_info = balloon_page_device(page);
> -- 
> 1.7.9.5
> 
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c
Date: Mon, 16 Dec 2013 06:23:38 -0800	[thread overview]
Message-ID: <20131216142338.GA24172@leaf> (raw)
In-Reply-To: <20131216112408.GA4896@rashika>

On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote:
> Mark the function virtballoon_migratepage() as static in
> virtio_balloon.c because it is not used outside this file.
> 
> This eliminates the following warning in virtio_balloon.c:
> drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/virtio/virtio_balloon.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index c444654..8c5943d 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops;
>   * This function preforms the balloon page migration task.
>   * Called through balloon_mapping->a_ops->migratepage
>   */
> -int virtballoon_migratepage(struct address_space *mapping,
> +static int virtballoon_migratepage(struct address_space *mapping,
>  		struct page *newpage, struct page *page, enum migrate_mode mode)
>  {
>  	struct balloon_dev_info *vb_dev_info = balloon_page_device(page);
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2013-12-16 14:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 11:24 [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c Rashika Kheria
2013-12-16 14:23 ` Josh Triplett [this message]
2013-12-16 14:23   ` Josh Triplett
2013-12-16 14:29   ` Michael S. Tsirkin
2013-12-16 14:29     ` Michael S. Tsirkin
2013-12-17  4:39     ` Rusty Russell
2013-12-17  4:39       ` Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2013-12-16 11:24 Rashika Kheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216142338.GA24172@leaf \
    --to=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rashika.kheria@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.