From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3,RESEND] rtc: Add support for Intersil ISL12057 I2C RTC chip
Date: Mon, 16 Dec 2013 13:02:57 -0800 [thread overview]
Message-ID: <20131216210257.GA7981@roeck-us.net> (raw)
In-Reply-To: <20131216201743.GT3185@sirena.org.uk>
On Mon, Dec 16, 2013 at 08:17:43PM +0000, Mark Brown wrote:
> On Mon, Dec 16, 2013 at 12:14:24PM -0800, Guenter Roeck wrote:
> > On Mon, Dec 16, 2013 at 08:49:36PM +0100, Arnaud Ebalard wrote:
>
> > > +#ifdef CONFIG_OF
> > > +static struct of_device_id isl12057_dt_match[] = {
> > > + { .compatible = "isl,isl12057" },
> > > + { },
> > > +};
> > > +#endif
>
> > Is this needed ? For i2c devices, struct i2c_device_id should be sufficient.
>
> It is required, it's bad practice to omit the vendor specifier.
> Different vendors can and do use the same prefix in their device names
> leading to collisions - for example both Wondermedia and Wolfson use wm.
> Linux happens to accept unprefixed names but that doesn't mean it's a
> good idea.
Ok, I'll keep that in mind.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: Arnaud Ebalard <arno@natisbad.org>,
Mark Rutland <mark.rutland@arm.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Peter Huewe <peter.huewe@infineon.com>,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <treding@nvidia.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Rob Landley <rob@landley.net>,
rtc-linux@googlegroups.com, Jason Cooper <jason@lakedaemon.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3,RESEND] rtc: Add support for Intersil ISL12057 I2C RTC chip
Date: Mon, 16 Dec 2013 13:02:57 -0800 [thread overview]
Message-ID: <20131216210257.GA7981@roeck-us.net> (raw)
In-Reply-To: <20131216201743.GT3185@sirena.org.uk>
On Mon, Dec 16, 2013 at 08:17:43PM +0000, Mark Brown wrote:
> On Mon, Dec 16, 2013 at 12:14:24PM -0800, Guenter Roeck wrote:
> > On Mon, Dec 16, 2013 at 08:49:36PM +0100, Arnaud Ebalard wrote:
>
> > > +#ifdef CONFIG_OF
> > > +static struct of_device_id isl12057_dt_match[] = {
> > > + { .compatible = "isl,isl12057" },
> > > + { },
> > > +};
> > > +#endif
>
> > Is this needed ? For i2c devices, struct i2c_device_id should be sufficient.
>
> It is required, it's bad practice to omit the vendor specifier.
> Different vendors can and do use the same prefix in their device names
> leading to collisions - for example both Wondermedia and Wolfson use wm.
> Linux happens to accept unprefixed names but that doesn't mean it's a
> good idea.
Ok, I'll keep that in mind.
Thanks,
Guenter
next prev parent reply other threads:[~2013-12-16 21:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 19:49 [PATCHv3,RESEND] rtc: Add support for Intersil ISL12057 I2C RTC chip Arnaud Ebalard
2013-12-16 19:49 ` Arnaud Ebalard
2013-12-16 20:14 ` Guenter Roeck
2013-12-16 20:14 ` Guenter Roeck
2013-12-16 20:17 ` Mark Brown
2013-12-16 20:17 ` Mark Brown
2013-12-16 21:02 ` Guenter Roeck [this message]
2013-12-16 21:02 ` Guenter Roeck
2013-12-16 21:05 ` [PATCHv3, RESEND] " Arnaud Ebalard
2013-12-16 21:05 ` [PATCHv3,RESEND] " Arnaud Ebalard
2013-12-16 21:24 ` Guenter Roeck
2013-12-16 21:24 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216210257.GA7981@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.