All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3,RESEND] rtc: Add support for Intersil ISL12057 I2C RTC chip
Date: Mon, 16 Dec 2013 13:24:13 -0800	[thread overview]
Message-ID: <20131216212413.GA8369@roeck-us.net> (raw)
In-Reply-To: <87r49cpkw2.fsf@natisbad.org>

On Mon, Dec 16, 2013 at 10:05:01PM +0100, Arnaud Ebalard wrote:
> Hi Guenter,
> 
> Thanks for the fast feedback! I have handled all your comments and
> tested the resulting version on my RN102 w/o problems. Will send a
> v4 in a few minutes.
> 
> Can you just look at first comment below?
> 
> Guenter Roeck <linux@roeck-us.net> writes:
> 
> >> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
> >> ---
> >> This is a resend - just in case the initial mail slept through - as I
> >> got no feedback over the past week. I have also Cc'ed additional
> >> people.
> >> 
> > Looks like your mailer corrupts the patch. You'll have to fix that.
> 
> If you wonder about the text below the SoB, this is just informational,

I know.

> i.e. to avoid having it in the final commit. Can you be more specific
> if this is not what you meant, i.e. how the patch is otherwise
> corrupted?
> 

I saved the patch and tried to run it through checkpatch. Doing so, I got a lot
of errors with "=3D" or similar, which suggests that the patch went through
Outlook, an Exchange server, or a similar e-mail "beautifier" when it was sent.

If the same happens again, I'll send you a log.

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Peter Huewe <peter.huewe@infineon.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Thierry Reding <treding@nvidia.com>,
	Mark Brown <broonie@kernel.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Grant Likely <grant.likely@linaro.org>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	Rob Landley <rob@landley.net>,
	rtc-linux@googlegroups.com, Jason Cooper <jason@lakedaemon.net>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Kumar Gala <galak@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3,RESEND] rtc: Add support for Intersil ISL12057 I2C RTC chip
Date: Mon, 16 Dec 2013 13:24:13 -0800	[thread overview]
Message-ID: <20131216212413.GA8369@roeck-us.net> (raw)
In-Reply-To: <87r49cpkw2.fsf@natisbad.org>

On Mon, Dec 16, 2013 at 10:05:01PM +0100, Arnaud Ebalard wrote:
> Hi Guenter,
> 
> Thanks for the fast feedback! I have handled all your comments and
> tested the resulting version on my RN102 w/o problems. Will send a
> v4 in a few minutes.
> 
> Can you just look at first comment below?
> 
> Guenter Roeck <linux@roeck-us.net> writes:
> 
> >> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
> >> ---
> >> This is a resend - just in case the initial mail slept through - as I
> >> got no feedback over the past week. I have also Cc'ed additional
> >> people.
> >> 
> > Looks like your mailer corrupts the patch. You'll have to fix that.
> 
> If you wonder about the text below the SoB, this is just informational,

I know.

> i.e. to avoid having it in the final commit. Can you be more specific
> if this is not what you meant, i.e. how the patch is otherwise
> corrupted?
> 

I saved the patch and tried to run it through checkpatch. Doing so, I got a lot
of errors with "=3D" or similar, which suggests that the patch went through
Outlook, an Exchange server, or a similar e-mail "beautifier" when it was sent.

If the same happens again, I'll send you a log.

Guenter

  reply	other threads:[~2013-12-16 21:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 19:49 [PATCHv3,RESEND] rtc: Add support for Intersil ISL12057 I2C RTC chip Arnaud Ebalard
2013-12-16 19:49 ` Arnaud Ebalard
2013-12-16 20:14 ` Guenter Roeck
2013-12-16 20:14   ` Guenter Roeck
2013-12-16 20:17   ` Mark Brown
2013-12-16 20:17     ` Mark Brown
2013-12-16 21:02     ` Guenter Roeck
2013-12-16 21:02       ` Guenter Roeck
2013-12-16 21:05   ` [PATCHv3, RESEND] " Arnaud Ebalard
2013-12-16 21:05     ` [PATCHv3,RESEND] " Arnaud Ebalard
2013-12-16 21:24     ` Guenter Roeck [this message]
2013-12-16 21:24       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216212413.GA8369@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.