From: Marek Vasut <marex@denx.de>
To: Huang Shijie <shijie8@gmail.com>
Cc: angus.clark@st.com, computersforpeace@gmail.com,
b44548@freescale.com, broonie@linaro.org, lee.jones@linaro.org,
linux-doc@vger.kernel.org, b18965@freescale.com,
linux-spi@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org, pekon@ti.com,
sourav.poddar@ti.com, shawn.guo@linaro.org, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/7] mtd: spi-nor: add the basic data structures
Date: Tue, 17 Dec 2013 16:16:56 +0100 [thread overview]
Message-ID: <201312171616.57029.marex@denx.de> (raw)
In-Reply-To: <20131217134923.GA1220@gmail.com>
On Tuesday, December 17, 2013 at 02:49:25 PM, Huang Shijie wrote:
> On Tue, Dec 17, 2013 at 02:05:55PM +0100, Marek Vasut wrote:
> > On Monday, December 16, 2013 at 09:58:45 AM, Huang Shijie wrote:
> > > +struct spi_nor { > > + struct mtd_info *mtd;
> > > + struct mutex lock;
> > > +
> > > + /* pointer to a spi device */
> > > + struct device *dev;
> > > + u32 page_size;
> > > + u8 addr_width;
> > > + u8 erase_opcode;
> > > + u8 read_opcode;
> > > + u8 read_dummy;
> > > + u8 program_opcode;
> > > + enum read_mode flash_read;
> > > + bool sst_write_second;
> > > + struct spi_nor_xfer_cfg cfg;
> >
> > You do want to split the function pointers below and the device
> > configuration above into separate structures.
>
> sorry, i prefer to keep them in one data structrue, just like the
> nand_chip{} does.
Can you explain why?
> > > + /* for write_reg */
> > > + u8 cmd_buf[SPI_NOR_MAX_CMD_SIZE];
> > > +
> > > + /*
> > > + * Do some work before or after we run these operations:
> > > + * read/write/erese/lock/unlock
> >
> > Proper kernel-doc style comments for this structure would be nice.
>
> Do you mean the style used by nand_chip{}?
Yes. See Documentation/kernel-doc-nano-HOWTO.txt
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Huang Shijie <shijie8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
angus.clark-qxv4g6HH51o@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
b44548-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
b18965-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
pekon-l0cyMroinI0@public.gmane.org,
sourav.poddar-l0cyMroinI0@public.gmane.org,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 2/7] mtd: spi-nor: add the basic data structures
Date: Tue, 17 Dec 2013 16:16:56 +0100 [thread overview]
Message-ID: <201312171616.57029.marex@denx.de> (raw)
In-Reply-To: <20131217134923.GA1220-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tuesday, December 17, 2013 at 02:49:25 PM, Huang Shijie wrote:
> On Tue, Dec 17, 2013 at 02:05:55PM +0100, Marek Vasut wrote:
> > On Monday, December 16, 2013 at 09:58:45 AM, Huang Shijie wrote:
> > > +struct spi_nor { > > + struct mtd_info *mtd;
> > > + struct mutex lock;
> > > +
> > > + /* pointer to a spi device */
> > > + struct device *dev;
> > > + u32 page_size;
> > > + u8 addr_width;
> > > + u8 erase_opcode;
> > > + u8 read_opcode;
> > > + u8 read_dummy;
> > > + u8 program_opcode;
> > > + enum read_mode flash_read;
> > > + bool sst_write_second;
> > > + struct spi_nor_xfer_cfg cfg;
> >
> > You do want to split the function pointers below and the device
> > configuration above into separate structures.
>
> sorry, i prefer to keep them in one data structrue, just like the
> nand_chip{} does.
Can you explain why?
> > > + /* for write_reg */
> > > + u8 cmd_buf[SPI_NOR_MAX_CMD_SIZE];
> > > +
> > > + /*
> > > + * Do some work before or after we run these operations:
> > > + * read/write/erese/lock/unlock
> >
> > Proper kernel-doc style comments for this structure would be nice.
>
> Do you mean the style used by nand_chip{}?
Yes. See Documentation/kernel-doc-nano-HOWTO.txt
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/7] mtd: spi-nor: add the basic data structures
Date: Tue, 17 Dec 2013 16:16:56 +0100 [thread overview]
Message-ID: <201312171616.57029.marex@denx.de> (raw)
In-Reply-To: <20131217134923.GA1220@gmail.com>
On Tuesday, December 17, 2013 at 02:49:25 PM, Huang Shijie wrote:
> On Tue, Dec 17, 2013 at 02:05:55PM +0100, Marek Vasut wrote:
> > On Monday, December 16, 2013 at 09:58:45 AM, Huang Shijie wrote:
> > > +struct spi_nor { > > + struct mtd_info *mtd;
> > > + struct mutex lock;
> > > +
> > > + /* pointer to a spi device */
> > > + struct device *dev;
> > > + u32 page_size;
> > > + u8 addr_width;
> > > + u8 erase_opcode;
> > > + u8 read_opcode;
> > > + u8 read_dummy;
> > > + u8 program_opcode;
> > > + enum read_mode flash_read;
> > > + bool sst_write_second;
> > > + struct spi_nor_xfer_cfg cfg;
> >
> > You do want to split the function pointers below and the device
> > configuration above into separate structures.
>
> sorry, i prefer to keep them in one data structrue, just like the
> nand_chip{} does.
Can you explain why?
> > > + /* for write_reg */
> > > + u8 cmd_buf[SPI_NOR_MAX_CMD_SIZE];
> > > +
> > > + /*
> > > + * Do some work before or after we run these operations:
> > > + * read/write/erese/lock/unlock
> >
> > Proper kernel-doc style comments for this structure would be nice.
>
> Do you mean the style used by nand_chip{}?
Yes. See Documentation/kernel-doc-nano-HOWTO.txt
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-12-17 15:16 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 8:58 [PATCH v3 0/7] mtd: spi-nor: add a new framework for SPI NOR Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` [PATCH v3 1/7] mtd: spi-nor: copy the SPI NOR commands to a new header file Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-17 13:01 ` Marek Vasut
2013-12-17 13:01 ` Marek Vasut
2013-12-17 13:01 ` Marek Vasut
2013-12-17 14:12 ` Huang Shijie
2013-12-17 14:12 ` Huang Shijie
2013-12-17 14:12 ` Huang Shijie
2013-12-16 8:58 ` [PATCH v3 2/7] mtd: spi-nor: add the basic data structures Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-17 13:05 ` Marek Vasut
2013-12-17 13:05 ` Marek Vasut
2013-12-17 13:05 ` Marek Vasut
2013-12-17 13:49 ` Huang Shijie
2013-12-17 13:49 ` Huang Shijie
2013-12-17 13:49 ` Huang Shijie
2013-12-17 15:16 ` Marek Vasut [this message]
2013-12-17 15:16 ` Marek Vasut
2013-12-17 15:16 ` Marek Vasut
2013-12-17 16:00 ` Huang Shijie
2013-12-17 16:00 ` Huang Shijie
2013-12-17 16:00 ` Huang Shijie
2013-12-16 8:58 ` [PATCH v3 3/7] mtd: spi-nor: add the framework for SPI NOR Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 18:41 ` Sourav Poddar
2013-12-16 18:41 ` Sourav Poddar
2013-12-16 18:41 ` Sourav Poddar
2013-12-17 2:56 ` Huang Shijie
2013-12-17 2:56 ` Huang Shijie
2013-12-17 2:56 ` Huang Shijie
2013-12-17 5:19 ` Sourav Poddar
2013-12-17 5:19 ` Sourav Poddar
2013-12-17 5:19 ` Sourav Poddar
2013-12-17 5:20 ` Huang Shijie
2013-12-17 5:20 ` Huang Shijie
2013-12-17 5:20 ` Huang Shijie
2013-12-17 13:07 ` Marek Vasut
2013-12-17 13:07 ` Marek Vasut
2013-12-17 13:07 ` Marek Vasut
2013-12-16 8:58 ` [PATCH v3 4/7] mtd: m25p80: use the SPI nor framework Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` [PATCH v3 5/7] mtd: spi-nor: add a helper to find the spi_device_id Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` [PATCH v3 6/7] Documentation: add the binding file for Quadspi driver Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-17 13:10 ` Marek Vasut
2013-12-17 13:10 ` Marek Vasut
2013-12-17 13:10 ` Marek Vasut
2013-12-17 13:36 ` thomas.langer
2013-12-17 13:36 ` thomas.langer at lantiq.com
2013-12-17 13:36 ` thomas.langer-th3ZBGNqt+7QT0dZR+AlfA
2013-12-17 15:10 ` Marek Vasut
2013-12-17 15:10 ` Marek Vasut
2013-12-17 15:10 ` Marek Vasut
2013-12-18 15:30 ` Gerhard Sittig
2013-12-18 15:30 ` Gerhard Sittig
2013-12-18 15:30 ` Gerhard Sittig
2013-12-18 16:03 ` Huang Shijie
2013-12-18 16:03 ` Huang Shijie
2013-12-18 16:03 ` Huang Shijie
2013-12-18 18:21 ` Gerhard Sittig
2013-12-18 18:21 ` Gerhard Sittig
2013-12-18 18:21 ` Gerhard Sittig
2013-12-16 8:58 ` [PATCH v3 7/7] mtd: spi-nor: Add Freescale QuadSpi driver Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-16 8:58 ` Huang Shijie
2013-12-17 13:16 ` Marek Vasut
2013-12-17 13:16 ` Marek Vasut
2013-12-17 13:16 ` Marek Vasut
2013-12-17 14:24 ` Huang Shijie
2013-12-17 14:24 ` Huang Shijie
2013-12-17 14:24 ` Huang Shijie
2013-12-17 4:08 ` [PATCH v3 0/7] mtd: spi-nor: add a new framework for SPI NOR Gupta, Pekon
2013-12-17 4:08 ` Gupta, Pekon
2013-12-17 4:08 ` Gupta, Pekon
2013-12-17 4:02 ` Huang Shijie
2013-12-17 4:02 ` Huang Shijie
2013-12-17 4:02 ` Huang Shijie
2013-12-17 5:00 ` Gupta, Pekon
2013-12-17 5:00 ` Gupta, Pekon
2013-12-17 5:00 ` Gupta, Pekon
2013-12-17 4:57 ` Huang Shijie
2013-12-17 4:57 ` Huang Shijie
2013-12-17 4:57 ` Huang Shijie
2013-12-17 5:45 ` Gupta, Pekon
2013-12-17 5:45 ` Gupta, Pekon
2013-12-17 5:45 ` Gupta, Pekon
2013-12-17 5:26 ` Huang Shijie
2013-12-17 5:26 ` Huang Shijie
2013-12-17 5:26 ` Huang Shijie
2013-12-17 6:07 ` Shawn Guo
2013-12-17 6:07 ` Shawn Guo
2013-12-17 6:07 ` Shawn Guo
2013-12-17 7:17 ` Gupta, Pekon
2013-12-17 7:17 ` Gupta, Pekon
2013-12-17 7:17 ` Gupta, Pekon
2013-12-17 7:17 ` Gupta, Pekon
2013-12-17 7:56 ` Shawn Guo
2013-12-17 7:56 ` Shawn Guo
2013-12-17 7:56 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312171616.57029.marex@denx.de \
--to=marex@denx.de \
--cc=angus.clark@st.com \
--cc=b18965@freescale.com \
--cc=b32955@freescale.com \
--cc=b44548@freescale.com \
--cc=broonie@linaro.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=pekon@ti.com \
--cc=shawn.guo@linaro.org \
--cc=shijie8@gmail.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.