From: Jean-Francois Moine <moinejf@free.fr>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: generic: add generic compound card with DT support
Date: Tue, 31 Dec 2013 13:36:10 +0100 [thread overview]
Message-ID: <20131231133610.2d14bc29@armhf> (raw)
In-Reply-To: <20131231115927.GK31886@sirena.org.uk>
On Tue, 31 Dec 2013 11:59:27 +0000
Mark Brown <broonie@kernel.org> wrote:
> > This code was first developped on the generic simple card, but its
> > recent DT extension cannot be easily extended again to support compound
> > cards as the one in the Cubox.
>
> It would have been useful to have provided that feedback at the time
> rather than waiting until after it had been merged - it was in review
> for long enough. It would also be good to articulate the issues with
> the binding rather than simply stating they exist, and to consider
> adding a second binding to the existing generic card rather than adding
> a totally new card.
Sorry, I spent a lot of time on DPCM, and I was not yet ready to propose
something when you accepted Kuninori's patch.
> Please also remember that all DT patches need to be reviewed by the DT
> people, you've not CCed either them or the list.
>
> > + - front-end or back-end: present if the DAI link describes resp.
> > + a front-end CPU DAI or a back-end CODEC DAI
>
> These are Linux-internal concepts which shouldn't appear in a DT binding
> or at the very least need definition. One thing to consider here is
> that these things are all about the internals of a SoC and you'd
> therefore expect that they would be defined separately from the card so
> as to avoid having to replicate information in every card using a given
> SoC.
Do you mean that, as DPCM cannot be in the DT, there should be a
specific driver for the Cubox audio card (Marvell Armada 510 + NXP HDMI
transmitter)?
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: generic: add generic compound card with DT support
Date: Tue, 31 Dec 2013 13:36:10 +0100 [thread overview]
Message-ID: <20131231133610.2d14bc29@armhf> (raw)
In-Reply-To: <20131231115927.GK31886@sirena.org.uk>
On Tue, 31 Dec 2013 11:59:27 +0000
Mark Brown <broonie@kernel.org> wrote:
> > This code was first developped on the generic simple card, but its
> > recent DT extension cannot be easily extended again to support compound
> > cards as the one in the Cubox.
>
> It would have been useful to have provided that feedback at the time
> rather than waiting until after it had been merged - it was in review
> for long enough. It would also be good to articulate the issues with
> the binding rather than simply stating they exist, and to consider
> adding a second binding to the existing generic card rather than adding
> a totally new card.
Sorry, I spent a lot of time on DPCM, and I was not yet ready to propose
something when you accepted Kuninori's patch.
> Please also remember that all DT patches need to be reviewed by the DT
> people, you've not CCed either them or the list.
>
> > + - front-end or back-end: present if the DAI link describes resp.
> > + a front-end CPU DAI or a back-end CODEC DAI
>
> These are Linux-internal concepts which shouldn't appear in a DT binding
> or at the very least need definition. One thing to consider here is
> that these things are all about the internals of a SoC and you'd
> therefore expect that they would be defined separately from the card so
> as to avoid having to replicate information in every card using a given
> SoC.
Do you mean that, as DPCM cannot be in the DT, there should be a
specific driver for the Cubox audio card (Marvell Armada 510 + NXP HDMI
transmitter)?
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2013-12-31 12:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 10:31 [PATCH] ASoC: generic: add generic compound card with DT support Jean-Francois Moine
2013-12-31 10:31 ` Jean-Francois Moine
2013-12-31 11:59 ` Mark Brown
2013-12-31 11:59 ` Mark Brown
2013-12-31 12:36 ` Jean-Francois Moine [this message]
2013-12-31 12:36 ` Jean-Francois Moine
2013-12-31 12:47 ` Mark Brown
2013-12-31 12:47 ` Mark Brown
2014-01-01 19:05 ` Lars-Peter Clausen
2014-01-01 19:05 ` [alsa-devel] " Lars-Peter Clausen
2014-01-01 20:08 ` Jean-Francois Moine
2014-01-01 20:08 ` [alsa-devel] " Jean-Francois Moine
2014-01-01 20:11 ` Lars-Peter Clausen
2014-01-02 9:26 ` Jean-Francois Moine
2014-01-02 11:10 ` Mark Brown
2014-01-02 11:10 ` Mark Brown
2014-01-02 11:43 ` Jean-Francois Moine
2014-01-02 11:56 ` Mark Brown
2014-01-02 12:44 ` Jean-Francois Moine
2014-01-02 13:10 ` Mark Brown
2014-01-02 13:10 ` Mark Brown
2014-01-02 17:50 ` Jean-Francois Moine
2014-01-02 17:50 ` [alsa-devel] " Jean-Francois Moine
2014-01-02 18:35 ` Mark Brown
2014-01-02 18:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231133610.2d14bc29@armhf \
--to=moinejf@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.