From: Han Pingtian <hanpt@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Dave Hansen <dave.hansen@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>
Subject: Re: [RFC] mm: show message when updating min_free_kbytes in thp
Date: Fri, 3 Jan 2014 11:33:03 +0800 [thread overview]
Message-ID: <20140103033303.GB4106@localhost.localdomain> (raw)
In-Reply-To: <52C5AA61.8060701@intel.com>
On Thu, Jan 02, 2014 at 10:05:21AM -0800, Dave Hansen wrote:
> On 12/31/2013 04:29 PM, Han Pingtian wrote:
> > min_free_kbytes may be updated during thp's initialization. Sometimes,
> > this will change the value being set by user. Showing message will
> > clarify this confusion.
> ...
> > - if (recommended_min > min_free_kbytes)
> > + if (recommended_min > min_free_kbytes) {
> > min_free_kbytes = recommended_min;
> > + pr_info("min_free_kbytes is updated to %d by enabling transparent hugepage.\n",
> > + min_free_kbytes);
> > + }
>
> "updated" doesn't tell us much. It's also kinda nasty that if we enable
> then disable THP, we end up with an elevated min_free_kbytes. Maybe we
> should at least put something in that tells the user how to get back
> where they were if they care:
>
> "raising min_free_kbytes from %d to %d to help transparent hugepage
> allocations"
>
Thanks. I have updated it according to your suggestion.
WARNING: multiple messages have this Message-ID (diff)
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Dave Hansen <dave.hansen@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>
Subject: Re: [RFC] mm: show message when updating min_free_kbytes in thp
Date: Fri, 3 Jan 2014 11:33:03 +0800 [thread overview]
Message-ID: <20140103033303.GB4106@localhost.localdomain> (raw)
In-Reply-To: <52C5AA61.8060701@intel.com>
On Thu, Jan 02, 2014 at 10:05:21AM -0800, Dave Hansen wrote:
> On 12/31/2013 04:29 PM, Han Pingtian wrote:
> > min_free_kbytes may be updated during thp's initialization. Sometimes,
> > this will change the value being set by user. Showing message will
> > clarify this confusion.
> ...
> > - if (recommended_min > min_free_kbytes)
> > + if (recommended_min > min_free_kbytes) {
> > min_free_kbytes = recommended_min;
> > + pr_info("min_free_kbytes is updated to %d by enabling transparent hugepage.\n",
> > + min_free_kbytes);
> > + }
>
> "updated" doesn't tell us much. It's also kinda nasty that if we enable
> then disable THP, we end up with an elevated min_free_kbytes. Maybe we
> should at least put something in that tells the user how to get back
> where they were if they care:
>
> "raising min_free_kbytes from %d to %d to help transparent hugepage
> allocations"
>
Thanks. I have updated it according to your suggestion.
>From f9902b16ff0c326349e72eca9facef2c98f8595d Mon Sep 17 00:00:00 2001
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
Date: Fri, 3 Jan 2014 11:10:49 +0800
Subject: [PATCH] mm: show message when raising min_free_kbytes in THP
min_free_kbytes may be raised during THP's initialization. Sometimes,
this will change the value being set by user. Showing message will
clarify this confusion.
Showing the old value of min_free_kbytes according to Dave Hansen's
suggestion. This will give user the chance to restore old value of
min_free_kbytes.
Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
---
mm/huge_memory.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 7de1bf8..1f0356d 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -130,8 +130,11 @@ static int set_recommended_min_free_kbytes(void)
(unsigned long) nr_free_buffer_pages() / 20);
recommended_min <<= (PAGE_SHIFT-10);
- if (recommended_min > min_free_kbytes)
+ if (recommended_min > min_free_kbytes) {
+ pr_info("raising min_free_kbytes from %d to %d to help transparent hugepage allocations\n",
+ min_free_kbytes, recommended_min);
min_free_kbytes = recommended_min;
+ }
setup_per_zone_wmarks();
return 0;
}
--
1.7.7.6
next prev parent reply other threads:[~2014-01-03 3:33 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 0:29 [RFC] mm: show message when updating min_free_kbytes in thp Han Pingtian
2014-01-01 0:29 ` Han Pingtian
2014-01-02 18:05 ` Dave Hansen
2014-01-02 18:05 ` Dave Hansen
2014-01-02 21:58 ` David Rientjes
2014-01-02 21:58 ` David Rientjes
2014-01-02 22:10 ` Dave Hansen
2014-01-02 22:10 ` Dave Hansen
2014-01-02 23:36 ` David Rientjes
2014-01-02 23:36 ` David Rientjes
2014-01-02 23:48 ` Dave Hansen
2014-01-02 23:48 ` Dave Hansen
2014-01-03 3:33 ` Han Pingtian [this message]
2014-01-03 3:33 ` Han Pingtian
2014-01-03 18:17 ` Dave Hansen
2014-01-03 18:17 ` Dave Hansen
2014-01-05 0:35 ` Han Pingtian
2014-01-05 0:35 ` Han Pingtian
2014-01-06 16:46 ` Michal Hocko
2014-01-06 16:46 ` Michal Hocko
2014-01-08 3:59 ` Han Pingtian
2014-01-08 3:59 ` Han Pingtian
2014-01-08 8:20 ` Han Pingtian
2014-01-08 8:20 ` Han Pingtian
2014-01-08 10:16 ` Michal Hocko
2014-01-08 10:16 ` Michal Hocko
2014-01-09 7:32 ` Han Pingtian
2014-01-09 7:32 ` Han Pingtian
2014-01-09 9:02 ` Michal Hocko
2014-01-09 9:02 ` Michal Hocko
2014-01-09 21:15 ` David Rientjes
2014-01-09 21:15 ` David Rientjes
2014-01-10 8:05 ` Michal Hocko
2014-01-10 8:05 ` Michal Hocko
2014-01-10 8:13 ` Andrew Morton
2014-01-10 8:13 ` Andrew Morton
2014-01-10 8:17 ` Michal Hocko
2014-01-10 8:17 ` Michal Hocko
2014-01-11 3:27 ` Han Pingtian
2014-01-11 3:27 ` Han Pingtian
2014-01-14 20:07 ` Han Pingtian
2014-01-14 20:07 ` Han Pingtian
2014-01-14 23:52 ` Andrew Morton
2014-01-14 23:52 ` Andrew Morton
2014-01-15 0:25 ` David Rientjes
2014-01-15 0:25 ` David Rientjes
2014-01-15 0:35 ` Andrew Morton
2014-01-15 0:35 ` Andrew Morton
2014-01-15 0:52 ` David Rientjes
2014-01-15 0:52 ` David Rientjes
2014-01-15 15:22 ` Mel Gorman
2014-01-15 15:22 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103033303.GB4106@localhost.localdomain \
--to=hanpt@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.