All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: linux-kernel@vger.kernel.org,
	Andrea Arcangeli <aarcange@redhat.com>,
	Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>
Subject: Re: [RFC] mm: show message when updating min_free_kbytes in thp
Date: Fri, 03 Jan 2014 10:17:54 -0800	[thread overview]
Message-ID: <52C6FED2.7070700@intel.com> (raw)
In-Reply-To: <20140103033303.GB4106@localhost.localdomain>

On 01/02/2014 07:33 PM, Han Pingtian wrote:
> @@ -130,8 +130,11 @@ static int set_recommended_min_free_kbytes(void)
>  			      (unsigned long) nr_free_buffer_pages() / 20);
>  	recommended_min <<= (PAGE_SHIFT-10);
>  
> -	if (recommended_min > min_free_kbytes)
> +	if (recommended_min > min_free_kbytes) {
> +		pr_info("raising min_free_kbytes from %d to %d to help transparent hugepage allocations\n",
> +			min_free_kbytes, recommended_min);
>  		min_free_kbytes = recommended_min;
> +	}
>  	setup_per_zone_wmarks();
>  	return 0;
>  }

I know I gave you that big bloated string, but 108 columns is a _wee_
bit over 80. :)

Otherwise, I do like the new message

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: linux-kernel@vger.kernel.org,
	Andrea Arcangeli <aarcange@redhat.com>,
	Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>
Subject: Re: [RFC] mm: show message when updating min_free_kbytes in thp
Date: Fri, 03 Jan 2014 10:17:54 -0800	[thread overview]
Message-ID: <52C6FED2.7070700@intel.com> (raw)
In-Reply-To: <20140103033303.GB4106@localhost.localdomain>

On 01/02/2014 07:33 PM, Han Pingtian wrote:
> @@ -130,8 +130,11 @@ static int set_recommended_min_free_kbytes(void)
>  			      (unsigned long) nr_free_buffer_pages() / 20);
>  	recommended_min <<= (PAGE_SHIFT-10);
>  
> -	if (recommended_min > min_free_kbytes)
> +	if (recommended_min > min_free_kbytes) {
> +		pr_info("raising min_free_kbytes from %d to %d to help transparent hugepage allocations\n",
> +			min_free_kbytes, recommended_min);
>  		min_free_kbytes = recommended_min;
> +	}
>  	setup_per_zone_wmarks();
>  	return 0;
>  }

I know I gave you that big bloated string, but 108 columns is a _wee_
bit over 80. :)

Otherwise, I do like the new message

  reply	other threads:[~2014-01-03 18:18 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-01  0:29 [RFC] mm: show message when updating min_free_kbytes in thp Han Pingtian
2014-01-01  0:29 ` Han Pingtian
2014-01-02 18:05 ` Dave Hansen
2014-01-02 18:05   ` Dave Hansen
2014-01-02 21:58   ` David Rientjes
2014-01-02 21:58     ` David Rientjes
2014-01-02 22:10     ` Dave Hansen
2014-01-02 22:10       ` Dave Hansen
2014-01-02 23:36       ` David Rientjes
2014-01-02 23:36         ` David Rientjes
2014-01-02 23:48         ` Dave Hansen
2014-01-02 23:48           ` Dave Hansen
2014-01-03  3:33   ` Han Pingtian
2014-01-03  3:33     ` Han Pingtian
2014-01-03 18:17     ` Dave Hansen [this message]
2014-01-03 18:17       ` Dave Hansen
2014-01-05  0:35       ` Han Pingtian
2014-01-05  0:35         ` Han Pingtian
2014-01-06 16:46         ` Michal Hocko
2014-01-06 16:46           ` Michal Hocko
2014-01-08  3:59           ` Han Pingtian
2014-01-08  3:59             ` Han Pingtian
2014-01-08  8:20           ` Han Pingtian
2014-01-08  8:20             ` Han Pingtian
2014-01-08 10:16             ` Michal Hocko
2014-01-08 10:16               ` Michal Hocko
2014-01-09  7:32               ` Han Pingtian
2014-01-09  7:32                 ` Han Pingtian
2014-01-09  9:02                 ` Michal Hocko
2014-01-09  9:02                   ` Michal Hocko
2014-01-09 21:15                 ` David Rientjes
2014-01-09 21:15                   ` David Rientjes
2014-01-10  8:05                   ` Michal Hocko
2014-01-10  8:05                     ` Michal Hocko
2014-01-10  8:13                     ` Andrew Morton
2014-01-10  8:13                       ` Andrew Morton
2014-01-10  8:17                       ` Michal Hocko
2014-01-10  8:17                         ` Michal Hocko
2014-01-11  3:27                         ` Han Pingtian
2014-01-11  3:27                           ` Han Pingtian
2014-01-14 20:07                         ` Han Pingtian
2014-01-14 20:07                           ` Han Pingtian
2014-01-14 23:52                           ` Andrew Morton
2014-01-14 23:52                             ` Andrew Morton
2014-01-15  0:25                             ` David Rientjes
2014-01-15  0:25                               ` David Rientjes
2014-01-15  0:35                               ` Andrew Morton
2014-01-15  0:35                                 ` Andrew Morton
2014-01-15  0:52                                 ` David Rientjes
2014-01-15  0:52                                   ` David Rientjes
2014-01-15 15:22                                 ` Mel Gorman
2014-01-15 15:22                                   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C6FED2.7070700@intel.com \
    --to=dave.hansen@intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.