From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: shmobile: Koelsch: Add QSPI support
Date: Mon, 06 Jan 2014 02:24:30 +0000 [thread overview]
Message-ID: <20140106022426.GD11231@verge.net.au> (raw)
In-Reply-To: <871u0mkkpg.wl%kuninori.morimoto.gx@gmail.com>
On Sun, Jan 05, 2014 at 04:39:14PM -0800, Kuninori Morimoto wrote:
> Hi
>
> > <sergei.shtylyov@cogentembedded.com> wrote:
> > >> + platform_device_register_resndata(&platform_bus, "qspi", 0,
> > >
> > > As I understood, there's single QSPI controller, so why you pass 0, and
> > > not -1 here?
> >
> > Indeed, there's only a single QSPI instance.
> > However, I choose to use "0" for consistency with Lager.
> > Mach-shmobile seems to use a mix of 0 and -1.
> >
> > If the maintainer prefers -1, I can change that.
>
> In SPI driver case, spi master will use dynamic
> bus_num value if ID was -1 (in spi_register_master()).
> Then, slave device can't be detected.
> So, ID = 0 is reasonable even though single QSPI.
When it makes sense I prefer -1, however, in this case it
seems that 0 is a better choice.
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: shmobile: Koelsch: Add QSPI support
Date: Mon, 6 Jan 2014 11:24:30 +0900 [thread overview]
Message-ID: <20140106022426.GD11231@verge.net.au> (raw)
In-Reply-To: <871u0mkkpg.wl%kuninori.morimoto.gx@gmail.com>
On Sun, Jan 05, 2014 at 04:39:14PM -0800, Kuninori Morimoto wrote:
> Hi
>
> > <sergei.shtylyov@cogentembedded.com> wrote:
> > >> + platform_device_register_resndata(&platform_bus, "qspi", 0,
> > >
> > > As I understood, there's single QSPI controller, so why you pass 0, and
> > > not -1 here?
> >
> > Indeed, there's only a single QSPI instance.
> > However, I choose to use "0" for consistency with Lager.
> > Mach-shmobile seems to use a mix of 0 and -1.
> >
> > If the maintainer prefers -1, I can change that.
>
> In SPI driver case, spi master will use dynamic
> bus_num value if ID was -1 (in spi_register_master()).
> Then, slave device can't be detected.
> So, ID = 0 is reasonable even though single QSPI.
When it makes sense I prefer -1, however, in this case it
seems that 0 is a better choice.
next prev parent reply other threads:[~2014-01-06 2:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 15:34 [PATCH 0/3] Add QSPI support on r8a7791/koelsch Geert Uytterhoeven
2014-01-03 15:34 ` Geert Uytterhoeven
2014-01-03 15:34 ` [PATCH 1/3] pinctrl: sh-pfc: r8a7791: Add QSPI pin groups Geert Uytterhoeven
2014-01-03 15:34 ` Geert Uytterhoeven
2014-01-07 14:58 ` Laurent Pinchart
2014-01-07 14:58 ` Laurent Pinchart
2014-01-07 19:53 ` Geert Uytterhoeven
2014-01-07 19:53 ` Geert Uytterhoeven
2014-01-03 15:34 ` [PATCH 2/3] ARM: shmobile: r8a7791: add QSPI clock Geert Uytterhoeven
2014-01-03 15:34 ` Geert Uytterhoeven
2014-01-03 15:34 ` [PATCH 3/3] ARM: shmobile: Koelsch: Add QSPI support Geert Uytterhoeven
2014-01-03 15:34 ` Geert Uytterhoeven
2014-01-03 15:51 ` Sergei Shtylyov
2014-01-03 16:51 ` Sergei Shtylyov
2014-01-03 16:07 ` Geert Uytterhoeven
2014-01-03 16:07 ` Geert Uytterhoeven
2014-01-06 0:39 ` Kuninori Morimoto
2014-01-06 0:39 ` Kuninori Morimoto
2014-01-06 2:24 ` Simon Horman [this message]
2014-01-06 2:24 ` Simon Horman
2014-01-07 1:20 ` [PATCH 0/3] Add QSPI support on r8a7791/koelsch Simon Horman
2014-01-07 1:20 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106022426.GD11231@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.