From: Josh Triplett <josh@joshtriplett.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Rashika Kheria <rashika.kheria@gmail.com>,
linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h
Date: Sun, 5 Jan 2014 19:28:49 -0800 [thread overview]
Message-ID: <20140106032849.GA20605@leaf> (raw)
In-Reply-To: <1528697.GH1GrQaKgp@vostro.rjw.lan>
On Mon, Jan 06, 2014 at 12:33:57AM +0100, Rafael J. Wysocki wrote:
> On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote:
> > Include header file internal.h in debugfs.c and change the return
> > value's type in header file internal.h.
> >
> > This eliminates the following warning in debugfs.c:
> > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> > drivers/acpi/debugfs.c | 3 +++
> > drivers/acpi/internal.h | 2 +-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
> > index b55d6a2..96bcaf7 100644
> > --- a/drivers/acpi/debugfs.c
> > +++ b/drivers/acpi/debugfs.c
> > @@ -6,6 +6,7 @@
> > #include <linux/init.h>
> > #include <linux/debugfs.h>
> > #include <acpi/acpi_drivers.h>
> > +#include "internal.h"
> >
> > #define _COMPONENT ACPI_SYSTEM_COMPONENT
> > ACPI_MODULE_NAME("debugfs");
> > @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
> > struct dentry *acpi_debugfs_dir;
> > EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
> >
> > +#ifdef CONFIG_DEBUG_FS
> > void __init acpi_debugfs_init(void)
> > {
> > acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
> > }
> > +#endif
>
> What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset?
>
> That surely would make sense?
It exports the symbol acpi_debugfs_dir, which is used unconditionally.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Josh Triplett <josh@joshtriplett.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Rashika Kheria <rashika.kheria@gmail.com>,
linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h
Date: Sun, 5 Jan 2014 19:28:49 -0800 [thread overview]
Message-ID: <20140106032849.GA20605@leaf> (raw)
In-Reply-To: <1528697.GH1GrQaKgp@vostro.rjw.lan>
On Mon, Jan 06, 2014 at 12:33:57AM +0100, Rafael J. Wysocki wrote:
> On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote:
> > Include header file internal.h in debugfs.c and change the return
> > value's type in header file internal.h.
> >
> > This eliminates the following warning in debugfs.c:
> > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> > drivers/acpi/debugfs.c | 3 +++
> > drivers/acpi/internal.h | 2 +-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
> > index b55d6a2..96bcaf7 100644
> > --- a/drivers/acpi/debugfs.c
> > +++ b/drivers/acpi/debugfs.c
> > @@ -6,6 +6,7 @@
> > #include <linux/init.h>
> > #include <linux/debugfs.h>
> > #include <acpi/acpi_drivers.h>
> > +#include "internal.h"
> >
> > #define _COMPONENT ACPI_SYSTEM_COMPONENT
> > ACPI_MODULE_NAME("debugfs");
> > @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
> > struct dentry *acpi_debugfs_dir;
> > EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
> >
> > +#ifdef CONFIG_DEBUG_FS
> > void __init acpi_debugfs_init(void)
> > {
> > acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
> > }
> > +#endif
>
> What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset?
>
> That surely would make sense?
It exports the symbol acpi_debugfs_dir, which is used unconditionally.
- Josh Triplett
next prev parent reply other threads:[~2014-01-06 3:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 9:11 [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c Rashika Kheria
2013-12-17 9:15 ` [PATCH 02/11] drivers: acpi: Include appropriate header file in nvs.c Rashika Kheria
2013-12-17 9:15 ` Rashika Kheria
2013-12-17 9:16 ` [PATCH 03/11] drivers: acpi: Mark the function acpi_ec_add_debugfs() as static in ec_sys.c Rashika Kheria
2013-12-17 9:16 ` Rashika Kheria
2013-12-17 9:18 ` [PATCH 04/11] drivers: acpi: Include appropriate header file in pci_slot.c Rashika Kheria
2013-12-17 9:21 ` [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c Rashika Kheria
2013-12-17 17:35 ` [Devel] " Moore, Robert
2013-12-17 17:35 ` Moore, Robert
2013-12-17 17:35 ` Moore, Robert
2013-12-17 20:25 ` Josh Triplett
2013-12-17 20:25 ` Josh Triplett
2013-12-18 1:08 ` Rafael J. Wysocki
2013-12-18 1:08 ` Rafael J. Wysocki
2013-12-18 6:17 ` [Devel] " Zheng, Lv
2013-12-18 6:17 ` Zheng, Lv
2013-12-18 6:17 ` Zheng, Lv
2013-12-30 20:50 ` Josh Triplett
2013-12-17 9:24 ` [PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c Rashika Kheria
2013-12-17 9:24 ` Rashika Kheria
2013-12-17 9:28 ` [PATCH 07/11] drivers: acpi: Include appropriate header file in pci_link.c Rashika Kheria
2013-12-17 9:30 ` [PATCH 08/11] drivers: acpi: Include appropriate header file in dock.c Rashika Kheria
2013-12-17 9:30 ` Rashika Kheria
2013-12-17 9:32 ` [PATCH 09/11] drivers: acpi: Remove unused function in ec.c and add prototype declaration in header file internal.h Rashika Kheria
2013-12-17 9:34 ` [PATCH 10/11] drivers: acpi: Include appropriate header file in proc.c Rashika Kheria
2013-12-17 9:34 ` Rashika Kheria
2013-12-17 9:36 ` [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h Rashika Kheria
2013-12-17 9:36 ` Rashika Kheria
2014-01-05 23:33 ` Rafael J. Wysocki
2014-01-05 23:33 ` Rafael J. Wysocki
2014-01-06 3:28 ` Josh Triplett [this message]
2014-01-06 3:28 ` Josh Triplett
2014-01-06 11:17 ` Rafael J. Wysocki
2014-01-06 11:17 ` Rafael J. Wysocki
2014-01-05 23:30 ` [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c Rafael J. Wysocki
2014-01-05 23:30 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2013-12-18 6:31 [Devel] [PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c Zheng, Lv
2013-12-18 6:31 ` Zheng, Lv
2013-12-18 6:31 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106032849.GA20605@leaf \
--to=josh@joshtriplett.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.