All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c
@ 2013-12-17  9:11 Rashika Kheria
  2013-12-17  9:15   ` Rashika Kheria
                   ` (10 more replies)
  0 siblings, 11 replies; 39+ messages in thread
From: Rashika Kheria @ 2013-12-17  9:11 UTC (permalink / raw)
  To: linux-kernel

Marks the function acpi_table_checksum() as static in osl.c
because it is not used outside this file.

This eliminates the following warning in osl.c:
drivers/acpi/osl.c:547:11: warning: no previous prototype for ‘acpi_table_checksum’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/osl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 54a20ff..1f4c104 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -544,7 +544,7 @@ static u64 acpi_tables_addr;
 static int all_tables_size;
 
 /* Copied from acpica/tbutils.c:acpi_tb_checksum() */
-u8 __init acpi_table_checksum(u8 *buffer, u32 length)
+static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
 {
 	u8 sum = 0;
 	u8 *end = buffer + length;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 39+ messages in thread
* Re: [Devel] [PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c
  2013-12-17  9:24   ` Rashika Kheria
  (?)
@ 2013-12-18  6:31 ` Zheng, Lv
  -1 siblings, 0 replies; 39+ messages in thread
From: Zheng, Lv @ 2013-12-18  6:31 UTC (permalink / raw)
  To: devel

[-- Attachment #1: Type: text/plain, Size: 3593 bytes --]

Hi,

I think this patch is useless.
It is possible to include dump code into Linux kernel for debugging purposes.
Thus we should do cleanup in different way for them.

Thanks
-Lv

> From: Rashika Kheria [mailto:rashika.kheria(a)gmail.com]
> Sent: Tuesday, December 17, 2013 5:24 PM
> 
> Enclose functions acpi_ex_dump_namespace_node() and
> acpi_ex_dump_object_descriptor() in appropriate ifdef condition of
> ACPI_FUTURE_USAGE in file acpica/exdump.c.
> 
> This eliminates the following warnings in exdump.c:
> drivers/acpi/acpica/exdump.c:809:6: warning: no previous prototype for ‘acpi_ex_dump_namespace_node’ [-Wmissing-prototypes]
> drivers/acpi/acpica/exdump.c:995:1: warning: no previous prototype for ‘acpi_ex_dump_object_descriptor’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria(a)gmail.com>
> Reviewed-by: Josh Triplett <josh(a)joshtriplett.org>
> ---
>  drivers/acpi/acpica/exdump.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
> index 4d046fa..3cd2817 100644
> --- a/drivers/acpi/acpica/exdump.c
> +++ b/drivers/acpi/acpica/exdump.c
> @@ -54,6 +54,7 @@ ACPI_MODULE_NAME("exdump")
>   * The following routines are used for debug output only
>   */
>  #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
> +#ifdef  ACPI_FUTURE_USAGE
>  /* Local prototypes */
>  static void acpi_ex_out_string(char *title, char *value);
> 
> @@ -68,6 +69,7 @@ static void acpi_ex_dump_reference_obj(union acpi_operand_object *obj_desc);
>  static void
>  acpi_ex_dump_package_obj(union acpi_operand_object *obj_desc,
>  			 u32 level, u32 index);
> +#endif
> 
>  /*******************************************************************************
>   *
> @@ -210,6 +212,7 @@ static struct acpi_exdump_info acpi_ex_dump_bank_field[5] = {
>  	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(bank_field.bank_obj), "Bank Object"}
>  };
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
>  	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_bank_field), NULL},
>  	{ACPI_EXD_FIELD, 0, NULL},
> @@ -218,6 +221,7 @@ static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
>  	 "Index Object"},
>  	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(index_field.data_obj), "Data Object"}
>  };
> +#endif
> 
>  static struct acpi_exdump_info acpi_ex_dump_reference[8] = {
>  	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_reference), NULL},
> @@ -287,6 +291,7 @@ static struct acpi_exdump_info acpi_ex_dump_node[5] = {
> 
>  /* Dispatch table, indexed by object type */
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static struct acpi_exdump_info *acpi_ex_dump_info[] = {
>  	NULL,
>  	acpi_ex_dump_integer,
> @@ -444,6 +449,7 @@ acpi_ex_dump_object(union acpi_operand_object *obj_desc,
>  		count--;
>  	}
>  }
> +#endif
> 
>  /*******************************************************************************
>   *
> @@ -785,6 +791,7 @@ acpi_ex_dump_operands(union acpi_operand_object **operands,
>   *
>   ******************************************************************************/
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static void acpi_ex_out_string(char *title, char *value)
>  {
>  	acpi_os_printf("%20s : %s\n", title, value);
> @@ -1042,5 +1049,6 @@ acpi_ex_dump_object_descriptor(union acpi_operand_object *obj_desc, u32 flags)
>  	acpi_ex_dump_object(obj_desc, acpi_ex_dump_info[obj_desc->common.type]);
>  	return_VOID;
>  }
> +#endif
> 
>  #endif
> --
> 1.7.9.5


^ permalink raw reply	[flat|nested] 39+ messages in thread
end of thread, other threads:[~2014-01-06 11:04 UTC | newest]

Thread overview: 39+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17  9:11 [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c Rashika Kheria
2013-12-17  9:15 ` [PATCH 02/11] drivers: acpi: Include appropriate header file in nvs.c Rashika Kheria
2013-12-17  9:15   ` Rashika Kheria
2013-12-17  9:16 ` [PATCH 03/11] drivers: acpi: Mark the function acpi_ec_add_debugfs() as static in ec_sys.c Rashika Kheria
2013-12-17  9:16   ` Rashika Kheria
2013-12-17  9:18 ` [PATCH 04/11] drivers: acpi: Include appropriate header file in pci_slot.c Rashika Kheria
2013-12-17  9:21 ` [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c Rashika Kheria
2013-12-17 17:35   ` [Devel] " Moore, Robert
2013-12-17 17:35     ` Moore, Robert
2013-12-17 17:35     ` Moore, Robert
2013-12-17 20:25     ` Josh Triplett
2013-12-17 20:25       ` Josh Triplett
2013-12-18  1:08       ` Rafael J. Wysocki
2013-12-18  1:08         ` Rafael J. Wysocki
2013-12-18  6:17     ` [Devel] " Zheng, Lv
2013-12-18  6:17       ` Zheng, Lv
2013-12-18  6:17       ` Zheng, Lv
2013-12-30 20:50       ` Josh Triplett
2013-12-17  9:24 ` [PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c Rashika Kheria
2013-12-17  9:24   ` Rashika Kheria
2013-12-17  9:28 ` [PATCH 07/11] drivers: acpi: Include appropriate header file in pci_link.c Rashika Kheria
2013-12-17  9:30 ` [PATCH 08/11] drivers: acpi: Include appropriate header file in dock.c Rashika Kheria
2013-12-17  9:30   ` Rashika Kheria
2013-12-17  9:32 ` [PATCH 09/11] drivers: acpi: Remove unused function in ec.c and add prototype declaration in header file internal.h Rashika Kheria
2013-12-17  9:34 ` [PATCH 10/11] drivers: acpi: Include appropriate header file in proc.c Rashika Kheria
2013-12-17  9:34   ` Rashika Kheria
2013-12-17  9:36 ` [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h Rashika Kheria
2013-12-17  9:36   ` Rashika Kheria
2014-01-05 23:33   ` Rafael J. Wysocki
2014-01-05 23:33     ` Rafael J. Wysocki
2014-01-06  3:28     ` Josh Triplett
2014-01-06  3:28       ` Josh Triplett
2014-01-06 11:17       ` Rafael J. Wysocki
2014-01-06 11:17         ` Rafael J. Wysocki
2014-01-05 23:30 ` [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c Rafael J. Wysocki
2014-01-05 23:30   ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2013-12-18  6:31 [Devel] [PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c Zheng, Lv
2013-12-18  6:31 ` Zheng, Lv
2013-12-18  6:31 ` Zheng, Lv

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.