Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU

[Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>]

On Wed, Jan 08, 2014 at 08:23:49AM -0500, Rob Clark wrote:
> On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> wrote:
> > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote:
> >> The DRM driver for MSM depends on symbols from the MSM
> >> IOMMU driver. Add this dependency to the Kconfig file.
> >>
> >> Fixes this comile error:
> >>
> >>   Kernel: arch/arm/boot/zImage is ready
> >>   ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko]
> >>   undefined!
> >>   make[2]: *** [__modpost] Error 1
> 
> Thanks, I'll pull this into my pull req for 3.14 drm-next.. although,
> after chatting with Stephen Boyd, I think we should eventually be able
> to get rid of this (seems msm_iommu_get_ctx() was mainly for dealing
> with secure playback (?))

It is already in my next-branch. So if you are ok with the approach for
now there is no need for action. If you want it to go through your tree
anyway please let me know and I will drop it from mine.


	Joerg