* [PATCH] drm/msm: Fix link error with !MSM_IOMMU @ 2014-01-07 22:47 ` Joerg Roedel 0 siblings, 0 replies; 10+ messages in thread From: Joerg Roedel @ 2014-01-07 22:47 UTC (permalink / raw) To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Rob Clark The DRM driver for MSM depends on symbols from the MSM IOMMU driver. Add this dependency to the Kconfig file. Fixes this comile error: Kernel: arch/arm/boot/zImage is ready ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] undefined! make[2]: *** [__modpost] Error 1 Cc: Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Signed-off-by: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> --- drivers/gpu/drm/msm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index f39ab75..d3de8e1 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -4,6 +4,7 @@ config DRM_MSM depends on DRM depends on ARCH_MSM depends on ARCH_MSM8960 + depends on MSM_IOMMU select DRM_KMS_HELPER select SHMEM select TMPFS -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] drm/msm: Fix link error with !MSM_IOMMU @ 2014-01-07 22:47 ` Joerg Roedel 0 siblings, 0 replies; 10+ messages in thread From: Joerg Roedel @ 2014-01-07 22:47 UTC (permalink / raw) To: iommu, linux-kernel; +Cc: Rob Clark, Joerg Roedel The DRM driver for MSM depends on symbols from the MSM IOMMU driver. Add this dependency to the Kconfig file. Fixes this comile error: Kernel: arch/arm/boot/zImage is ready ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] undefined! make[2]: *** [__modpost] Error 1 Cc: Rob Clark <robdclark@gmail.com> Signed-off-by: Joerg Roedel <joro@8bytes.org> --- drivers/gpu/drm/msm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index f39ab75..d3de8e1 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -4,6 +4,7 @@ config DRM_MSM depends on DRM depends on ARCH_MSM depends on ARCH_MSM8960 + depends on MSM_IOMMU select DRM_KMS_HELPER select SHMEM select TMPFS -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
[parent not found: <1389134846-1000-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU 2014-01-07 22:47 ` Joerg Roedel @ 2014-01-07 22:53 ` Joerg Roedel -1 siblings, 0 replies; 10+ messages in thread From: Joerg Roedel @ 2014-01-07 22:53 UTC (permalink / raw) To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Rob Clark On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: > The DRM driver for MSM depends on symbols from the MSM > IOMMU driver. Add this dependency to the Kconfig file. > > Fixes this comile error: > > Kernel: arch/arm/boot/zImage is ready > ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] > undefined! > make[2]: *** [__modpost] Error 1 > > Cc: Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > Signed-off-by: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> > --- > drivers/gpu/drm/msm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > index f39ab75..d3de8e1 100644 > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -4,6 +4,7 @@ config DRM_MSM > depends on DRM > depends on ARCH_MSM > depends on ARCH_MSM8960 > + depends on MSM_IOMMU > select DRM_KMS_HELPER > select SHMEM > select TMPFS FYI, I put the patch to my arm/msm branch meanwhile to get the build error fixed. Please let me know when there is another solution merged and I will drop it. Joerg ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU @ 2014-01-07 22:53 ` Joerg Roedel 0 siblings, 0 replies; 10+ messages in thread From: Joerg Roedel @ 2014-01-07 22:53 UTC (permalink / raw) To: iommu, linux-kernel; +Cc: Rob Clark On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: > The DRM driver for MSM depends on symbols from the MSM > IOMMU driver. Add this dependency to the Kconfig file. > > Fixes this comile error: > > Kernel: arch/arm/boot/zImage is ready > ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] > undefined! > make[2]: *** [__modpost] Error 1 > > Cc: Rob Clark <robdclark@gmail.com> > Signed-off-by: Joerg Roedel <joro@8bytes.org> > --- > drivers/gpu/drm/msm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > index f39ab75..d3de8e1 100644 > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -4,6 +4,7 @@ config DRM_MSM > depends on DRM > depends on ARCH_MSM > depends on ARCH_MSM8960 > + depends on MSM_IOMMU > select DRM_KMS_HELPER > select SHMEM > select TMPFS FYI, I put the patch to my arm/msm branch meanwhile to get the build error fixed. Please let me know when there is another solution merged and I will drop it. Joerg ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <20140107225345.GE29041-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU 2014-01-07 22:53 ` Joerg Roedel @ 2014-01-08 13:23 ` Rob Clark -1 siblings, 0 replies; 10+ messages in thread From: Rob Clark @ 2014-01-08 13:23 UTC (permalink / raw) To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Linux Kernel Mailing List On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> wrote: > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: >> The DRM driver for MSM depends on symbols from the MSM >> IOMMU driver. Add this dependency to the Kconfig file. >> >> Fixes this comile error: >> >> Kernel: arch/arm/boot/zImage is ready >> ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] >> undefined! >> make[2]: *** [__modpost] Error 1 Thanks, I'll pull this into my pull req for 3.14 drm-next.. although, after chatting with Stephen Boyd, I think we should eventually be able to get rid of this (seems msm_iommu_get_ctx() was mainly for dealing with secure playback (?)) BR, -R >> >> Cc: Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> Signed-off-by: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> >> --- >> drivers/gpu/drm/msm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig >> index f39ab75..d3de8e1 100644 >> --- a/drivers/gpu/drm/msm/Kconfig >> +++ b/drivers/gpu/drm/msm/Kconfig >> @@ -4,6 +4,7 @@ config DRM_MSM >> depends on DRM >> depends on ARCH_MSM >> depends on ARCH_MSM8960 >> + depends on MSM_IOMMU >> select DRM_KMS_HELPER >> select SHMEM >> select TMPFS > > FYI, I put the patch to my arm/msm branch meanwhile to get the build > error fixed. Please let me know when there is another solution merged > and I will drop it. > > > Joerg > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU @ 2014-01-08 13:23 ` Rob Clark 0 siblings, 0 replies; 10+ messages in thread From: Rob Clark @ 2014-01-08 13:23 UTC (permalink / raw) To: Joerg Roedel; +Cc: iommu, Linux Kernel Mailing List On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel <joro@8bytes.org> wrote: > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: >> The DRM driver for MSM depends on symbols from the MSM >> IOMMU driver. Add this dependency to the Kconfig file. >> >> Fixes this comile error: >> >> Kernel: arch/arm/boot/zImage is ready >> ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] >> undefined! >> make[2]: *** [__modpost] Error 1 Thanks, I'll pull this into my pull req for 3.14 drm-next.. although, after chatting with Stephen Boyd, I think we should eventually be able to get rid of this (seems msm_iommu_get_ctx() was mainly for dealing with secure playback (?)) BR, -R >> >> Cc: Rob Clark <robdclark@gmail.com> >> Signed-off-by: Joerg Roedel <joro@8bytes.org> >> --- >> drivers/gpu/drm/msm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig >> index f39ab75..d3de8e1 100644 >> --- a/drivers/gpu/drm/msm/Kconfig >> +++ b/drivers/gpu/drm/msm/Kconfig >> @@ -4,6 +4,7 @@ config DRM_MSM >> depends on DRM >> depends on ARCH_MSM >> depends on ARCH_MSM8960 >> + depends on MSM_IOMMU >> select DRM_KMS_HELPER >> select SHMEM >> select TMPFS > > FYI, I put the patch to my arm/msm branch meanwhile to get the build > error fixed. Please let me know when there is another solution merged > and I will drop it. > > > Joerg > > ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <CAF6AEGtHR9-oy+xaZM2bbJHnqhrwHiZeAC+asc7+Ds0x_hJeNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU 2014-01-08 13:23 ` Rob Clark @ 2014-01-08 13:35 ` Joerg Roedel -1 siblings, 0 replies; 10+ messages in thread From: Joerg Roedel @ 2014-01-08 13:35 UTC (permalink / raw) To: Rob Clark Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Linux Kernel Mailing List On Wed, Jan 08, 2014 at 08:23:49AM -0500, Rob Clark wrote: > On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> wrote: > > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: > >> The DRM driver for MSM depends on symbols from the MSM > >> IOMMU driver. Add this dependency to the Kconfig file. > >> > >> Fixes this comile error: > >> > >> Kernel: arch/arm/boot/zImage is ready > >> ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] > >> undefined! > >> make[2]: *** [__modpost] Error 1 > > Thanks, I'll pull this into my pull req for 3.14 drm-next.. although, > after chatting with Stephen Boyd, I think we should eventually be able > to get rid of this (seems msm_iommu_get_ctx() was mainly for dealing > with secure playback (?)) It is already in my next-branch. So if you are ok with the approach for now there is no need for action. If you want it to go through your tree anyway please let me know and I will drop it from mine. Joerg ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU @ 2014-01-08 13:35 ` Joerg Roedel 0 siblings, 0 replies; 10+ messages in thread From: Joerg Roedel @ 2014-01-08 13:35 UTC (permalink / raw) To: Rob Clark; +Cc: iommu, Linux Kernel Mailing List On Wed, Jan 08, 2014 at 08:23:49AM -0500, Rob Clark wrote: > On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel <joro@8bytes.org> wrote: > > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: > >> The DRM driver for MSM depends on symbols from the MSM > >> IOMMU driver. Add this dependency to the Kconfig file. > >> > >> Fixes this comile error: > >> > >> Kernel: arch/arm/boot/zImage is ready > >> ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] > >> undefined! > >> make[2]: *** [__modpost] Error 1 > > Thanks, I'll pull this into my pull req for 3.14 drm-next.. although, > after chatting with Stephen Boyd, I think we should eventually be able > to get rid of this (seems msm_iommu_get_ctx() was mainly for dealing > with secure playback (?)) It is already in my next-branch. So if you are ok with the approach for now there is no need for action. If you want it to go through your tree anyway please let me know and I will drop it from mine. Joerg ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <20140108133514.GG29041-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU 2014-01-08 13:35 ` Joerg Roedel @ 2014-01-08 19:53 ` Rob Clark -1 siblings, 0 replies; 10+ messages in thread From: Rob Clark @ 2014-01-08 19:53 UTC (permalink / raw) To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Linux Kernel Mailing List On Wed, Jan 8, 2014 at 8:35 AM, Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> wrote: > On Wed, Jan 08, 2014 at 08:23:49AM -0500, Rob Clark wrote: >> On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> wrote: >> > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: >> >> The DRM driver for MSM depends on symbols from the MSM >> >> IOMMU driver. Add this dependency to the Kconfig file. >> >> >> >> Fixes this comile error: >> >> >> >> Kernel: arch/arm/boot/zImage is ready >> >> ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] >> >> undefined! >> >> make[2]: *** [__modpost] Error 1 >> >> Thanks, I'll pull this into my pull req for 3.14 drm-next.. although, >> after chatting with Stephen Boyd, I think we should eventually be able >> to get rid of this (seems msm_iommu_get_ctx() was mainly for dealing >> with secure playback (?)) > > It is already in my next-branch. So if you are ok with the approach for > now there is no need for action. If you want it to go through your tree > anyway please let me know and I will drop it from mine. probably will be a slight merge conflict if it goes through your branch.. although should be easy enough to resolve, basically the result should look something like: depends on (ARCH_MSM && ARCH_MSM8960 && MSM_IOMMU) || (ARM && COMPILE_TEST) BR, -R > > Joerg > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU @ 2014-01-08 19:53 ` Rob Clark 0 siblings, 0 replies; 10+ messages in thread From: Rob Clark @ 2014-01-08 19:53 UTC (permalink / raw) To: Joerg Roedel; +Cc: iommu, Linux Kernel Mailing List On Wed, Jan 8, 2014 at 8:35 AM, Joerg Roedel <joro@8bytes.org> wrote: > On Wed, Jan 08, 2014 at 08:23:49AM -0500, Rob Clark wrote: >> On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel <joro@8bytes.org> wrote: >> > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: >> >> The DRM driver for MSM depends on symbols from the MSM >> >> IOMMU driver. Add this dependency to the Kconfig file. >> >> >> >> Fixes this comile error: >> >> >> >> Kernel: arch/arm/boot/zImage is ready >> >> ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] >> >> undefined! >> >> make[2]: *** [__modpost] Error 1 >> >> Thanks, I'll pull this into my pull req for 3.14 drm-next.. although, >> after chatting with Stephen Boyd, I think we should eventually be able >> to get rid of this (seems msm_iommu_get_ctx() was mainly for dealing >> with secure playback (?)) > > It is already in my next-branch. So if you are ok with the approach for > now there is no need for action. If you want it to go through your tree > anyway please let me know and I will drop it from mine. probably will be a slight merge conflict if it goes through your branch.. although should be easy enough to resolve, basically the result should look something like: depends on (ARCH_MSM && ARCH_MSM8960 && MSM_IOMMU) || (ARM && COMPILE_TEST) BR, -R > > Joerg > > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-01-08 19:53 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-07 22:47 [PATCH] drm/msm: Fix link error with !MSM_IOMMU Joerg Roedel
2014-01-07 22:47 ` Joerg Roedel
[not found] ` <1389134846-1000-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-01-07 22:53 ` Joerg Roedel
2014-01-07 22:53 ` Joerg Roedel
[not found] ` <20140107225345.GE29041-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-01-08 13:23 ` Rob Clark
2014-01-08 13:23 ` Rob Clark
[not found] ` <CAF6AEGtHR9-oy+xaZM2bbJHnqhrwHiZeAC+asc7+Ds0x_hJeNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-08 13:35 ` Joerg Roedel
2014-01-08 13:35 ` Joerg Roedel
[not found] ` <20140108133514.GG29041-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-01-08 19:53 ` Rob Clark
2014-01-08 19:53 ` Rob Clark
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.