All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: devicetree@vger.kernel.org, Ashok Raj <ashok.raj@intel.com>,
	Rob Herring <robh@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs
Date: Wed, 8 Jan 2014 12:28:26 -0800	[thread overview]
Message-ID: <20140108202826.GF8417@kroah.com> (raw)
In-Reply-To: <1389209168-17189-2-git-send-email-sudeep.holla@arm.com>

On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:
> From: Sudeep Holla <sudeep.holla@arm.com>
> +#define define_one_ro(_name) \
> +static struct cache_attr _name = \
> +	__ATTR(_name, 0444, show_##_name, NULL)

In the future, we do have __ATTR_RO(), which should be used instead.
You should never use __ATTR() on it's own, if at all possible.  I'm
sweeping the tree for all usages and fixing them slowly up over time.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs
Date: Wed, 8 Jan 2014 12:28:26 -0800	[thread overview]
Message-ID: <20140108202826.GF8417@kroah.com> (raw)
In-Reply-To: <1389209168-17189-2-git-send-email-sudeep.holla@arm.com>

On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:
> From: Sudeep Holla <sudeep.holla@arm.com>
> +#define define_one_ro(_name) \
> +static struct cache_attr _name = \
> +	__ATTR(_name, 0444, show_##_name, NULL)

In the future, we do have __ATTR_RO(), which should be used instead.
You should never use __ATTR() on it's own, if at all possible.  I'm
sweeping the tree for all usages and fixing them slowly up over time.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
Cc: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Ashok Raj <ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Benjamin Herrenschmidt
	<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
	Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs
Date: Wed, 8 Jan 2014 12:28:26 -0800	[thread overview]
Message-ID: <20140108202826.GF8417@kroah.com> (raw)
In-Reply-To: <1389209168-17189-2-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>

On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:
> From: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
> +#define define_one_ro(_name) \
> +static struct cache_attr _name = \
> +	__ATTR(_name, 0444, show_##_name, NULL)

In the future, we do have __ATTR_RO(), which should be used instead.
You should never use __ATTR() on it's own, if at all possible.  I'm
sweeping the tree for all usages and fixing them slowly up over time.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: x86@kernel.org, linuxppc-dev@lists.ozlabs.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Ashok Raj <ashok.raj@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs
Date: Wed, 8 Jan 2014 12:28:26 -0800	[thread overview]
Message-ID: <20140108202826.GF8417@kroah.com> (raw)
In-Reply-To: <1389209168-17189-2-git-send-email-sudeep.holla@arm.com>

On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:
> From: Sudeep Holla <sudeep.holla@arm.com>
> +#define define_one_ro(_name) \
> +static struct cache_attr _name = \
> +	__ATTR(_name, 0444, show_##_name, NULL)

In the future, we do have __ATTR_RO(), which should be used instead.
You should never use __ATTR() on it's own, if at all possible.  I'm
sweeping the tree for all usages and fixing them slowly up over time.

thanks,

greg k-h

  parent reply	other threads:[~2014-01-08 20:27 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 19:26 [PATCH RFC 0/3] drivers: cacheinfo support Sudeep Holla
2014-01-08 19:26 ` Sudeep Holla
2014-01-08 19:26 ` Sudeep Holla
2014-01-08 19:26 ` [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs Sudeep Holla
2014-01-08 19:26   ` Sudeep Holla
2014-01-08 20:26   ` Greg Kroah-Hartman
2014-01-08 20:26     ` Greg Kroah-Hartman
2014-01-08 20:26     ` Greg Kroah-Hartman
2014-01-08 20:26     ` Greg Kroah-Hartman
2014-01-09 19:07     ` Sudeep Holla
2014-01-09 19:07       ` Sudeep Holla
2014-01-09 19:07       ` Sudeep Holla
2014-01-09 19:07       ` Sudeep Holla
2014-01-08 20:27   ` Greg Kroah-Hartman
2014-01-08 20:27     ` Greg Kroah-Hartman
2014-01-08 20:27     ` Greg Kroah-Hartman
2014-01-09 19:19     ` Sudeep Holla
2014-01-09 19:19       ` Sudeep Holla
2014-01-09 19:19       ` Sudeep Holla
2014-01-09 19:19       ` Sudeep Holla
2014-01-09 19:31       ` Greg Kroah-Hartman
2014-01-09 19:31         ` Greg Kroah-Hartman
2014-01-09 19:31         ` Greg Kroah-Hartman
2014-01-09 19:31         ` Greg Kroah-Hartman
2014-01-09 19:47         ` Sudeep Holla
2014-01-09 19:47           ` Sudeep Holla
2014-01-09 19:47           ` Sudeep Holla
2014-01-09 19:47           ` Sudeep Holla
2014-01-09 20:03           ` Greg Kroah-Hartman
2014-01-09 20:03             ` Greg Kroah-Hartman
2014-01-09 20:03             ` Greg Kroah-Hartman
2014-01-09 20:03             ` Greg Kroah-Hartman
2014-01-08 20:28   ` Greg Kroah-Hartman [this message]
2014-01-08 20:28     ` Greg Kroah-Hartman
2014-01-08 20:28     ` Greg Kroah-Hartman
2014-01-08 20:28     ` Greg Kroah-Hartman
2014-01-09 19:07     ` Sudeep Holla
2014-01-09 19:07       ` Sudeep Holla
2014-01-09 19:07       ` Sudeep Holla
2014-01-09 19:07       ` Sudeep Holla
2014-01-08 19:26 ` [PATCH RFC 2/3] ARM: kernel: add support for cpu cache information Sudeep Holla
2014-01-08 19:26   ` Sudeep Holla
2014-01-08 19:26   ` Sudeep Holla
2014-01-08 20:57   ` Russell King - ARM Linux
2014-01-08 20:57     ` Russell King - ARM Linux
2014-01-08 20:57     ` Russell King - ARM Linux
2014-01-08 20:57     ` Russell King - ARM Linux
2014-01-09 19:35     ` Sudeep Holla
2014-01-09 19:35       ` Sudeep Holla
2014-01-09 19:35       ` Sudeep Holla
2014-01-09 19:35       ` Sudeep Holla
2014-01-09 20:08       ` Russell King - ARM Linux
2014-01-09 20:08         ` Russell King - ARM Linux
2014-01-09 20:08         ` Russell King - ARM Linux
2014-01-08 19:26 ` [PATCH RFC 3/3] ARM: kernel: add outer cache support for cacheinfo implementation Sudeep Holla
2014-01-08 19:26   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140108202826.GF8417@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ashok.raj@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.