All of lore.kernel.org
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx6q: Add missing esai_ahb clock to current clock tree
Date: Thu, 9 Jan 2014 08:55:26 +0100	[thread overview]
Message-ID: <20140109075525.GO6750@pengutronix.de> (raw)
In-Reply-To: <1389236699-10387-1-git-send-email-Guangyu.Chen@freescale.com>

[Added Mike Turquette to Cc]

On Thu, Jan 09, 2014 at 11:04:59AM +0800, Nicolin Chen wrote:
> esai_ahb clock is derived from ahb and used to provide ESAI the capability of
> register accessing and FSYS clock source for I2S clocks dividing. Although the
> gate of this esai_ahb is duplicated with esai clock -- the baud clock, yet
> considering about the differences of their clock rates, it's quite essential
> to patch this missing clock.
> 

[...]

>  static struct clk *clk[clk_max];
> @@ -355,6 +355,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
>  	clk[ecspi5]       = imx_clk_gate2("ecspi5",        "ecspi_root",        base + 0x6c, 8);
>  	clk[enet]         = imx_clk_gate2("enet",          "ipg",               base + 0x6c, 10);
>  	clk[esai]         = imx_clk_gate2("esai",          "esai_podf",         base + 0x6c, 16);
> +	clk[esai_ahb]     = imx_clk_gate2("esai_ahb",      "ahb",               base + 0x6c, 16);

We have the situation here that a single bit controls two clocks. As
Shawn mentioned just using two gates on the same bit doesn't work
properly. Do we need a new basic clock type or expand the common gate
code somehow?
This situation happens from time to time and I haven't seen a solution
for this.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux@arm.linux.org.uk, rob@landley.net, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
	rob.herring@calxeda.com, kernel@pengutronix.de,
	galak@codeaurora.org, mturquette@linaro.org,
	shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: imx6q: Add missing esai_ahb clock to current clock tree
Date: Thu, 9 Jan 2014 08:55:26 +0100	[thread overview]
Message-ID: <20140109075525.GO6750@pengutronix.de> (raw)
In-Reply-To: <1389236699-10387-1-git-send-email-Guangyu.Chen@freescale.com>

[Added Mike Turquette to Cc]

On Thu, Jan 09, 2014 at 11:04:59AM +0800, Nicolin Chen wrote:
> esai_ahb clock is derived from ahb and used to provide ESAI the capability of
> register accessing and FSYS clock source for I2S clocks dividing. Although the
> gate of this esai_ahb is duplicated with esai clock -- the baud clock, yet
> considering about the differences of their clock rates, it's quite essential
> to patch this missing clock.
> 

[...]

>  static struct clk *clk[clk_max];
> @@ -355,6 +355,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
>  	clk[ecspi5]       = imx_clk_gate2("ecspi5",        "ecspi_root",        base + 0x6c, 8);
>  	clk[enet]         = imx_clk_gate2("enet",          "ipg",               base + 0x6c, 10);
>  	clk[esai]         = imx_clk_gate2("esai",          "esai_podf",         base + 0x6c, 16);
> +	clk[esai_ahb]     = imx_clk_gate2("esai_ahb",      "ahb",               base + 0x6c, 16);

We have the situation here that a single bit controls two clocks. As
Shawn mentioned just using two gates on the same bit doesn't work
properly. Do we need a new basic clock type or expand the common gate
code somehow?
This situation happens from time to time and I haven't seen a solution
for this.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: shawn.guo@linaro.org, kernel@pengutronix.de,
	linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	devicetree@vger.kernel.org, rob@landley.net,
	mturquette@linaro.org
Subject: Re: [PATCH] ARM: imx6q: Add missing esai_ahb clock to current clock tree
Date: Thu, 9 Jan 2014 08:55:26 +0100	[thread overview]
Message-ID: <20140109075525.GO6750@pengutronix.de> (raw)
In-Reply-To: <1389236699-10387-1-git-send-email-Guangyu.Chen@freescale.com>

[Added Mike Turquette to Cc]

On Thu, Jan 09, 2014 at 11:04:59AM +0800, Nicolin Chen wrote:
> esai_ahb clock is derived from ahb and used to provide ESAI the capability of
> register accessing and FSYS clock source for I2S clocks dividing. Although the
> gate of this esai_ahb is duplicated with esai clock -- the baud clock, yet
> considering about the differences of their clock rates, it's quite essential
> to patch this missing clock.
> 

[...]

>  static struct clk *clk[clk_max];
> @@ -355,6 +355,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
>  	clk[ecspi5]       = imx_clk_gate2("ecspi5",        "ecspi_root",        base + 0x6c, 8);
>  	clk[enet]         = imx_clk_gate2("enet",          "ipg",               base + 0x6c, 10);
>  	clk[esai]         = imx_clk_gate2("esai",          "esai_podf",         base + 0x6c, 16);
> +	clk[esai_ahb]     = imx_clk_gate2("esai_ahb",      "ahb",               base + 0x6c, 16);

We have the situation here that a single bit controls two clocks. As
Shawn mentioned just using two gates on the same bit doesn't work
properly. Do we need a new basic clock type or expand the common gate
code somehow?
This situation happens from time to time and I haven't seen a solution
for this.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2014-01-09  7:55 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09  3:04 [PATCH] ARM: imx6q: Add missing esai_ahb clock to current clock tree Nicolin Chen
2014-01-09  3:04 ` Nicolin Chen
2014-01-09  3:04 ` Nicolin Chen
2014-01-09  3:58 ` Shawn Guo
2014-01-09  3:58   ` Shawn Guo
2014-01-09  3:58   ` Shawn Guo
2014-01-09  3:49   ` Nicolin Chen
2014-01-09  3:49     ` Nicolin Chen
2014-01-09  3:49     ` Nicolin Chen
2014-01-09  6:57     ` Shawn Guo
2014-01-09  6:57       ` Shawn Guo
2014-01-09  6:57       ` Shawn Guo
2014-01-09  7:41       ` Nicolin Chen
2014-01-09  7:41         ` Nicolin Chen
2014-01-09  7:41         ` Nicolin Chen
2014-01-09  7:58         ` Sascha Hauer
2014-01-09  7:58           ` Sascha Hauer
2014-01-09  7:58           ` Sascha Hauer
2014-01-09  7:51           ` Nicolin Chen
2014-01-09  7:51             ` Nicolin Chen
2014-01-09  7:51             ` Nicolin Chen
2014-01-09  7:55 ` Sascha Hauer [this message]
2014-01-09  7:55   ` Sascha Hauer
2014-01-09  7:55   ` Sascha Hauer
2014-01-09 14:57   ` Gerhard Sittig
2014-01-09 14:57     ` Gerhard Sittig
2014-01-09 14:57     ` Gerhard Sittig
2014-01-09 15:01   ` Russell King - ARM Linux
2014-01-09 15:01     ` Russell King - ARM Linux
2014-01-09 15:01     ` Russell King - ARM Linux
2014-01-10 10:06     ` Sascha Hauer
2014-01-10 10:06       ` Sascha Hauer
2014-01-10 10:06       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140109075525.GO6750@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.