All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: Baoquan <bhe@redhat.com>,
	kexec@lists.infradead.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-kernel@vger.kernel.org, tangchen@cn.fujitsu.com,
	linux-acpi@vger.kernel.org, zhangyanfei@cn.fujitsu.com,
	dyoung@redhat.com
Subject: Re: kdump failed because of hotplug memory adding in kdump kernel
Date: Thu, 9 Jan 2014 13:23:10 -0500	[thread overview]
Message-ID: <20140109182310.GG25897@redhat.com> (raw)
In-Reply-To: <1389288265.1792.108.camel@misato.fc.hp.com>

On Thu, Jan 09, 2014 at 10:24:25AM -0700, Toshi Kani wrote:

[..]
> > I think creating a new command line option is simpler as compared to
> > creating a new flag in bootparam which in turn disables memory hotplug.
> > More users can use that option. For example, if for some reason hotplug
> > code is crashing, one can just disable it on command line as work around
> > and move on.
> 
> I do not have a strong opinion about having such option.  However, I
> think it is more user friendly to keep the exactmap option works alone
> on any platforms.

I think we should create internally a variable which will disable memory
hotplug. And set that variable based on memmap=exactmap, mem=X and also
provide a way to disable memory hotplug directly using command line
option.

Current kexec-tools can use memmap=exactmap and be happy. I am writing
a new kexec syscall and will not be using memmap=exactmap and would need
to use that command line option to disable memory hotplug behavior.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Toshi Kani <toshi.kani-VXdhtT5mjnY@public.gmane.org>
Cc: Baoquan <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tangchen-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	zhangyanfei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org,
	dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: kdump failed because of hotplug memory adding in kdump kernel
Date: Thu, 9 Jan 2014 13:23:10 -0500	[thread overview]
Message-ID: <20140109182310.GG25897@redhat.com> (raw)
In-Reply-To: <1389288265.1792.108.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>

On Thu, Jan 09, 2014 at 10:24:25AM -0700, Toshi Kani wrote:

[..]
> > I think creating a new command line option is simpler as compared to
> > creating a new flag in bootparam which in turn disables memory hotplug.
> > More users can use that option. For example, if for some reason hotplug
> > code is crashing, one can just disable it on command line as work around
> > and move on.
> 
> I do not have a strong opinion about having such option.  However, I
> think it is more user friendly to keep the exactmap option works alone
> on any platforms.

I think we should create internally a variable which will disable memory
hotplug. And set that variable based on memmap=exactmap, mem=X and also
provide a way to disable memory hotplug directly using command line
option.

Current kexec-tools can use memmap=exactmap and be happy. I am writing
a new kexec syscall and will not be using memmap=exactmap and would need
to use that command line option to disable memory hotplug behavior.

Thanks
Vivek

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Baoquan <bhe@redhat.com>,
	linux-acpi@vger.kernel.org, zhangyanfei@cn.fujitsu.com,
	tangchen@cn.fujitsu.com, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, dyoung@redhat.com
Subject: Re: kdump failed because of hotplug memory adding in kdump kernel
Date: Thu, 9 Jan 2014 13:23:10 -0500	[thread overview]
Message-ID: <20140109182310.GG25897@redhat.com> (raw)
In-Reply-To: <1389288265.1792.108.camel@misato.fc.hp.com>

On Thu, Jan 09, 2014 at 10:24:25AM -0700, Toshi Kani wrote:

[..]
> > I think creating a new command line option is simpler as compared to
> > creating a new flag in bootparam which in turn disables memory hotplug.
> > More users can use that option. For example, if for some reason hotplug
> > code is crashing, one can just disable it on command line as work around
> > and move on.
> 
> I do not have a strong opinion about having such option.  However, I
> think it is more user friendly to keep the exactmap option works alone
> on any platforms.

I think we should create internally a variable which will disable memory
hotplug. And set that variable based on memmap=exactmap, mem=X and also
provide a way to disable memory hotplug directly using command line
option.

Current kexec-tools can use memmap=exactmap and be happy. I am writing
a new kexec syscall and will not be using memmap=exactmap and would need
to use that command line option to disable memory hotplug behavior.

Thanks
Vivek

  reply	other threads:[~2014-01-09 18:23 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 15:26 kdump failed because of hotplug memory adding in kdump kernel Baoquan
2014-01-08 15:26 ` Baoquan
2014-01-08 15:58 ` Vivek Goyal
2014-01-08 15:58   ` Vivek Goyal
2014-01-08 15:58   ` Vivek Goyal
2014-01-08 23:07   ` Rafael J. Wysocki
2014-01-08 23:07     ` Rafael J. Wysocki
2014-01-08 23:07     ` Rafael J. Wysocki
2014-01-09  0:11     ` Toshi Kani
2014-01-09  0:11       ` Toshi Kani
2014-01-09 13:10       ` Rafael J. Wysocki
2014-01-09 13:10         ` Rafael J. Wysocki
2014-01-09 14:53         ` Vivek Goyal
2014-01-09 14:53           ` Vivek Goyal
2014-01-09 14:53           ` Vivek Goyal
2014-01-09 16:15           ` Toshi Kani
2014-01-09 16:15             ` Toshi Kani
2014-01-09 16:15             ` Toshi Kani
2014-01-09 14:50       ` Vivek Goyal
2014-01-09 14:50         ` Vivek Goyal
2014-01-09 16:03         ` Toshi Kani
2014-01-09 16:03           ` Toshi Kani
2014-01-09 16:24           ` Vivek Goyal
2014-01-09 16:24             ` Vivek Goyal
2014-01-09 16:24             ` Vivek Goyal
2014-01-09 17:24             ` Toshi Kani
2014-01-09 17:24               ` Toshi Kani
2014-01-09 17:24               ` Toshi Kani
2014-01-09 18:23               ` Vivek Goyal [this message]
2014-01-09 18:23                 ` Vivek Goyal
2014-01-09 18:23                 ` Vivek Goyal
2014-01-09 18:34                 ` Toshi Kani
2014-01-09 18:34                   ` Toshi Kani
2014-01-09 21:27                   ` Vivek Goyal
2014-01-09 21:27                     ` Vivek Goyal
2014-01-09 21:27                     ` Vivek Goyal
2014-01-09 21:56                     ` Toshi Kani
2014-01-09 21:56                       ` Toshi Kani
2014-01-10  7:11                       ` Baoquan
2014-01-10  7:11                         ` Baoquan
2014-01-10  8:06                         ` Yasuaki Ishimatsu
2014-01-10  8:06                           ` Yasuaki Ishimatsu
2014-01-10  8:06                           ` Yasuaki Ishimatsu
2014-01-10  9:14                           ` Baoquan
2014-01-10  9:14                             ` Baoquan
2014-01-10  9:14                             ` Baoquan
2014-01-10  9:35                             ` Yasuaki Ishimatsu
2014-01-10  9:35                               ` Yasuaki Ishimatsu
2014-01-10  9:35                               ` Yasuaki Ishimatsu
2014-01-10 10:27                               ` Baoquan
2014-01-10 10:27                                 ` Baoquan
2014-01-10 10:27                                 ` Baoquan
2014-01-10 15:19                             ` Toshi Kani
2014-01-10 15:19                               ` Toshi Kani
2014-01-10 15:56                         ` Toshi Kani
2014-01-10 15:56                           ` Toshi Kani
2014-01-10  1:40                   ` Rafael J. Wysocki
2014-01-10  1:40                     ` Rafael J. Wysocki
2014-01-09  3:22     ` Baoquan
2014-01-09  3:22       ` Baoquan
2014-01-09 14:48     ` Vivek Goyal
2014-01-09 14:48       ` Vivek Goyal
2014-01-09 14:48       ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140109182310.GG25897@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tangchen@cn.fujitsu.com \
    --cc=toshi.kani@hp.com \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.