From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting
Date: Sun, 12 Jan 2014 13:23:21 +0100 [thread overview]
Message-ID: <20140112132321.757f3fa7@armhf> (raw)
In-Reply-To: <20140111183648.GH15937@n2100.arm.linux.org.uk>
On Sat, 11 Jan 2014 18:36:48 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote:
> > According to the comment, the TBG_CNTRL_0 register must be set at the
> > end of the mode change sequence.
>
> So you believe comments without understanding the history, and you move
> code around due to those.
>
> No, this is again wrong. That write to REG_TBG_CNTRL_0 in the sequence
> writing the video information to the chip. This doesn't encompass the
> HDMI/DVI mode setting nor the audio configuration - the audio configuration
> can change independently of the video setting, and does not require this
> register to be written.
>
> This also brings up a bug in one of your previous patches which I now
> must go back and comment upon.
Well, I have not the full spec of the TDA998x's, and I don't know what
is important or not. I was hoping that Rob had a better knowledge than I.
So, in my patch 9, I was writing the REG_TBG_CNTRL_1 after writing
REG_TBG_CNTRL_0, and you refused it. Here, I write REG_TBG_CNTRL_0
after the write of REG_TBG_CNTRL_1 in the HDMI sequence, and you still
don't agree.
What is the right way?
--
Ken ar c'henta? | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting
Date: Sun, 12 Jan 2014 13:23:21 +0100 [thread overview]
Message-ID: <20140112132321.757f3fa7@armhf> (raw)
In-Reply-To: <20140111183648.GH15937@n2100.arm.linux.org.uk>
On Sat, 11 Jan 2014 18:36:48 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote:
> > According to the comment, the TBG_CNTRL_0 register must be set at the
> > end of the mode change sequence.
>
> So you believe comments without understanding the history, and you move
> code around due to those.
>
> No, this is again wrong. That write to REG_TBG_CNTRL_0 in the sequence
> writing the video information to the chip. This doesn't encompass the
> HDMI/DVI mode setting nor the audio configuration - the audio configuration
> can change independently of the video setting, and does not require this
> register to be written.
>
> This also brings up a bug in one of your previous patches which I now
> must go back and comment upon.
Well, I have not the full spec of the TDA998x's, and I don't know what
is important or not. I was hoping that Rob had a better knowledge than I.
So, in my patch 9, I was writing the REG_TBG_CNTRL_1 after writing
REG_TBG_CNTRL_0, and you refused it. Here, I write REG_TBG_CNTRL_0
after the write of REG_TBG_CNTRL_1 in the HDMI sequence, and you still
don't agree.
What is the right way?
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: dri-devel@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>,
Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting
Date: Sun, 12 Jan 2014 13:23:21 +0100 [thread overview]
Message-ID: <20140112132321.757f3fa7@armhf> (raw)
In-Reply-To: <20140111183648.GH15937@n2100.arm.linux.org.uk>
On Sat, 11 Jan 2014 18:36:48 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote:
> > According to the comment, the TBG_CNTRL_0 register must be set at the
> > end of the mode change sequence.
>
> So you believe comments without understanding the history, and you move
> code around due to those.
>
> No, this is again wrong. That write to REG_TBG_CNTRL_0 in the sequence
> writing the video information to the chip. This doesn't encompass the
> HDMI/DVI mode setting nor the audio configuration - the audio configuration
> can change independently of the video setting, and does not require this
> register to be written.
>
> This also brings up a bug in one of your previous patches which I now
> must go back and comment upon.
Well, I have not the full spec of the TDA998x's, and I don't know what
is important or not. I was hoping that Rob had a better knowledge than I.
So, in my patch 9, I was writing the REG_TBG_CNTRL_1 after writing
REG_TBG_CNTRL_0, and you refused it. Here, I write REG_TBG_CNTRL_0
after the write of REG_TBG_CNTRL_1 in the HDMI sequence, and you still
don't agree.
What is the right way?
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2014-01-12 12:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 11:06 [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting Jean-Francois Moine
2014-01-09 11:06 ` Jean-Francois Moine
2014-01-09 11:06 ` Jean-Francois Moine
2014-01-11 18:36 ` Russell King - ARM Linux
2014-01-11 18:36 ` Russell King - ARM Linux
2014-01-12 12:23 ` Jean-Francois Moine [this message]
2014-01-12 12:23 ` Jean-Francois Moine
2014-01-12 12:23 ` Jean-Francois Moine
2014-01-12 12:31 ` Russell King - ARM Linux
2014-01-12 12:31 ` Russell King - ARM Linux
2014-01-12 13:20 ` Jean-Francois Moine
2014-01-12 13:20 ` Jean-Francois Moine
2014-01-12 13:20 ` Jean-Francois Moine
2014-01-12 13:38 ` Russell King - ARM Linux
2014-01-12 13:38 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140112132321.757f3fa7@armhf \
--to=moinejf@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.