All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Daniel Matuschek <daniel@matuschek.net>
Cc: alsa-devel@alsa-project.org,
	Dimitris.Papastamos@wolfsonmicro.com, tiwai@suse.de,
	linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
	perex@perex.cz, broonie@kernel.org, info@crazy-audio.com
Subject: Re: [PATCH] ASoC: wm8804: Allow control of master clock divider in PLL generation
Date: Mon, 13 Jan 2014 11:14:31 +0000	[thread overview]
Message-ID: <20140113111431.GA26419@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1401122206520.7929@parallels-Parallels-Virtual-Platform>

On Sun, Jan 12, 2014 at 10:11:25PM +0100, Daniel Matuschek wrote:
> Signed-off-by: Daniel Matuschek <daniel@matuschek.net>
> 
> After some discussions of the patch last week, here is a new version. 
> Simply reducing the post_table did not work, as for some frequencies
> both settings (MCLKDIV=0 and MCLKDIV=1) are needed (e.g. 96 and 192kHz)
> 
> 
>   WM8804 can run with PLL frequencies of 256xfs and 128xfs for
>   most sample rates. At 192kHz only 128xfs is supported. The
>   existing driver selects 128xfs automatically for some lower
>   samples rates. By using an additional mclk_div divider, is
>   is now possible to control the behaviour. This allows using
>   256xfs PLL frequency on all sample rates up to 96kHz. It
>   should allow lower jitter and better signal quality. The
>   behavior has to be controlled by the sound card driver,
>   because some sample frequency share the same setting. e.g.
>   192kHz and 96kHz use 24.576MHz master clock. The only
>   difference is the MCLK divider.
> 

Commit message still needs fixed up, as per Mark's comments on
your last patch. Otherwise looks ok to me.

Thanks,
Charles

  parent reply	other threads:[~2014-01-13 11:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12 21:11 [PATCH] ASoC: wm8804: Allow control of master clock divider in PLL generation Daniel Matuschek
2014-01-13  9:21 ` Florian Meier
2014-01-13 11:14 ` Charles Keepax [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-01-14 19:34 Daniel Matuschek
2014-01-17  0:54 ` Mark Brown
2014-01-17  0:54   ` Mark Brown
2014-01-17 10:35   ` Dimitris Papastamos
2014-01-17  9:48 ` Charles Keepax
2014-01-17 12:22 ` Mark Brown
2014-01-17 12:22   ` Mark Brown
2014-01-17 16:43 ` Florian Meier
2014-01-17 17:59   ` Mark Brown
2014-01-17 18:26     ` Daniel Matuschek
     [not found]     ` <52D97120.8030606@koalo.de>
     [not found]       ` <20140117183332.GC17314@sirena.org.uk>
2014-01-17 18:44         ` Florian Meier
2014-01-17 18:47           ` Mark Brown
2014-05-29 14:08 Charles Keepax
2014-05-29 15:01 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140113111431.GA26419@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=Dimitris.Papastamos@wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel@matuschek.net \
    --cc=info@crazy-audio.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.