From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3
Date: Mon, 13 Jan 2014 16:37:35 +0100 [thread overview]
Message-ID: <20140113163735.43c1d19b@armhf> (raw)
In-Reply-To: <20140111182602.GF15937@n2100.arm.linux.org.uk>
On Sat, 11 Jan 2014 18:26:02 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > div = 148500 / mode->clock;
> > + if (div != 0) {
> > + div--;
> > + if (div > 3)
> > + div = 3;
> > + }
>
> As the driver currently stands, we know that the clock divider works for
> the lower resolution modes. So, as things stand, for 74.25MHz modes,
> we get a divisor of one.
>
> Your patch changes this, the divider becomes zero. I wonder whether
> you've tested 720p modes at all with this?
In 720p, the divider becomes (148500 / 74250 - 1) = 1 and this mode
works fine.
--
Ken ar c'henta? | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3
Date: Mon, 13 Jan 2014 16:37:35 +0100 [thread overview]
Message-ID: <20140113163735.43c1d19b@armhf> (raw)
In-Reply-To: <20140111182602.GF15937@n2100.arm.linux.org.uk>
On Sat, 11 Jan 2014 18:26:02 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > div = 148500 / mode->clock;
> > + if (div != 0) {
> > + div--;
> > + if (div > 3)
> > + div = 3;
> > + }
>
> As the driver currently stands, we know that the clock divider works for
> the lower resolution modes. So, as things stand, for 74.25MHz modes,
> we get a divisor of one.
>
> Your patch changes this, the divider becomes zero. I wonder whether
> you've tested 720p modes at all with this?
In 720p, the divider becomes (148500 / 74250 - 1) = 1 and this mode
works fine.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: dri-devel@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>,
Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3
Date: Mon, 13 Jan 2014 16:37:35 +0100 [thread overview]
Message-ID: <20140113163735.43c1d19b@armhf> (raw)
In-Reply-To: <20140111182602.GF15937@n2100.arm.linux.org.uk>
On Sat, 11 Jan 2014 18:26:02 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > div = 148500 / mode->clock;
> > + if (div != 0) {
> > + div--;
> > + if (div > 3)
> > + div = 3;
> > + }
>
> As the driver currently stands, we know that the clock divider works for
> the lower resolution modes. So, as things stand, for 74.25MHz modes,
> we get a divisor of one.
>
> Your patch changes this, the divider becomes zero. I wonder whether
> you've tested 720p modes at all with this?
In 720p, the divider becomes (148500 / 74250 - 1) = 1 and this mode
works fine.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2014-01-13 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 11:05 [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3 Jean-Francois Moine
2014-01-09 11:05 ` Jean-Francois Moine
2014-01-09 11:05 ` Jean-Francois Moine
2014-01-11 18:26 ` Russell King - ARM Linux
2014-01-11 18:26 ` Russell King - ARM Linux
2014-01-13 15:37 ` Jean-Francois Moine [this message]
2014-01-13 15:37 ` Jean-Francois Moine
2014-01-13 15:37 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113163735.43c1d19b@armhf \
--to=moinejf@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.