From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Tushar Behera <tushar.behera@linaro.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Heiko Stuebner <heiko@sntech.de>, Mark Brown <broonie@kernel.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Ben Dooks <ben-linux@fluff.org>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Subject: Re: [PATCH] ARM: S3C[24|64]xx: move includes back under <mach/> scope
Date: Wed, 15 Jan 2014 14:19:23 +0100 [thread overview]
Message-ID: <201401151419.24423.arnd@arndb.de> (raw)
In-Reply-To: <CACRpkda=p6GnpuNQizdQA1gGuOe8Lnsp+r8rQedWCRog2MRHww@mail.gmail.com>
On Wednesday 15 January 2014, Linus Walleij wrote:
> When I look at it, the issue also exist in e.g.
> drivers/gpio/gpio-samsung.c which can be compiled
> (like for allyesconfig) when PLAT_SAMSUNG is set.
>
> And it is also set to y for ARCH_EXYNOS... which
> doesn't have any custom GPIO header. So this would
> involve something like creating an empty
> <mach/gpio-samsung.h> for Exynos which doesn't
> seem like the right thing to do.
Ah, right. I looked at this before, but I misremembered about
PLAT_SAMSUNG and thought it was fine because ARCH_EXYNOS no
longer implied PLAT_SAMSUNG. That was wrong, instead ARCH_EXYNOS
still sets PLAT_SAMSUNG but not PLAT_S5P as it used to.
> So I'm sticking with the #ifdef patch for now as it
> seems to be the lesser evil :-/
Yes, agreed.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C[24|64]xx: move includes back under <mach/> scope
Date: Wed, 15 Jan 2014 14:19:23 +0100 [thread overview]
Message-ID: <201401151419.24423.arnd@arndb.de> (raw)
In-Reply-To: <CACRpkda=p6GnpuNQizdQA1gGuOe8Lnsp+r8rQedWCRog2MRHww@mail.gmail.com>
On Wednesday 15 January 2014, Linus Walleij wrote:
> When I look at it, the issue also exist in e.g.
> drivers/gpio/gpio-samsung.c which can be compiled
> (like for allyesconfig) when PLAT_SAMSUNG is set.
>
> And it is also set to y for ARCH_EXYNOS... which
> doesn't have any custom GPIO header. So this would
> involve something like creating an empty
> <mach/gpio-samsung.h> for Exynos which doesn't
> seem like the right thing to do.
Ah, right. I looked at this before, but I misremembered about
PLAT_SAMSUNG and thought it was fine because ARCH_EXYNOS no
longer implied PLAT_SAMSUNG. That was wrong, instead ARCH_EXYNOS
still sets PLAT_SAMSUNG but not PLAT_S5P as it used to.
> So I'm sticking with the #ifdef patch for now as it
> seems to be the lesser evil :-/
Yes, agreed.
Arnd
next prev parent reply other threads:[~2014-01-15 13:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 13:53 [PATCH] ARM: S3C[24|64]xx: move includes back under <mach/> scope Linus Walleij
2014-01-14 13:53 ` Linus Walleij
2014-01-14 14:10 ` Mark Brown
2014-01-14 14:10 ` Mark Brown
2014-01-14 14:11 ` Arnd Bergmann
2014-01-14 14:11 ` Arnd Bergmann
2014-01-14 14:19 ` Heiko Stübner
2014-01-14 14:19 ` Heiko Stübner
2014-01-15 9:11 ` Tushar Behera
2014-01-15 9:11 ` Tushar Behera
2014-01-15 9:43 ` Arnd Bergmann
2014-01-15 9:43 ` Arnd Bergmann
2014-01-15 12:51 ` Linus Walleij
2014-01-15 12:51 ` Linus Walleij
2014-01-15 12:58 ` Linus Walleij
2014-01-15 12:58 ` Linus Walleij
2014-01-15 13:19 ` Arnd Bergmann [this message]
2014-01-15 13:19 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401151419.24423.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=tomasz.figa@gmail.com \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.