From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Kukjin Kim <kgene.kim@samsung.com>,
Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ARM: S3C[24|64]xx: move includes back under <mach/> scope
Date: Tue, 14 Jan 2014 15:19:36 +0100 [thread overview]
Message-ID: <2305953.5h9ERW0lIo@phil> (raw)
In-Reply-To: <1389707618-17011-1-git-send-email-linus.walleij@linaro.org>
Am Dienstag, 14. Januar 2014, 14:53:38 schrieb Linus Walleij:
> When refactoring and breaking out the includes for the
> machine-specific GPIO configuration, two files were created
> in <linux/platform_data/gpio-samsung-s3c[24|64]xx.h>, but as
> that namespace shall be used for defining data exchanged
> between machines and drivers, using it for these broad macros
> and config settings is wrong.
>
> Move the headers back into the machine-local
> <mach/gpio-samsung.h> file and think about the next step.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-samsung-soc@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Maintainers (Kukjin especially) - it'd be nice with a speedy
> ACK if this looks OK. I will put it into linux-next immediately
> so things are in order and smoketested for the merge window.
> ---
Acked-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C[24|64]xx: move includes back under <mach/> scope
Date: Tue, 14 Jan 2014 15:19:36 +0100 [thread overview]
Message-ID: <2305953.5h9ERW0lIo@phil> (raw)
In-Reply-To: <1389707618-17011-1-git-send-email-linus.walleij@linaro.org>
Am Dienstag, 14. Januar 2014, 14:53:38 schrieb Linus Walleij:
> When refactoring and breaking out the includes for the
> machine-specific GPIO configuration, two files were created
> in <linux/platform_data/gpio-samsung-s3c[24|64]xx.h>, but as
> that namespace shall be used for defining data exchanged
> between machines and drivers, using it for these broad macros
> and config settings is wrong.
>
> Move the headers back into the machine-local
> <mach/gpio-samsung.h> file and think about the next step.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-samsung-soc at vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Maintainers (Kukjin especially) - it'd be nice with a speedy
> ACK if this looks OK. I will put it into linux-next immediately
> so things are in order and smoketested for the merge window.
> ---
Acked-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2014-01-14 14:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 13:53 [PATCH] ARM: S3C[24|64]xx: move includes back under <mach/> scope Linus Walleij
2014-01-14 13:53 ` Linus Walleij
2014-01-14 14:10 ` Mark Brown
2014-01-14 14:10 ` Mark Brown
2014-01-14 14:11 ` Arnd Bergmann
2014-01-14 14:11 ` Arnd Bergmann
2014-01-14 14:19 ` Heiko Stübner [this message]
2014-01-14 14:19 ` Heiko Stübner
2014-01-15 9:11 ` Tushar Behera
2014-01-15 9:11 ` Tushar Behera
2014-01-15 9:43 ` Arnd Bergmann
2014-01-15 9:43 ` Arnd Bergmann
2014-01-15 12:51 ` Linus Walleij
2014-01-15 12:51 ` Linus Walleij
2014-01-15 12:58 ` Linus Walleij
2014-01-15 12:58 ` Linus Walleij
2014-01-15 13:19 ` Arnd Bergmann
2014-01-15 13:19 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2305953.5h9ERW0lIo@phil \
--to=heiko@sntech.de \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.