* [PATCH] vpe-vpdma: update SRCREV and pass CROSS_COMPILE
@ 2014-01-15 21:16 Denys Dmytriyenko
2014-01-15 22:25 ` Maupin, Chase
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2014-01-15 21:16 UTC (permalink / raw)
To: meta-ti
From: Denys Dmytriyenko <denys@ti.com>
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
recipes-bsp/ti/vpe-vpdma_git.bb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/recipes-bsp/ti/vpe-vpdma_git.bb b/recipes-bsp/ti/vpe-vpdma_git.bb
index d506791..fb3012a 100644
--- a/recipes-bsp/ti/vpe-vpdma_git.bb
+++ b/recipes-bsp/ti/vpe-vpdma_git.bb
@@ -8,9 +8,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=74d2f71d8898c54e3d1c9d0058c484aa"
COMPATIBLE_MACHINE = "dra7xx-evm"
PV = "1b8"
-PR = "r0"
+PR = "r1"
-SRCREV = "24a5487ec13bf560f0e7fb24a9d4747f9f358be2"
+SRCREV = "e3d8db1aa935775f9d196ad7428e0cd9864a36ca"
BRANCH ?= "master"
SRC_URI = "git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${BRANCH}"
@@ -18,7 +18,7 @@ SRC_URI = "git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${BRANCH
S = "${WORKDIR}/git"
# The test application needs additional include headers from the kernel
-EXTRA_OEMAKE = 'KDIR="${STAGING_KERNEL_DIR}/include/uapi -I${STAGING_KERNEL_DIR}/include"'
+EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}" KDIR="${STAGING_KERNEL_DIR}/include/uapi -I${STAGING_KERNEL_DIR}/include"'
do_install() {
oe_runmake DESTDIR="${D}" install
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] vpe-vpdma: update SRCREV and pass CROSS_COMPILE
2014-01-15 21:16 [PATCH] vpe-vpdma: update SRCREV and pass CROSS_COMPILE Denys Dmytriyenko
@ 2014-01-15 22:25 ` Maupin, Chase
2014-01-15 22:33 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Maupin, Chase @ 2014-01-15 22:25 UTC (permalink / raw)
To: Denys Dmytriyenko, meta-ti@yoctoproject.org
>-----Original Message-----
>From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
>bounces@yoctoproject.org] On Behalf Of Denys Dmytriyenko
>Sent: Wednesday, January 15, 2014 3:16 PM
>To: meta-ti@yoctoproject.org
>Subject: [meta-ti] [PATCH] vpe-vpdma: update SRCREV and pass
>CROSS_COMPILE
>
>From: Denys Dmytriyenko <denys@ti.com>
>
>Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>---
> recipes-bsp/ti/vpe-vpdma_git.bb | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/recipes-bsp/ti/vpe-vpdma_git.bb b/recipes-bsp/ti/vpe-
>vpdma_git.bb
>index d506791..fb3012a 100644
>--- a/recipes-bsp/ti/vpe-vpdma_git.bb
>+++ b/recipes-bsp/ti/vpe-vpdma_git.bb
>@@ -8,9 +8,9 @@ LIC_FILES_CHKSUM =
>"file://COPYING;md5=74d2f71d8898c54e3d1c9d0058c484aa"
> COMPATIBLE_MACHINE = "dra7xx-evm"
>
> PV = "1b8"
>-PR = "r0"
>+PR = "r1"
>
>-SRCREV = "24a5487ec13bf560f0e7fb24a9d4747f9f358be2"
>+SRCREV = "e3d8db1aa935775f9d196ad7428e0cd9864a36ca"
> BRANCH ?= "master"
>
> SRC_URI =
>"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${BR
>ANCH}"
>@@ -18,7 +18,7 @@ SRC_URI =
>"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${BR
>ANCH
> S = "${WORKDIR}/git"
>
> # The test application needs additional include headers from the
>kernel
>-EXTRA_OEMAKE = 'KDIR="${STAGING_KERNEL_DIR}/include/uapi -
>I${STAGING_KERNEL_DIR}/include"'
>+EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}"
>KDIR="${STAGING_KERNEL_DIR}/include/uapi -
>I${STAGING_KERNEL_DIR}/include"'
Shouldn't the setting of CC in OE already take care of this? Or did the rebase affect the Makefile?
>
> do_install() {
> oe_runmake DESTDIR="${D}" install
>--
>1.8.3.2
>
>_______________________________________________
>meta-ti mailing list
>meta-ti@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vpe-vpdma: update SRCREV and pass CROSS_COMPILE
2014-01-15 22:25 ` Maupin, Chase
@ 2014-01-15 22:33 ` Denys Dmytriyenko
2014-01-16 14:11 ` Maupin, Chase
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2014-01-15 22:33 UTC (permalink / raw)
To: Maupin, Chase; +Cc: meta-ti@yoctoproject.org
On Wed, Jan 15, 2014 at 10:25:01PM +0000, Maupin, Chase wrote:
> >-----Original Message-----
> >From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> >bounces@yoctoproject.org] On Behalf Of Denys Dmytriyenko
> >Sent: Wednesday, January 15, 2014 3:16 PM
> >To: meta-ti@yoctoproject.org
> >Subject: [meta-ti] [PATCH] vpe-vpdma: update SRCREV and pass
> >CROSS_COMPILE
> >
> >From: Denys Dmytriyenko <denys@ti.com>
> >
> >Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >---
> > recipes-bsp/ti/vpe-vpdma_git.bb | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/recipes-bsp/ti/vpe-vpdma_git.bb b/recipes-bsp/ti/vpe-
> >vpdma_git.bb
> >index d506791..fb3012a 100644
> >--- a/recipes-bsp/ti/vpe-vpdma_git.bb
> >+++ b/recipes-bsp/ti/vpe-vpdma_git.bb
> >@@ -8,9 +8,9 @@ LIC_FILES_CHKSUM =
> >"file://COPYING;md5=74d2f71d8898c54e3d1c9d0058c484aa"
> > COMPATIBLE_MACHINE = "dra7xx-evm"
> >
> > PV = "1b8"
> >-PR = "r0"
> >+PR = "r1"
> >
> >-SRCREV = "24a5487ec13bf560f0e7fb24a9d4747f9f358be2"
> >+SRCREV = "e3d8db1aa935775f9d196ad7428e0cd9864a36ca"
> > BRANCH ?= "master"
> >
> > SRC_URI =
> >"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${BR
> >ANCH}"
> >@@ -18,7 +18,7 @@ SRC_URI =
> >"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${BR
> >ANCH
> > S = "${WORKDIR}/git"
> >
> > # The test application needs additional include headers from the
> >kernel
> >-EXTRA_OEMAKE = 'KDIR="${STAGING_KERNEL_DIR}/include/uapi -
> >I${STAGING_KERNEL_DIR}/include"'
> >+EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}"
> >KDIR="${STAGING_KERNEL_DIR}/include/uapi -
> >I${STAGING_KERNEL_DIR}/include"'
>
> Shouldn't the setting of CC in OE already take care of this? Or did the rebase affect the Makefile?
I believe it has been affected by this commit:
http://git.ti.com/gitweb/?p=vpe_tests/vpe_tests.git;a=commitdiff;h=e3d8db1aa935775f9d196ad7428e0cd9864a36ca
It overrides CC in the Makefile and the simplest way is to pass CROSS_COMPILE.
> > do_install() {
> > oe_runmake DESTDIR="${D}" install
> >--
> >1.8.3.2
> >
> >_______________________________________________
> >meta-ti mailing list
> >meta-ti@yoctoproject.org
> >https://lists.yoctoproject.org/listinfo/meta-ti
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vpe-vpdma: update SRCREV and pass CROSS_COMPILE
2014-01-15 22:33 ` Denys Dmytriyenko
@ 2014-01-16 14:11 ` Maupin, Chase
2014-01-16 19:25 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Maupin, Chase @ 2014-01-16 14:11 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-ti@yoctoproject.org
>-----Original Message-----
>From: Dmytriyenko, Denys
>Sent: Wednesday, January 15, 2014 4:34 PM
>To: Maupin, Chase
>Cc: Denys Dmytriyenko; meta-ti@yoctoproject.org
>Subject: Re: [meta-ti] [PATCH] vpe-vpdma: update SRCREV and pass
>CROSS_COMPILE
>
>On Wed, Jan 15, 2014 at 10:25:01PM +0000, Maupin, Chase wrote:
>> >-----Original Message-----
>> >From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
>> >bounces@yoctoproject.org] On Behalf Of Denys Dmytriyenko
>> >Sent: Wednesday, January 15, 2014 3:16 PM
>> >To: meta-ti@yoctoproject.org
>> >Subject: [meta-ti] [PATCH] vpe-vpdma: update SRCREV and pass
>> >CROSS_COMPILE
>> >
>> >From: Denys Dmytriyenko <denys@ti.com>
>> >
>> >Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>> >---
>> > recipes-bsp/ti/vpe-vpdma_git.bb | 6 +++---
>> > 1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> >diff --git a/recipes-bsp/ti/vpe-vpdma_git.bb b/recipes-
>bsp/ti/vpe-
>> >vpdma_git.bb
>> >index d506791..fb3012a 100644
>> >--- a/recipes-bsp/ti/vpe-vpdma_git.bb
>> >+++ b/recipes-bsp/ti/vpe-vpdma_git.bb
>> >@@ -8,9 +8,9 @@ LIC_FILES_CHKSUM =
>> >"file://COPYING;md5=74d2f71d8898c54e3d1c9d0058c484aa"
>> > COMPATIBLE_MACHINE = "dra7xx-evm"
>> >
>> > PV = "1b8"
>> >-PR = "r0"
>> >+PR = "r1"
>> >
>> >-SRCREV = "24a5487ec13bf560f0e7fb24a9d4747f9f358be2"
>> >+SRCREV = "e3d8db1aa935775f9d196ad7428e0cd9864a36ca"
>> > BRANCH ?= "master"
>> >
>> > SRC_URI =
>>
>>"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${B
>R
>> >ANCH}"
>> >@@ -18,7 +18,7 @@ SRC_URI =
>>
>>"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${B
>R
>> >ANCH
>> > S = "${WORKDIR}/git"
>> >
>> > # The test application needs additional include headers from
>the
>> >kernel
>> >-EXTRA_OEMAKE = 'KDIR="${STAGING_KERNEL_DIR}/include/uapi -
>> >I${STAGING_KERNEL_DIR}/include"'
>> >+EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}"
>> >KDIR="${STAGING_KERNEL_DIR}/include/uapi -
>> >I${STAGING_KERNEL_DIR}/include"'
>>
>> Shouldn't the setting of CC in OE already take care of this? Or
>did the rebase affect the Makefile?
>
>I believe it has been affected by this commit:
>http://git.ti.com/gitweb/?p=vpe_tests/vpe_tests.git;a=commitdiff;h
>=e3d8db1aa935775f9d196ad7428e0cd9864a36ca
>
>It overrides CC in the Makefile and the simplest way is to pass
>CROSS_COMPILE.
Ah. The commit I was on used CC ?= .... so you didn't have to pass CROSS_COMPILE. Thanks.
>
>
>> > do_install() {
>> > oe_runmake DESTDIR="${D}" install
>> >--
>> >1.8.3.2
>> >
>> >_______________________________________________
>> >meta-ti mailing list
>> >meta-ti@yoctoproject.org
>> >https://lists.yoctoproject.org/listinfo/meta-ti
>> _______________________________________________
>> meta-ti mailing list
>> meta-ti@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vpe-vpdma: update SRCREV and pass CROSS_COMPILE
2014-01-16 14:11 ` Maupin, Chase
@ 2014-01-16 19:25 ` Denys Dmytriyenko
0 siblings, 0 replies; 5+ messages in thread
From: Denys Dmytriyenko @ 2014-01-16 19:25 UTC (permalink / raw)
To: Maupin, Chase; +Cc: meta-ti@yoctoproject.org, Archit Taneja
On Thu, Jan 16, 2014 at 09:11:37AM -0500, Maupin, Chase wrote:
> >-----Original Message-----
> >From: Dmytriyenko, Denys
> >Sent: Wednesday, January 15, 2014 4:34 PM
> >To: Maupin, Chase
> >Cc: Denys Dmytriyenko; meta-ti@yoctoproject.org
> >Subject: Re: [meta-ti] [PATCH] vpe-vpdma: update SRCREV and pass
> >CROSS_COMPILE
> >
> >On Wed, Jan 15, 2014 at 10:25:01PM +0000, Maupin, Chase wrote:
> >> >-----Original Message-----
> >> >From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> >> >bounces@yoctoproject.org] On Behalf Of Denys Dmytriyenko
> >> >Sent: Wednesday, January 15, 2014 3:16 PM
> >> >To: meta-ti@yoctoproject.org
> >> >Subject: [meta-ti] [PATCH] vpe-vpdma: update SRCREV and pass
> >> >CROSS_COMPILE
> >> >
> >> >From: Denys Dmytriyenko <denys@ti.com>
> >> >
> >> >Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >> >---
> >> > recipes-bsp/ti/vpe-vpdma_git.bb | 6 +++---
> >> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >> >
> >> >diff --git a/recipes-bsp/ti/vpe-vpdma_git.bb b/recipes-
> >bsp/ti/vpe-
> >> >vpdma_git.bb
> >> >index d506791..fb3012a 100644
> >> >--- a/recipes-bsp/ti/vpe-vpdma_git.bb
> >> >+++ b/recipes-bsp/ti/vpe-vpdma_git.bb
> >> >@@ -8,9 +8,9 @@ LIC_FILES_CHKSUM =
> >> >"file://COPYING;md5=74d2f71d8898c54e3d1c9d0058c484aa"
> >> > COMPATIBLE_MACHINE = "dra7xx-evm"
> >> >
> >> > PV = "1b8"
> >> >-PR = "r0"
> >> >+PR = "r1"
> >> >
> >> >-SRCREV = "24a5487ec13bf560f0e7fb24a9d4747f9f358be2"
> >> >+SRCREV = "e3d8db1aa935775f9d196ad7428e0cd9864a36ca"
> >> > BRANCH ?= "master"
> >> >
> >> > SRC_URI =
> >>
> >>"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${B
> >R
> >> >ANCH}"
> >> >@@ -18,7 +18,7 @@ SRC_URI =
> >>
> >>"git://git.ti.com/vpe_tests/vpe_tests.git;protocol=git;branch=${B
> >R
> >> >ANCH
> >> > S = "${WORKDIR}/git"
> >> >
> >> > # The test application needs additional include headers from
> >the
> >> >kernel
> >> >-EXTRA_OEMAKE = 'KDIR="${STAGING_KERNEL_DIR}/include/uapi -
> >> >I${STAGING_KERNEL_DIR}/include"'
> >> >+EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}"
> >> >KDIR="${STAGING_KERNEL_DIR}/include/uapi -
> >> >I${STAGING_KERNEL_DIR}/include"'
> >>
> >> Shouldn't the setting of CC in OE already take care of this? Or
> >did the rebase affect the Makefile?
> >
> >I believe it has been affected by this commit:
> >http://git.ti.com/gitweb/?p=vpe_tests/vpe_tests.git;a=commitdiff;h
> >=e3d8db1aa935775f9d196ad7428e0cd9864a36ca
> >
> >It overrides CC in the Makefile and the simplest way is to pass
> >CROSS_COMPILE.
>
> Ah. The commit I was on used CC ?= .... so you didn't have to pass CROSS_COMPILE. Thanks.
So, I'll be pushing this change shortly.
Going forward, can we try to avoid rebases - I don't believe it was even
necessary here...
--
Denys
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-16 19:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-15 21:16 [PATCH] vpe-vpdma: update SRCREV and pass CROSS_COMPILE Denys Dmytriyenko
2014-01-15 22:25 ` Maupin, Chase
2014-01-15 22:33 ` Denys Dmytriyenko
2014-01-16 14:11 ` Maupin, Chase
2014-01-16 19:25 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.