From: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
To: Robin Holt <robinmholt@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
liuj97@gmail.com, santosh.shilimkar@ti.com,
grygorii.strashko@ti.com, iamjoonsoo.kim@lge.com,
robin.m.holt@gmail.com, yinghai@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/nobootmem: Fix unused variable
Date: Thu, 16 Jan 2014 18:41:21 +0100 [thread overview]
Message-ID: <20140116184121.34d1e97c@lilie> (raw)
In-Reply-To: <CAPp3RGpt+qjFYrA928hBjseJNo4v0RKVnb-BjFJzH0uaVGcX+g@mail.gmail.com>
> I would think you would be better off making
> get_allocated_memblock_reserved_regions_info() and
> get_allocated_memblock_memory_regions_info be static inline functions
> when #ifdef CONFIG_ARCH_DISCARD_MEMBLOCK.
Possible, of course.
But the size variable has still to be #ifdef'd. And that's what the
patch is about. It's just an addition to another patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
To: Robin Holt <robinmholt@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
liuj97@gmail.com, santosh.shilimkar@ti.com,
grygorii.strashko@ti.com, iamjoonsoo.kim@lge.com,
robin.m.holt@gmail.com, yinghai@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/nobootmem: Fix unused variable
Date: Thu, 16 Jan 2014 18:41:21 +0100 [thread overview]
Message-ID: <20140116184121.34d1e97c@lilie> (raw)
In-Reply-To: <CAPp3RGpt+qjFYrA928hBjseJNo4v0RKVnb-BjFJzH0uaVGcX+g@mail.gmail.com>
> I would think you would be better off making
> get_allocated_memblock_reserved_regions_info() and
> get_allocated_memblock_memory_regions_info be static inline functions
> when #ifdef CONFIG_ARCH_DISCARD_MEMBLOCK.
Possible, of course.
But the size variable has still to be #ifdef'd. And that's what the
patch is about. It's just an addition to another patch.
next prev parent reply other threads:[~2014-01-16 17:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:33 [PATCH] mm/nobootmem: Fix unused variable Philipp Hachtmann
2014-01-16 13:33 ` Philipp Hachtmann
2014-01-16 15:45 ` Robin Holt
2014-01-16 15:49 ` Philipp Hachtmann
2014-01-16 15:49 ` Philipp Hachtmann
2014-01-16 16:37 ` Robin Holt
2014-01-16 16:37 ` Robin Holt
2014-01-16 17:41 ` Philipp Hachtmann [this message]
2014-01-16 17:41 ` Philipp Hachtmann
2014-01-16 21:25 ` Robin Holt
2014-01-16 21:25 ` Robin Holt
2014-01-16 15:51 ` Robin Holt
2014-01-16 15:51 ` Robin Holt
2014-01-16 22:43 ` David Rientjes
2014-01-16 22:43 ` David Rientjes
2014-01-17 21:38 ` Andrew Morton
2014-01-17 21:38 ` Andrew Morton
2014-01-20 11:28 ` Philipp Hachtmann
2014-01-20 11:28 ` Philipp Hachtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116184121.34d1e97c@lilie \
--to=phacht@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=grygorii.strashko@ti.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=robin.m.holt@gmail.com \
--cc=robinmholt@gmail.com \
--cc=santosh.shilimkar@ti.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.