From: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: hannes@cmpxchg.org, liuj97@gmail.com, santosh.shilimkar@ti.com,
grygorii.strashko@ti.com, iamjoonsoo.kim@lge.com,
robin.m.holt@gmail.com, yinghai@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] mm/nobootmem: Fix unused variable
Date: Mon, 20 Jan 2014 12:28:35 +0100 [thread overview]
Message-ID: <20140120122835.35e6d366@lilie> (raw)
In-Reply-To: <20140117133831.2a9306a03f9c6174ff096e48@linux-foundation.org>
Am Fri, 17 Jan 2014 13:38:31 -0800
schrieb Andrew Morton <akpm@linux-foundation.org>:
> Yes, that is a bit of an eyesore. We often approach the problem this
> way, which is nicer:
> [ ... ]
> #ifdef CONFIG_ARCH_DISCARD_MEMBLOCK
> {
> phys_addr_t size;
>
> [ ... ]
> }
> #endif
This is a very nice idea! I have updated my fix. This leads to a V5
patch series (which I will post now) because the following to patches
had to be slightly updated
to fit on top of the fix.
Kind regards
Philipp
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: hannes@cmpxchg.org, liuj97@gmail.com, santosh.shilimkar@ti.com,
grygorii.strashko@ti.com, iamjoonsoo.kim@lge.com,
robin.m.holt@gmail.com, yinghai@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] mm/nobootmem: Fix unused variable
Date: Mon, 20 Jan 2014 12:28:35 +0100 [thread overview]
Message-ID: <20140120122835.35e6d366@lilie> (raw)
In-Reply-To: <20140117133831.2a9306a03f9c6174ff096e48@linux-foundation.org>
Am Fri, 17 Jan 2014 13:38:31 -0800
schrieb Andrew Morton <akpm@linux-foundation.org>:
> Yes, that is a bit of an eyesore. We often approach the problem this
> way, which is nicer:
> [ ... ]
> #ifdef CONFIG_ARCH_DISCARD_MEMBLOCK
> {
> phys_addr_t size;
>
> [ ... ]
> }
> #endif
This is a very nice idea! I have updated my fix. This leads to a V5
patch series (which I will post now) because the following to patches
had to be slightly updated
to fit on top of the fix.
Kind regards
Philipp
next prev parent reply other threads:[~2014-01-20 11:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:33 [PATCH] mm/nobootmem: Fix unused variable Philipp Hachtmann
2014-01-16 13:33 ` Philipp Hachtmann
2014-01-16 15:45 ` Robin Holt
2014-01-16 15:49 ` Philipp Hachtmann
2014-01-16 15:49 ` Philipp Hachtmann
2014-01-16 16:37 ` Robin Holt
2014-01-16 16:37 ` Robin Holt
2014-01-16 17:41 ` Philipp Hachtmann
2014-01-16 17:41 ` Philipp Hachtmann
2014-01-16 21:25 ` Robin Holt
2014-01-16 21:25 ` Robin Holt
2014-01-16 15:51 ` Robin Holt
2014-01-16 15:51 ` Robin Holt
2014-01-16 22:43 ` David Rientjes
2014-01-16 22:43 ` David Rientjes
2014-01-17 21:38 ` Andrew Morton
2014-01-17 21:38 ` Andrew Morton
2014-01-20 11:28 ` Philipp Hachtmann [this message]
2014-01-20 11:28 ` Philipp Hachtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120122835.35e6d366@lilie \
--to=phacht@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=grygorii.strashko@ti.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=rientjes@google.com \
--cc=robin.m.holt@gmail.com \
--cc=santosh.shilimkar@ti.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.