All of lore.kernel.org
 help / color / mirror / Atom feed
* [ath9k-devel] [PATCH] ath9k_htc: make ->sta_rc_update atomic for most calls
@ 2014-01-28  8:14 ` Stanislaw Gruszka
  0 siblings, 0 replies; 4+ messages in thread
From: Stanislaw Gruszka @ 2014-01-28  8:14 UTC (permalink / raw)
  To: ath9k-devel

sta_rc_update() callback must be atomic, hence we can not take mutexes
or do other operations, which can sleep in ath9k_htc_sta_rc_update().

I think we can just return from ath9k_htc_sta_rc_update(), if it is
called without IEEE80211_RC_SUPP_RATES_CHANGED bit. That will help 
with scheduling while atomic bug for most cases (except mesh and IBSS
modes).

For mesh and IBSS I do not see other solution like creating additional
workqueue, because sending firmware command require us to sleep, but
this can be done in additional patch.

Patch partially fixes bug:
https://bugzilla.redhat.com/show_bug.cgi?id=990955

Cc: stable at vger.kernel.org
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/wireless/ath/ath9k/htc_drv_main.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index 608d739..a57af9b 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -1315,21 +1315,22 @@ static void ath9k_htc_sta_rc_update(struct ieee80211_hw *hw,
 	struct ath_common *common = ath9k_hw_common(priv->ah);
 	struct ath9k_htc_target_rate trate;
 
+	if (!(changed & IEEE80211_RC_SUPP_RATES_CHANGED))
+		return;
+
 	mutex_lock(&priv->mutex);
 	ath9k_htc_ps_wakeup(priv);
 
-	if (changed & IEEE80211_RC_SUPP_RATES_CHANGED) {
-		memset(&trate, 0, sizeof(struct ath9k_htc_target_rate));
-		ath9k_htc_setup_rate(priv, sta, &trate);
-		if (!ath9k_htc_send_rate_cmd(priv, &trate))
-			ath_dbg(common, CONFIG,
-				"Supported rates for sta: %pM updated, rate caps: 0x%X\n",
-				sta->addr, be32_to_cpu(trate.capflags));
-		else
-			ath_dbg(common, CONFIG,
-				"Unable to update supported rates for sta: %pM\n",
-				sta->addr);
-	}
+	memset(&trate, 0, sizeof(struct ath9k_htc_target_rate));
+	ath9k_htc_setup_rate(priv, sta, &trate);
+	if (!ath9k_htc_send_rate_cmd(priv, &trate))
+		ath_dbg(common, CONFIG,
+			"Supported rates for sta: %pM updated, rate caps: 0x%X\n",
+			sta->addr, be32_to_cpu(trate.capflags));
+	else
+		ath_dbg(common, CONFIG,
+			"Unable to update supported rates for sta: %pM\n",
+			sta->addr);
 
 	ath9k_htc_ps_restore(priv);
 	mutex_unlock(&priv->mutex);
-- 
1.7.11.7

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ath9k_htc: make ->sta_rc_update atomic for most calls
@ 2014-01-28  8:14 ` Stanislaw Gruszka
  0 siblings, 0 replies; 4+ messages in thread
From: Stanislaw Gruszka @ 2014-01-28  8:14 UTC (permalink / raw)
  To: linux-wireless; +Cc: ath9k-devel

sta_rc_update() callback must be atomic, hence we can not take mutexes
or do other operations, which can sleep in ath9k_htc_sta_rc_update().

I think we can just return from ath9k_htc_sta_rc_update(), if it is
called without IEEE80211_RC_SUPP_RATES_CHANGED bit. That will help 
with scheduling while atomic bug for most cases (except mesh and IBSS
modes).

For mesh and IBSS I do not see other solution like creating additional
workqueue, because sending firmware command require us to sleep, but
this can be done in additional patch.

Patch partially fixes bug:
https://bugzilla.redhat.com/show_bug.cgi?id=990955

Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/wireless/ath/ath9k/htc_drv_main.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index 608d739..a57af9b 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -1315,21 +1315,22 @@ static void ath9k_htc_sta_rc_update(struct ieee80211_hw *hw,
 	struct ath_common *common = ath9k_hw_common(priv->ah);
 	struct ath9k_htc_target_rate trate;
 
+	if (!(changed & IEEE80211_RC_SUPP_RATES_CHANGED))
+		return;
+
 	mutex_lock(&priv->mutex);
 	ath9k_htc_ps_wakeup(priv);
 
-	if (changed & IEEE80211_RC_SUPP_RATES_CHANGED) {
-		memset(&trate, 0, sizeof(struct ath9k_htc_target_rate));
-		ath9k_htc_setup_rate(priv, sta, &trate);
-		if (!ath9k_htc_send_rate_cmd(priv, &trate))
-			ath_dbg(common, CONFIG,
-				"Supported rates for sta: %pM updated, rate caps: 0x%X\n",
-				sta->addr, be32_to_cpu(trate.capflags));
-		else
-			ath_dbg(common, CONFIG,
-				"Unable to update supported rates for sta: %pM\n",
-				sta->addr);
-	}
+	memset(&trate, 0, sizeof(struct ath9k_htc_target_rate));
+	ath9k_htc_setup_rate(priv, sta, &trate);
+	if (!ath9k_htc_send_rate_cmd(priv, &trate))
+		ath_dbg(common, CONFIG,
+			"Supported rates for sta: %pM updated, rate caps: 0x%X\n",
+			sta->addr, be32_to_cpu(trate.capflags));
+	else
+		ath_dbg(common, CONFIG,
+			"Unable to update supported rates for sta: %pM\n",
+			sta->addr);
 
 	ath9k_htc_ps_restore(priv);
 	mutex_unlock(&priv->mutex);
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [ath9k-devel] [PATCH] ath9k_htc: make ->sta_rc_update atomic for most calls
  2014-01-28  8:14 ` Stanislaw Gruszka
@ 2014-01-28  9:30   ` Oleksij Rempel
  -1 siblings, 0 replies; 4+ messages in thread
From: Oleksij Rempel @ 2014-01-28  9:30 UTC (permalink / raw)
  To: ath9k-devel

Looks good,
thank you!

Am 28.01.2014 09:14, schrieb Stanislaw Gruszka:
> sta_rc_update() callback must be atomic, hence we can not take mutexes
> or do other operations, which can sleep in ath9k_htc_sta_rc_update().
> 
> I think we can just return from ath9k_htc_sta_rc_update(), if it is
> called without IEEE80211_RC_SUPP_RATES_CHANGED bit. That will help 
> with scheduling while atomic bug for most cases (except mesh and IBSS
> modes).
> 
> For mesh and IBSS I do not see other solution like creating additional
> workqueue, because sending firmware command require us to sleep, but
> this can be done in additional patch.
> 
> Patch partially fixes bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=990955
> 
> Cc: stable at vger.kernel.org
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/ath/ath9k/htc_drv_main.c | 25 +++++++++++++------------
>  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> index 608d739..a57af9b 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> @@ -1315,21 +1315,22 @@ static void ath9k_htc_sta_rc_update(struct ieee80211_hw *hw,
>  	struct ath_common *common = ath9k_hw_common(priv->ah);
>  	struct ath9k_htc_target_rate trate;
>  
> +	if (!(changed & IEEE80211_RC_SUPP_RATES_CHANGED))
> +		return;
> +
>  	mutex_lock(&priv->mutex);
>  	ath9k_htc_ps_wakeup(priv);
>  
> -	if (changed & IEEE80211_RC_SUPP_RATES_CHANGED) {
> -		memset(&trate, 0, sizeof(struct ath9k_htc_target_rate));
> -		ath9k_htc_setup_rate(priv, sta, &trate);
> -		if (!ath9k_htc_send_rate_cmd(priv, &trate))
> -			ath_dbg(common, CONFIG,
> -				"Supported rates for sta: %pM updated, rate caps: 0x%X\n",
> -				sta->addr, be32_to_cpu(trate.capflags));
> -		else
> -			ath_dbg(common, CONFIG,
> -				"Unable to update supported rates for sta: %pM\n",
> -				sta->addr);
> -	}
> +	memset(&trate, 0, sizeof(struct ath9k_htc_target_rate));
> +	ath9k_htc_setup_rate(priv, sta, &trate);
> +	if (!ath9k_htc_send_rate_cmd(priv, &trate))
> +		ath_dbg(common, CONFIG,
> +			"Supported rates for sta: %pM updated, rate caps: 0x%X\n",
> +			sta->addr, be32_to_cpu(trate.capflags));
> +	else
> +		ath_dbg(common, CONFIG,
> +			"Unable to update supported rates for sta: %pM\n",
> +			sta->addr);
>  
>  	ath9k_htc_ps_restore(priv);
>  	mutex_unlock(&priv->mutex);
> 


-- 
Regards,
Oleksij

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 295 bytes
Desc: OpenPGP digital signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20140128/7ad3875d/attachment.pgp 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k_htc: make ->sta_rc_update atomic for most calls
@ 2014-01-28  9:30   ` Oleksij Rempel
  0 siblings, 0 replies; 4+ messages in thread
From: Oleksij Rempel @ 2014-01-28  9:30 UTC (permalink / raw)
  To: Stanislaw Gruszka, linux-wireless; +Cc: ath9k-devel

[-- Attachment #1: Type: text/plain, Size: 2571 bytes --]

Looks good,
thank you!

Am 28.01.2014 09:14, schrieb Stanislaw Gruszka:
> sta_rc_update() callback must be atomic, hence we can not take mutexes
> or do other operations, which can sleep in ath9k_htc_sta_rc_update().
> 
> I think we can just return from ath9k_htc_sta_rc_update(), if it is
> called without IEEE80211_RC_SUPP_RATES_CHANGED bit. That will help 
> with scheduling while atomic bug for most cases (except mesh and IBSS
> modes).
> 
> For mesh and IBSS I do not see other solution like creating additional
> workqueue, because sending firmware command require us to sleep, but
> this can be done in additional patch.
> 
> Patch partially fixes bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=990955
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/ath/ath9k/htc_drv_main.c | 25 +++++++++++++------------
>  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> index 608d739..a57af9b 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> @@ -1315,21 +1315,22 @@ static void ath9k_htc_sta_rc_update(struct ieee80211_hw *hw,
>  	struct ath_common *common = ath9k_hw_common(priv->ah);
>  	struct ath9k_htc_target_rate trate;
>  
> +	if (!(changed & IEEE80211_RC_SUPP_RATES_CHANGED))
> +		return;
> +
>  	mutex_lock(&priv->mutex);
>  	ath9k_htc_ps_wakeup(priv);
>  
> -	if (changed & IEEE80211_RC_SUPP_RATES_CHANGED) {
> -		memset(&trate, 0, sizeof(struct ath9k_htc_target_rate));
> -		ath9k_htc_setup_rate(priv, sta, &trate);
> -		if (!ath9k_htc_send_rate_cmd(priv, &trate))
> -			ath_dbg(common, CONFIG,
> -				"Supported rates for sta: %pM updated, rate caps: 0x%X\n",
> -				sta->addr, be32_to_cpu(trate.capflags));
> -		else
> -			ath_dbg(common, CONFIG,
> -				"Unable to update supported rates for sta: %pM\n",
> -				sta->addr);
> -	}
> +	memset(&trate, 0, sizeof(struct ath9k_htc_target_rate));
> +	ath9k_htc_setup_rate(priv, sta, &trate);
> +	if (!ath9k_htc_send_rate_cmd(priv, &trate))
> +		ath_dbg(common, CONFIG,
> +			"Supported rates for sta: %pM updated, rate caps: 0x%X\n",
> +			sta->addr, be32_to_cpu(trate.capflags));
> +	else
> +		ath_dbg(common, CONFIG,
> +			"Unable to update supported rates for sta: %pM\n",
> +			sta->addr);
>  
>  	ath9k_htc_ps_restore(priv);
>  	mutex_unlock(&priv->mutex);
> 


-- 
Regards,
Oleksij


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-28  9:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-28  8:14 [ath9k-devel] [PATCH] ath9k_htc: make ->sta_rc_update atomic for most calls Stanislaw Gruszka
2014-01-28  8:14 ` Stanislaw Gruszka
2014-01-28  9:30 ` [ath9k-devel] " Oleksij Rempel
2014-01-28  9:30   ` Oleksij Rempel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.