* nouveau: treat nv04_devinit_priv.owner as signed.
@ 2014-01-30 17:21 Dave Jones
0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2014-01-30 17:21 UTC (permalink / raw)
To: bskeggs; +Cc: dri-devel
This is set and compared to -1 in the code, which evaluates to always false.
If we want to treat it as a signed var, we should declare it as one.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
diff --git a/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h b/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h
index 23470a57510c..9d54c106dddf 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h
+++ b/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h
@@ -5,7 +5,7 @@
struct nv04_devinit_priv {
struct nouveau_devinit base;
- u8 owner;
+ s8 owner;
};
int nv04_devinit_ctor(struct nouveau_object *, struct nouveau_object *,
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-01-30 17:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 17:21 nouveau: treat nv04_devinit_priv.owner as signed Dave Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.