* [PATCH] staging: bcm: fix pointer-integer size mismatch warnings
@ 2014-02-04 6:59 SeongJae Park
2014-02-04 8:21 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: SeongJae Park @ 2014-02-04 6:59 UTC (permalink / raw)
To: gregkh, lisa; +Cc: devel, linux-kernel, SeongJae Park
Fix the pointer-integer size mismatch warnings below:
drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
^
drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
^
drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
^
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/staging/bcm/CmHost.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
index cc91b5e..dd8f8f7 100644
--- a/drivers/staging/bcm/CmHost.c
+++ b/drivers/staging/bcm/CmHost.c
@@ -1384,7 +1384,8 @@ ULONG StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter, PVOID pvBu
}
/* this can't possibly be right */
- pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
+ pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)
+ (uintptr_t)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
if (pstAddIndicationAlt->u8Type == DSA_REQ) {
struct bcm_add_request AddRequest;
@@ -1423,7 +1424,8 @@ ULONG StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter, PVOID pvBu
return 0;
}
- pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
+ pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)
+ (uintptr_t)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
/* ACTIVE SET */
pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)
@@ -1437,7 +1439,8 @@ ULONG StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter, PVOID pvBu
return 0;
}
- pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
+ pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)
+ (uintptr_t)ntohl((ULONG)pstAddIndication->psfActiveSet);
(*puBufferLength) = sizeof(struct bcm_add_indication);
*(struct bcm_add_indication *)pvBuffer = *pstAddIndication;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings
2014-02-04 6:59 [PATCH] staging: bcm: fix pointer-integer size mismatch warnings SeongJae Park
@ 2014-02-04 8:21 ` Dan Carpenter
2014-02-04 8:26 ` SeongJae Park
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2014-02-04 8:21 UTC (permalink / raw)
To: SeongJae Park; +Cc: gregkh, lisa, devel, linux-kernel
On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote:
> Fix the pointer-integer size mismatch warnings below:
> drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
> pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
> ^
> drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
> pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
> ^
> drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
> pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
> ^
No. You haven't fixed the bug, you've just silenced the warning so now
someone has to spent hours and hours looking for it when it comes time
to write a proper fix. Don't do that.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings
2014-02-04 8:21 ` Dan Carpenter
@ 2014-02-04 8:26 ` SeongJae Park
2014-02-04 8:51 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: SeongJae Park @ 2014-02-04 8:26 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Greg KH, lisa, devel, linux-kernel@vger.kernel.org
Hello,
On Tue, Feb 4, 2014 at 5:21 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote:
>> Fix the pointer-integer size mismatch warnings below:
>> drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
>> drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
>> integer of different size [-Wint-to-pointer-cast]
>> pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
>> ^
>> drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
>> integer of different size [-Wint-to-pointer-cast]
>> pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
>> ^
>> drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
>> integer of different size [-Wint-to-pointer-cast]
>> pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
>> ^
>
> No. You haven't fixed the bug, you've just silenced the warning so now
> someone has to spent hours and hours looking for it when it comes time
> to write a proper fix. Don't do that.
>
I had thought silencing warning may be better in someway for some people.
But, anyway, now I agree and respect your opinion. Thank you for the opinion :)
> regards,
> dan carpenter
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings
2014-02-04 8:26 ` SeongJae Park
@ 2014-02-04 8:51 ` Dan Carpenter
2014-02-04 9:00 ` SeongJae Park
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2014-02-04 8:51 UTC (permalink / raw)
To: SeongJae Park; +Cc: Greg KH, lisa, devel, linux-kernel@vger.kernel.org
On Tue, Feb 04, 2014 at 05:26:57PM +0900, SeongJae Park wrote:
> Hello,
>
> On Tue, Feb 4, 2014 at 5:21 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote:
> >> Fix the pointer-integer size mismatch warnings below:
> >> drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> >> drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
> >> integer of different size [-Wint-to-pointer-cast]
> >> pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
> >> ^
> >> drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
> >> integer of different size [-Wint-to-pointer-cast]
> >> pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
> >> ^
> >> drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
> >> integer of different size [-Wint-to-pointer-cast]
> >> pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
> >> ^
> >
> > No. You haven't fixed the bug, you've just silenced the warning so now
> > someone has to spent hours and hours looking for it when it comes time
> > to write a proper fix. Don't do that.
> >
>
> I had thought silencing warning may be better in someway for some people.
> But, anyway, now I agree and respect your opinion. Thank you for the opinion :)
Don't worry about it. You're not the first person to try submit that
patch.
When I last looked at it, this driver only worked under 32 bits and
there were other 64 bit bugs as well besides this one.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings
2014-02-04 8:51 ` Dan Carpenter
@ 2014-02-04 9:00 ` SeongJae Park
0 siblings, 0 replies; 5+ messages in thread
From: SeongJae Park @ 2014-02-04 9:00 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Greg KH, lisa, devel, linux-kernel@vger.kernel.org
On Tue, Feb 4, 2014 at 5:51 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Feb 04, 2014 at 05:26:57PM +0900, SeongJae Park wrote:
>> Hello,
>>
>> On Tue, Feb 4, 2014 at 5:21 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> > On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote:
>> >> Fix the pointer-integer size mismatch warnings below:
>> >> drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
>> >> drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
>> >> integer of different size [-Wint-to-pointer-cast]
>> >> pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
>> >> ^
>> >> drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
>> >> integer of different size [-Wint-to-pointer-cast]
>> >> pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
>> >> ^
>> >> drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
>> >> integer of different size [-Wint-to-pointer-cast]
>> >> pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
>> >> ^
>> >
>> > No. You haven't fixed the bug, you've just silenced the warning so now
>> > someone has to spent hours and hours looking for it when it comes time
>> > to write a proper fix. Don't do that.
>> >
>>
>> I had thought silencing warning may be better in someway for some people.
>> But, anyway, now I agree and respect your opinion. Thank you for the opinion :)
>
> Don't worry about it. You're not the first person to try submit that
> patch.
>
> When I last looked at it, this driver only worked under 32 bits and
> there were other 64 bit bugs as well besides this one.
>
> regards,
> dan carpenter
>
Thank you very much for your kind reply. I'm yet newbie to kernel community
and thinking I should try with unavoidable mistakes. Your reply have gave me
more courage for trial.
I will not forget the learning I got from this trial :)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-04 9:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-04 6:59 [PATCH] staging: bcm: fix pointer-integer size mismatch warnings SeongJae Park
2014-02-04 8:21 ` Dan Carpenter
2014-02-04 8:26 ` SeongJae Park
2014-02-04 8:51 ` Dan Carpenter
2014-02-04 9:00 ` SeongJae Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.