From: Stephen Boyd <sboyd@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v2 2/5] clocksource: qcom: Move clocksource code out of mach-msm
Date: Tue, 4 Feb 2014 15:59:55 -0800 [thread overview]
Message-ID: <20140204235955.GF20528@codeaurora.org> (raw)
In-Reply-To: <EE8EC898-CFE4-4953-968A-ECCEEB09DE76@codeaurora.org>
On 02/04, Kumar Gala wrote:
>
> On Feb 4, 2014, at 5:09 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>
> > On 02/04, Kumar Gala wrote:
> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> >> index cd6950f..81caa16 100644
> >> --- a/drivers/clocksource/Kconfig
> >> +++ b/drivers/clocksource/Kconfig
> >> @@ -140,3 +140,7 @@ config VF_PIT_TIMER
> >> bool
> >> help
> >> Support for Period Interrupt Timer on Freescale Vybrid Family SoCs.
> >> +
> >> +config CLKSRC_QCOM
> >> + bool
> >> + depends on ARCH_MSM
> >
> > It would be a a little less noisy if you left this as MSM_TIMER
> > (msm is all over the code in that file anyway). Also, why do we
> > care about depending on ARCH_MSM here? This is a hidden Kconfig
> > option anyway.
>
> I will drop the depends, but not sure what point in leaving this as MSM_TIMER.
>
Less changes to the Kconfig files if you do that. It's a minor
thing.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] clocksource: qcom: Move clocksource code out of mach-msm
Date: Tue, 4 Feb 2014 15:59:55 -0800 [thread overview]
Message-ID: <20140204235955.GF20528@codeaurora.org> (raw)
In-Reply-To: <EE8EC898-CFE4-4953-968A-ECCEEB09DE76@codeaurora.org>
On 02/04, Kumar Gala wrote:
>
> On Feb 4, 2014, at 5:09 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>
> > On 02/04, Kumar Gala wrote:
> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> >> index cd6950f..81caa16 100644
> >> --- a/drivers/clocksource/Kconfig
> >> +++ b/drivers/clocksource/Kconfig
> >> @@ -140,3 +140,7 @@ config VF_PIT_TIMER
> >> bool
> >> help
> >> Support for Period Interrupt Timer on Freescale Vybrid Family SoCs.
> >> +
> >> +config CLKSRC_QCOM
> >> + bool
> >> + depends on ARCH_MSM
> >
> > It would be a a little less noisy if you left this as MSM_TIMER
> > (msm is all over the code in that file anyway). Also, why do we
> > care about depending on ARCH_MSM here? This is a hidden Kconfig
> > option anyway.
>
> I will drop the depends, but not sure what point in leaving this as MSM_TIMER.
>
Less changes to the Kconfig files if you do that. It's a minor
thing.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-04 23:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 22:38 [PATCH v2 0/5] Split mach-msm into legacy and mach-qcom (multiplatform) Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-04 22:38 ` [PATCH v2 1/5] ARM: msm: kill off hotplug.c Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-04 23:07 ` Stephen Boyd
2014-02-04 23:07 ` Stephen Boyd
2014-02-04 23:45 ` Kumar Gala
2014-02-04 23:45 ` Kumar Gala
2014-02-07 21:19 ` Stephen Boyd
2014-02-07 21:19 ` Stephen Boyd
2014-02-04 22:38 ` [PATCH v2 2/5] clocksource: qcom: Move clocksource code out of mach-msm Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-04 23:09 ` Stephen Boyd
2014-02-04 23:09 ` Stephen Boyd
2014-02-04 23:51 ` Kumar Gala
2014-02-04 23:51 ` Kumar Gala
2014-02-04 23:59 ` Stephen Boyd [this message]
2014-02-04 23:59 ` Stephen Boyd
2014-02-04 22:38 ` [PATCH v2 3/5] arm: qcom: Split Qualcomm support into legacy and multiplatform Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-05 0:45 ` Stephen Boyd
2014-02-05 0:45 ` Stephen Boyd
2014-02-04 22:38 ` [PATCH v2 4/5] clocksource: qcom: split building of legacy vs multiplatform support Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-04 22:38 ` [PATCH v2 5/5] ARM: qcom: Rename various msm prefixed functions to qcom Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-05 0:47 ` [PATCH v2 0/5] Split mach-msm into legacy and mach-qcom (multiplatform) Stephen Boyd
2014-02-05 0:47 ` Stephen Boyd
2014-02-05 15:27 ` Kumar Gala
2014-02-05 15:27 ` Kumar Gala
2014-02-05 15:27 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204235955.GF20528@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.