From: Stephen Boyd <sboyd@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] ARM: msm: kill off hotplug.c
Date: Fri, 7 Feb 2014 13:19:07 -0800 [thread overview]
Message-ID: <20140207211907.GE12815@codeaurora.org> (raw)
In-Reply-To: <CE29C478-50CA-4CC8-9E80-AA9C22D9B17F@codeaurora.org>
On 02/04, Kumar Gala wrote:
>
> On Feb 4, 2014, at 5:07 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>
> > On 02/04, Kumar Gala wrote:
> >> diff --git a/arch/arm/mach-msm/platsmp.c b/arch/arm/mach-msm/platsmp.c
> >> index 3721b31..251a91e 100644
> >> --- a/arch/arm/mach-msm/platsmp.c
> >> +++ b/arch/arm/mach-msm/platsmp.c
> >> @@ -29,6 +29,13 @@ extern void secondary_startup(void);
> >>
> >> static DEFINE_SPINLOCK(boot_lock);
> >>
> >> +#ifdef CONFIG_HOTPLUG_CPU
> >> +static void __ref msm_cpu_die(unsigned int cpu)
> >
> > We shouldn't need __ref anymore either right?
>
> I think we might as cpu_die is still marked __ref so I think we need it.
>
Someone should remove __ref from cpu_die() as well. It was only
ever there for __cpuinit but now that __cpuinit is gone it's
useless.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] ARM: msm: kill off hotplug.c
Date: Fri, 7 Feb 2014 13:19:07 -0800 [thread overview]
Message-ID: <20140207211907.GE12815@codeaurora.org> (raw)
In-Reply-To: <CE29C478-50CA-4CC8-9E80-AA9C22D9B17F@codeaurora.org>
On 02/04, Kumar Gala wrote:
>
> On Feb 4, 2014, at 5:07 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>
> > On 02/04, Kumar Gala wrote:
> >> diff --git a/arch/arm/mach-msm/platsmp.c b/arch/arm/mach-msm/platsmp.c
> >> index 3721b31..251a91e 100644
> >> --- a/arch/arm/mach-msm/platsmp.c
> >> +++ b/arch/arm/mach-msm/platsmp.c
> >> @@ -29,6 +29,13 @@ extern void secondary_startup(void);
> >>
> >> static DEFINE_SPINLOCK(boot_lock);
> >>
> >> +#ifdef CONFIG_HOTPLUG_CPU
> >> +static void __ref msm_cpu_die(unsigned int cpu)
> >
> > We shouldn't need __ref anymore either right?
>
> I think we might as cpu_die is still marked __ref so I think we need it.
>
Someone should remove __ref from cpu_die() as well. It was only
ever there for __cpuinit but now that __cpuinit is gone it's
useless.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-07 21:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 22:38 [PATCH v2 0/5] Split mach-msm into legacy and mach-qcom (multiplatform) Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-04 22:38 ` [PATCH v2 1/5] ARM: msm: kill off hotplug.c Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-04 23:07 ` Stephen Boyd
2014-02-04 23:07 ` Stephen Boyd
2014-02-04 23:45 ` Kumar Gala
2014-02-04 23:45 ` Kumar Gala
2014-02-07 21:19 ` Stephen Boyd [this message]
2014-02-07 21:19 ` Stephen Boyd
2014-02-04 22:38 ` [PATCH v2 2/5] clocksource: qcom: Move clocksource code out of mach-msm Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-04 23:09 ` Stephen Boyd
2014-02-04 23:09 ` Stephen Boyd
2014-02-04 23:51 ` Kumar Gala
2014-02-04 23:51 ` Kumar Gala
2014-02-04 23:59 ` Stephen Boyd
2014-02-04 23:59 ` Stephen Boyd
2014-02-04 22:38 ` [PATCH v2 3/5] arm: qcom: Split Qualcomm support into legacy and multiplatform Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-05 0:45 ` Stephen Boyd
2014-02-05 0:45 ` Stephen Boyd
2014-02-04 22:38 ` [PATCH v2 4/5] clocksource: qcom: split building of legacy vs multiplatform support Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-04 22:38 ` [PATCH v2 5/5] ARM: qcom: Rename various msm prefixed functions to qcom Kumar Gala
2014-02-04 22:38 ` Kumar Gala
2014-02-05 0:47 ` [PATCH v2 0/5] Split mach-msm into legacy and mach-qcom (multiplatform) Stephen Boyd
2014-02-05 0:47 ` Stephen Boyd
2014-02-05 15:27 ` Kumar Gala
2014-02-05 15:27 ` Kumar Gala
2014-02-05 15:27 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207211907.GE12815@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.