All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: gnurou@gmail.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h
Date: Mon, 10 Feb 2014 13:37:58 +0100	[thread overview]
Message-ID: <20140210123757.GF20143@ulmo.nvidia.com> (raw)
In-Reply-To: <1391938998-4848-1-git-send-email-acourbot@nvidia.com>


[-- Attachment #1.1: Type: text/plain, Size: 680 bytes --]

On Sun, Feb 09, 2014 at 06:43:18PM +0900, Alexandre Courbot wrote:
> Declare 'struct device' explicitly in ttm_page_alloc.h as this file
> does not include any file declaring it. This removes the following
> warning:
> 
> 	warning: 'struct device' declared inside parameter list
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> This warning was visible when compiling Nouveau on -next today.
> 
>  include/drm/ttm/ttm_page_alloc.h | 2 ++
>  1 file changed, 2 insertions(+)

I don't think I've seen this on x86, but I've certainly encountered the
same warning when building nouveau on ARM, so:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: David Airlie <airlied@linux.ie>,
	gnurou@gmail.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h
Date: Mon, 10 Feb 2014 13:37:58 +0100	[thread overview]
Message-ID: <20140210123757.GF20143@ulmo.nvidia.com> (raw)
In-Reply-To: <1391938998-4848-1-git-send-email-acourbot@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

On Sun, Feb 09, 2014 at 06:43:18PM +0900, Alexandre Courbot wrote:
> Declare 'struct device' explicitly in ttm_page_alloc.h as this file
> does not include any file declaring it. This removes the following
> warning:
> 
> 	warning: 'struct device' declared inside parameter list
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> This warning was visible when compiling Nouveau on -next today.
> 
>  include/drm/ttm/ttm_page_alloc.h | 2 ++
>  1 file changed, 2 insertions(+)

I don't think I've seen this on x86, but I've certainly encountered the
same warning when building nouveau on ARM, so:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-02-10 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09  9:43 [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h Alexandre Courbot
2014-02-09  9:43 ` Alexandre Courbot
2014-02-10 12:37 ` Thierry Reding [this message]
2014-02-10 12:37   ` Thierry Reding
2014-02-20  4:12   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210123757.GF20143@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gnurou@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.