[PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h

[PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h

[Alexandre Courbot]

Declare 'struct device' explicitly in ttm_page_alloc.h as this file
does not include any file declaring it. This removes the following
warning:

	warning: 'struct device' declared inside parameter list

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
This warning was visible when compiling Nouveau on -next today.

 include/drm/ttm/ttm_page_alloc.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/drm/ttm/ttm_page_alloc.h b/include/drm/ttm/ttm_page_alloc.h
index d1f61bf..49a8284 100644
--- a/include/drm/ttm/ttm_page_alloc.h
+++ b/include/drm/ttm/ttm_page_alloc.h
@@ -29,6 +29,8 @@
 #include <drm/ttm/ttm_bo_driver.h>
 #include <drm/ttm/ttm_memory.h>
 
+struct device;
+
 /**
  * Initialize pool allocator.
  */
-- 
1.8.5.4

[PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h

[Alexandre Courbot]

Declare 'struct device' explicitly in ttm_page_alloc.h as this file
does not include any file declaring it. This removes the following
warning:

	warning: 'struct device' declared inside parameter list

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
This warning was visible when compiling Nouveau on -next today.

 include/drm/ttm/ttm_page_alloc.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/drm/ttm/ttm_page_alloc.h b/include/drm/ttm/ttm_page_alloc.h
index d1f61bf..49a8284 100644
--- a/include/drm/ttm/ttm_page_alloc.h
+++ b/include/drm/ttm/ttm_page_alloc.h
@@ -29,6 +29,8 @@
 #include <drm/ttm/ttm_bo_driver.h>
 #include <drm/ttm/ttm_memory.h>
 
+struct device;
+
 /**
  * Initialize pool allocator.
  */
-- 
1.8.5.4

Re: [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 680 bytes --]

On Sun, Feb 09, 2014 at 06:43:18PM +0900, Alexandre Courbot wrote:
> Declare 'struct device' explicitly in ttm_page_alloc.h as this file
> does not include any file declaring it. This removes the following
> warning:
> 
> 	warning: 'struct device' declared inside parameter list
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> This warning was visible when compiling Nouveau on -next today.
> 
>  include/drm/ttm/ttm_page_alloc.h | 2 ++
>  1 file changed, 2 insertions(+)

I don't think I've seen this on x86, but I've certainly encountered the
same warning when building nouveau on ARM, so:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

On Sun, Feb 09, 2014 at 06:43:18PM +0900, Alexandre Courbot wrote:
> Declare 'struct device' explicitly in ttm_page_alloc.h as this file
> does not include any file declaring it. This removes the following
> warning:
> 
> 	warning: 'struct device' declared inside parameter list
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> This warning was visible when compiling Nouveau on -next today.
> 
>  include/drm/ttm/ttm_page_alloc.h | 2 ++
>  1 file changed, 2 insertions(+)

I don't think I've seen this on x86, but I've certainly encountered the
same warning when building nouveau on ARM, so:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h

[Alexandre Courbot]

Ping, David?

On Mon, Feb 10, 2014 at 9:37 PM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> On Sun, Feb 09, 2014 at 06:43:18PM +0900, Alexandre Courbot wrote:
>> Declare 'struct device' explicitly in ttm_page_alloc.h as this file
>> does not include any file declaring it. This removes the following
>> warning:
>>
>>       warning: 'struct device' declared inside parameter list
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> ---
>> This warning was visible when compiling Nouveau on -next today.
>>
>>  include/drm/ttm/ttm_page_alloc.h | 2 ++
>>  1 file changed, 2 insertions(+)
>
> I don't think I've seen this on x86, but I've certainly encountered the
> same warning when building nouveau on ARM, so:
>
> Reviewed-by: Thierry Reding <treding@nvidia.com>