All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: kexec-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org,
	Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] add fsck passno to dracut --mount args
Date: Thu, 13 Feb 2014 09:42:23 -0500	[thread overview]
Message-ID: <20140213144222.GG30844@redhat.com> (raw)
In-Reply-To: <20140212072229.GA15908-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>

On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
> We are using dracut --mount to pass fstab lines for mounting filesystems
> other than rootfs. But we did not provide passno for filesystem checking.
> 
> Add passno '2' for all the --mount targets.
> 
> Tested in F19 guest.
> 
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  mkdumprd |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- kexec-tools.orig/mkdumprd
> +++ kexec-tools/mkdumprd
> @@ -104,7 +104,7 @@ to_mount() {
>      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
>      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
>      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
> -    _mntopts="$_t $_o"
> +    _mntopts="$_t $_o 0 2"

What is 0 here. I think you are trying to emulate the format of an fstab
file and passing 5th and 6th field.

I don't think they are filesystem options. If you trying to mount a file
system with 0 and 2 passed as additional parameters, mount will complain
that what is 0 and 2 it does not understand.

I am CCing harald. He might have thoughts on what's the better way to
pass the fsck_passno of filesystem being mounted. I would not mind of
passno 2 is hardcoded for anything passed in using --mount option in
dracut.

Thanks
Vivek

       reply	other threads:[~2014-02-13 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140212072229.GA15908@dhcp-16-126.nay.redhat.com>
     [not found] ` <20140212072229.GA15908-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-02-13 14:42   ` Vivek Goyal [this message]
     [not found]     ` <20140213144222.GG30844-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-13 14:50       ` [PATCH] add fsck passno to dracut --mount args Harald Hoyer
     [not found]         ` <52FCDBB0.8080509-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-13 15:08           ` Vivek Goyal
     [not found]             ` <20140213150808.GH30844-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-14  2:40               ` Dave Young
     [not found]                 ` <20140214024031.GE4225-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-02-14  2:54                   ` Dave Young
     [not found]                     ` <20140214025452.GG4225-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-02-14  3:05                       ` Dave Young
2014-02-14  2:37       ` Dave Young
     [not found]         ` <20140214023735.GD4225-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-02-14 14:42           ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213144222.GG30844@redhat.com \
    --to=vgoyal-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kexec-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.